<div dir="ltr"><div>The brute force protection is there only to prevent guessing the password through a brute force attack. It's not there to stop DOS attacks. We don't have any rate limiting at the moment and I believe that's something that would be better introduced with a firewall / intrusion detection system.<br></div><div><br></div><div>It's non-trivial to add, especially with the fact that a single client that invokes the direct grant login could have thousands of legitimate users. I don't think a simple implementation would be much value and not replace a full fledged firewall.<br></div><div><br></div><div>What did you have in mind with regards to requirements? Ability to configure max number of requests per-client? Per-user?</div><div><br></div><div>For the OOM the events endpoints supports pagination as well as date ranges which should prevent and OOM issue when querying it.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 2 September 2016 at 15:44, Cory Snyder <span dir="ltr"><<a href="mailto:csnyder@iland.com" target="_blank">csnyder@iland.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">
<div>Hey guys,</div>
<div><br>
</div>
<div>We ran into an issue recently where a customer didn’t have a great understanding of the OAuth2 authorization process and was submitting many direct grant login requests per second. They were successfully authenticating each time, so the brute
force protection features don’t apply. It basically ended up being a DOS issue. We also ended up having OOM issues when trying to query the events for this customer during a scheduled job that we use to build reports on login events. We’re still running 1.8.2
at the moment, so I’m wondering if you guys have implemented any kind of rate limiting / DOS prevention that could have prevented this in one of the later releases? If not, I'm proposing that it might be worth considering, I could try to contribute something
if you like. What do you guys think?</div>
<div><br>
</div>
<div>Thanks,</div>
<br>
<div>
<div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word">
<div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word">
<div style="text-align:start;text-indent:0px;word-wrap:break-word">
<div style="text-align:start;text-indent:0px;word-wrap:break-word">
<div style="color:rgb(0,0,0);letter-spacing:normal;text-transform:none;white-space:normal;word-spacing:0px;font-family:Arial,Helvetica,sans-serif;font-size:13px">
<div style="margin:0in 0in 0pt;color:rgba(0,0,0,0.870588);font-size:10pt;line-height:14px;font-family:Arial,sans-serif;background-color:rgb(255,255,255)">
<div style="margin:0in 0in 0pt;font-size:10pt;line-height:14px">
Cory Snyder</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
</div>
<br>______________________________<wbr>_________________<br>
keycloak-dev mailing list<br>
<a href="mailto:keycloak-dev@lists.jboss.org">keycloak-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/keycloak-dev</a><br></blockquote></div><br></div>