<div dir="ltr"><div>I like that solution, with 2 timestamps for create and lastUpdated + the admin view. I'll have a look at how much work and how fast I can get a PR up.<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 13, 2016 at 2:13 PM, Marek Posolda <span dir="ltr"><<a href="mailto:mposolda@redhat.com" target="_blank">mposolda@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div>+1<br>
<br>
Will be also good to display timestamp in admin console IMO.<br>
<br>
The question is if it's sufficient to put date on UserConsentModel
as in scenario like:<br>
- User authenticates in time1 and gives consent to client "foo"
with 2 roles and 2 protocol mappers<br>
- In the meantime admin grants new role "bar"<br>
- Another login in time2, user will need again to consent the
newly added role "bar" <br>
<br>
So should be timestamp set on time1 (when consent was created) or
on time2 (when there was last update) ? Or should we rather have 2
timestamps ("createdDate" and "lastUpdateDate" )? Another
possibility will be the timestamp on every role and
protocolMapper, but this looks like quite an overhead.<br>
<br>
So maybe 2 timestamps for create and lastUpdate and display both
in admin console in "consents" tab table will be sufficient?<span class="HOEnZb"><font color="#888888"><br>
<br>
Marek</font></span><div><div class="h5"><br>
<br>
On 13/09/16 10:51, Stian Thorgersen wrote:<br>
</div></div></div><div><div class="h5">
<blockquote type="cite">
<div dir="ltr">I've got no issues with us adding it. If you add it
to the DTO-like objects and implement support for both JPA and
Mongo as well as add tests for it I'd be happy to accept a PR.
Would also need updates to the Liquibase changelogs to add any
required fields (assuming that's required).
<div><br>
</div>
<div>Marek - do you have any comments?</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On 13 September 2016 at 10:42, Geir Ole
Hiåsen Stevning <span dir="ltr"><<a href="mailto:gostevning@gmail.com" target="_blank">gostevning@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<p class="MsoNormal"><span lang="EN-US">Hi!<span></span></span></p>
<p class="MsoNormal"><span lang="EN-US"> </span></p>
<p class="MsoNormal"><span lang="EN-US">We have a
use case where we need to know the time for when an
End-User has given consent.
Would it be possible to add a Date-like field in
either
UserConsentProtocolMapperEntit<wbr>y,
UserConsentRoleEntity or UserConsentEntity, as
we are using the JPA provider.<span></span></span></p>
<p class="MsoNormal"><span lang="EN-US"> </span></p>
<p class="MsoNormal"><span lang="EN-US">Furthermore,
propagate this field in the corresponding DTO-like
objects as UserConsentModel
etc. Doing this will probably mean that additional
providers will need to
populate the field, i.e. mongo.<span></span></span></p>
<p class="MsoNormal"><span lang="EN-US"> </span></p>
<p class="MsoNormal"><span lang="EN-US">Is this
something that you guys think is a good idea? I would
be able to create a PR if
you would like that.<span><font color="#888888"><span></span></font></span></span></p>
<span><font color="#888888">
<div><br>
</div>
--
<div>Geir Ole H. Stevning</div>
</font></span></div>
<br>
______________________________<wbr>_________________<br>
keycloak-dev mailing list<br>
<a href="mailto:keycloak-dev@lists.jboss.org" target="_blank">keycloak-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/keycloak-dev</a><br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<p><br>
</p>
</div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>Geir Ole H. Stevning</div></div></div>
</div>