<html><body bgcolor="#FFFFFF"><div>I too think there is not really a reason to change the status quo and agree with these reasons,<br><br>Sent from my iPhone</div><div><br>On Nov 21, 2009, at 2:16 AM, jan de vries <<a href="mailto:jandevries145@fastmail.fm">jandevries145@fastmail.fm</a>> wrote:<br><br></div><div></div><blockquote type="cite"><div>
Not that i think i'm the best judge in this but for what its worth:<br>
<br>
1) I think that might be a little better than ChannelPipelineCoverage
but i don't think<br>
ChannelPipelineCoverage was that unclear with the documentation.<br>
2)It's a handy feature if you want to store extra info in the handler
and if you want <br>
to go for minimal memory usage you can easily use shared handlers. As
far as <br>
difficulty is concerned, the documentation is very clear. Although it
is a feature <br>
which you cant grasp by just looking at the name alone, its still very
usefull and forces <br>
the user a little to think about which data is stored in the handler.
The idea of the feature <br>
is good, it fits in the scope of the framework and with the
documentation its more <br>
then clear enough. <br>
<br>
1b) Since i dont think Shared is way better then
ChannelPipelineCoverage, i tend<br>
to prefer to keep the things as they were, but either way wont be much
of an issue.<br>
<br>
PS<br>
<br>
I have been away for a while but i'm glad to see netty is still going
very<br>
strong. The project i worked on with netty (involving a flash game
server) sort<br>
of collapsed on itself purely because of personal arguments between
team <br>
members. I was to busy developing while others were busy arguing :(.
That kinda <br>
totally sucked since it worked very well technically. Anyway, i
gathered <br>
the old work and i'm giving a second live to it. I hope it will be
more successful then <br>
the first attempt. I just want to send my special thanks to Trustin
who made netty<br>
possible and of course the posters and especially the loyal ones who
help Trustin<br>
and all of us by testing and sharing ideas. I think netty is one of the
gems in the<br>
java-libraries. <br>
<br>
regards,<br>
jan<br>
<br>
Trustin Lee (이희승) wrote:
<blockquote cite="mid:aa4319810911210106n64bba189jfccc60ed519f7531@mail.gmail.com" type="cite">
<pre wrap="">Before making the final decision ...
1) (@Shared and @Unshared) or (@SharedHandler vs @UnsharedHandler)?
2) Would it be a better idea to just get rid of
@ChannelPipelineCoverage without replacement?
-- Trustin Lee, <a class="moz-txt-link-freetext" href="http://gleamynode.net/"><a href="http://gleamynode.net/">http://gleamynode.net/</a></a>
On Mon, Nov 9, 2009 at 8:12 PM, Christian Migowski <a class="moz-txt-link-rfc2396E" href="mailto:chrismfwrd@gmail.com"><<a href="mailto:chrismfwrd@gmail.com">chrismfwrd@gmail.com</a>></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">2009/11/9 Trustin Lee (이희승) <a class="moz-txt-link-rfc2396E" href="mailto:trustin@gmail.com"><<a href="mailto:trustin@gmail.com">trustin@gmail.com</a>></a>:
</pre>
<blockquote type="cite">
<pre wrap="">Hey Iain,
On Mon, Nov 9, 2009 at 7:45 PM, Iain McGinniss <a class="moz-txt-link-rfc2396E" href="mailto:iainmcgin@gmail.com"><<a href="mailto:iainmcgin@gmail.com">iainmcgin@gmail.com</a>></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">How about @SharedHandler and @UnsharedHandler? @Shared describes
Mike's usage, where he has a handler used by multiple pipelines but
within which he has implemented the appropriate logic to avoid
threading issues.
</pre>
</blockquote>
<pre wrap="">I love this idea.
</pre>
</blockquote>
<pre wrap="">I also think this is a good suggestion, better then Stateful and Stateless.
regards,
christian!
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">A side question: does netty actually check these annotations at
runtime, to make sure an unshared handler instance is not used by
multiple pipelines?
</pre>
</blockquote>
<pre wrap="">Currently only for documentation purpose, but I'd like to add some
runtime check.
Thanks!
</pre>
<blockquote type="cite">
<pre wrap="">Iain
On 9 Nov 2009, at 00:12, Trustin Lee (이희승) wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Good point. Then, do you have some suggestion for a better name than
ChannelPipelineCoverage, or do you think it's just fine? I think
there might be a better name that makes it easier to understand.
Thanks
-- Trustin Lee, <a class="moz-txt-link-freetext" href="http://gleamynode.net/"><a href="http://gleamynode.net/">http://gleamynode.net/</a></a>
On Mon, Nov 9, 2009 at 7:00 AM, Mike McGrady
<a class="moz-txt-link-rfc2396E" href="mailto:mmcgrady@topiatechnology.com"><<a href="mailto:mmcgrady@topiatechnology.com">mmcgrady@topiatechnology.com</a>></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi, Trustin,
I think that the present annotations are more explicit. The present
annotations say what is actually happening. The stateful and
stateless annotations would not actually fit what is happening with
my
code. I use stateful code with "all" and this is not a problem. If
the annotation were changed I would have "stateless" as the
annotation
but have a stateful handler.
Mike
On Nov 8, 2009, at 1:24 PM, Trustin Lee (이희승) wrote:
</pre>
<blockquote type="cite">
<pre wrap="">What do you think about replacing ChannelPipelineCoverage with more
explicit annotations such as @Stateful and @Stateless?
ChannelPipelineCoverage has a confusing name (at least for a
beginner), and its value cannot be validated on compile time because
it's string.
-- Trustin Lee, <a class="moz-txt-link-freetext" href="http://gleamynode.net/"><a href="http://gleamynode.net/">http://gleamynode.net/</a></a>
_______________________________________________
netty-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:netty-dev@lists.jboss.org"><a href="mailto:netty-dev@lists.jboss.org">netty-dev@lists.jboss.org</a></a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/netty-dev"><a href="https://lists.jboss.org/mailman/listinfo/netty-dev">https://lists.jboss.org/mailman/listinfo/netty-dev</a></a>
</pre>
</blockquote>
<pre wrap="">Mike McGrady
Principal Investigator AF081-028 AFRL SBIR
Senior Engineer
Topia Technology, Inc.
1.253.720.3365
<a class="moz-txt-link-abbreviated" href="mailto:mmcgrady@topiatechnology.com"><a href="mailto:mmcgrady@topiatechnology.com">mmcgrady@topiatechnology.com</a></a>
_______________________________________________
netty-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:netty-dev@lists.jboss.org"><a href="mailto:netty-dev@lists.jboss.org">netty-dev@lists.jboss.org</a></a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/netty-dev"><a href="https://lists.jboss.org/mailman/listinfo/netty-dev">https://lists.jboss.org/mailman/listinfo/netty-dev</a></a>
</pre>
</blockquote>
<pre wrap="">_______________________________________________
netty-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:netty-dev@lists.jboss.org"><a href="mailto:netty-dev@lists.jboss.org">netty-dev@lists.jboss.org</a></a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/netty-dev"><a href="https://lists.jboss.org/mailman/listinfo/netty-dev">https://lists.jboss.org/mailman/listinfo/netty-dev</a></a>
</pre>
</blockquote>
<pre wrap="">_______________________________________________
netty-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:netty-dev@lists.jboss.org"><a href="mailto:netty-dev@lists.jboss.org">netty-dev@lists.jboss.org</a></a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/netty-dev"><a href="https://lists.jboss.org/mailman/listinfo/netty-dev">https://lists.jboss.org/mailman/listinfo/netty-dev</a></a>
</pre>
</blockquote>
<pre wrap="">-- Trustin Lee, <a class="moz-txt-link-freetext" href="http://gleamynode.net/"><a href="http://gleamynode.net/">http://gleamynode.net/</a></a>
_______________________________________________
netty-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:netty-dev@lists.jboss.org"><a href="mailto:netty-dev@lists.jboss.org">netty-dev@lists.jboss.org</a></a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/netty-dev"><a href="https://lists.jboss.org/mailman/listinfo/netty-dev">https://lists.jboss.org/mailman/listinfo/netty-dev</a></a>
</pre>
</blockquote>
<pre wrap="">_______________________________________________
netty-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:netty-dev@lists.jboss.org"><a href="mailto:netty-dev@lists.jboss.org">netty-dev@lists.jboss.org</a></a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/netty-dev"><a href="https://lists.jboss.org/mailman/listinfo/netty-dev">https://lists.jboss.org/mailman/listinfo/netty-dev</a></a>
</pre>
</blockquote>
<pre wrap=""><!---->
_______________________________________________
netty-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:netty-dev@lists.jboss.org"><a href="mailto:netty-dev@lists.jboss.org">netty-dev@lists.jboss.org</a></a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/netty-dev"><a href="https://lists.jboss.org/mailman/listinfo/netty-dev">https://lists.jboss.org/mailman/listinfo/netty-dev</a></a>
</pre>
</blockquote>
<br>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>netty-dev mailing list</span><br><span><a href="mailto:netty-dev@lists.jboss.org">netty-dev@lists.jboss.org</a></span><br><span><a href="https://lists.jboss.org/mailman/listinfo/netty-dev">https://lists.jboss.org/mailman/listinfo/netty-dev</a></span><br></div></blockquote></body></html>