Would you prefer I open a ticket and submit a more formal patch, Trustin?<br><br><div class="gmail_quote">On Tue, Nov 3, 2009 at 10:34 PM, Adam Fisk <span dir="ltr"><<a href="mailto:a@littleshoot.org">a@littleshoot.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">OK - finally knocked this off, and it's working beautifully in FireFox and Safari. All the credit really goes to Stephen - I'm just implementing his fix here.<div>
<br></div><div>I agree with some of the earlier comments that since HttpMessage and its subclasses are already mutable, it's not a big loss to add another mutable field. That's the approach I took with the patch. I also think it makes sense to keep HttpChunk immutable unless there's a concrete need to make it mutable. I also don't think this is indicative of a design flaw.</div>
<div><br></div><div>Feel free to change the style, approach, or comments as you see fit, Trustin. Thanks again Stephen. I like that handy netcat trick, by the way!</div><div><br></div><font color="#888888"><div>-Adam</div>
</font><div><div><div></div><div class="h5"><br><br><div class="gmail_quote">
On Tue, Nov 3, 2009 at 8:47 PM, Stephen Haberman <span dir="ltr"><<a href="mailto:stephen@exigencecorp.com" target="_blank">stephen@exigencecorp.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><br>
> I'm also happy to give you commit permissions if you like. This in<br>
> particular is clearly a Netty and not a LittleProxy issue, but I can<br>
> give you access to the repo if you need to make any changes going<br>
> forward.<br>
<br>
</div>That's fine--I enjoyed tracking the bug down and also reading through<br>
the LittleProxy code.<br>
<br>
My proxy is more of a weekend (or two or three) hobby project--I<br>
wouldn't be surprised if its missing several boundary cases that<br>
LittleProxy handles more robustly.<br>
<br>
But I did finally get it into github:<br>
<br>
<a href="http://github.com/stephenh/fakehttp" target="_blank">http://github.com/stephenh/fakehttp</a><br>
<br>
Being a hobby project, I also wrote it in Scala and, purposefully<br>
trying to keep it small, have kept it to ~450 LOC so far.<br>
<div><div></div><div><br>
- Stephen<br>
<br>
_______________________________________________<br>
netty-users mailing list<br>
<a href="mailto:netty-users@lists.jboss.org" target="_blank">netty-users@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/netty-users" target="_blank">https://lists.jboss.org/mailman/listinfo/netty-users</a><br>
</div></div></blockquote></div><br><br clear="all"><br></div></div><div class="im">-- <br>Adam Fisk<br><a href="http://www.littleshoot.org" target="_blank">http://www.littleshoot.org</a> | <a href="http://adamfisk.wordpress.com" target="_blank">http://adamfisk.wordpress.com</a> | <a href="http://twitter.com/adamfisk" target="_blank">http://twitter.com/adamfisk</a><br>
</div></div>
</blockquote></div><br><br clear="all"><br>-- <br>Adam Fisk<br><a href="http://www.littleshoot.org">http://www.littleshoot.org</a> | <a href="http://adamfisk.wordpress.com">http://adamfisk.wordpress.com</a> | <a href="http://twitter.com/adamfisk">http://twitter.com/adamfisk</a><br>