Or are you saying you want the license attached to the patch file itself?<br><br><div class="gmail_quote">On Fri, Nov 6, 2009 at 1:24 PM, Adam Fisk <span dir="ltr"><<a href="mailto:a@littleshoot.org">a@littleshoot.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">The patch doesn't change the license headers in those files at all, Trustin, since it's just patching them. If you glance at it, it's a total of maybe 15 lines, mostly comments. <div>
<br></div><div>Can you point me towards the contributor license agreement? I couldn't find it on the site.<div>
<br></div><font color="#888888"><div>-Adam</div></font><div><div><div></div><div class="h5"><br><br><div class="gmail_quote">On Thu, Nov 5, 2009 at 6:49 PM, Trustin Lee (이희승) <span dir="ltr"><<a href="mailto:trustin@gmail.com" target="_blank">trustin@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I'm just fine as long as you put the correct license header and signed<br>
up the contributor license agreement. :)<br>
<br>
— Trustin Lee, <a href="http://gleamynode.net/" target="_blank">http://gleamynode.net/</a><br>
<div><div></div><div><br>
<br>
<br>
On Fri, Nov 6, 2009 at 7:48 AM, Adam Fisk <<a href="mailto:a@littleshoot.org" target="_blank">a@littleshoot.org</a>> wrote:<br>
> Would you prefer I open a ticket and submit a more formal patch, Trustin?<br>
><br>
> On Tue, Nov 3, 2009 at 10:34 PM, Adam Fisk <<a href="mailto:a@littleshoot.org" target="_blank">a@littleshoot.org</a>> wrote:<br>
>><br>
>> OK - finally knocked this off, and it's working beautifully in FireFox and<br>
>> Safari. All the credit really goes to Stephen - I'm just implementing his<br>
>> fix here.<br>
>> I agree with some of the earlier comments that since HttpMessage and its<br>
>> subclasses are already mutable, it's not a big loss to add another mutable<br>
>> field. That's the approach I took with the patch. I also think it makes<br>
>> sense to keep HttpChunk immutable unless there's a concrete need to make it<br>
>> mutable. I also don't think this is indicative of a design flaw.<br>
>> Feel free to change the style, approach, or comments as you see fit,<br>
>> Trustin. Thanks again Stephen. I like that handy netcat trick, by the way!<br>
>> -Adam<br>
>><br>
>> On Tue, Nov 3, 2009 at 8:47 PM, Stephen Haberman<br>
>> <<a href="mailto:stephen@exigencecorp.com" target="_blank">stephen@exigencecorp.com</a>> wrote:<br>
>>><br>
>>> > I'm also happy to give you commit permissions if you like. This in<br>
>>> > particular is clearly a Netty and not a LittleProxy issue, but I can<br>
>>> > give you access to the repo if you need to make any changes going<br>
>>> > forward.<br>
>>><br>
>>> That's fine--I enjoyed tracking the bug down and also reading through<br>
>>> the LittleProxy code.<br>
>>><br>
>>> My proxy is more of a weekend (or two or three) hobby project--I<br>
>>> wouldn't be surprised if its missing several boundary cases that<br>
>>> LittleProxy handles more robustly.<br>
>>><br>
>>> But I did finally get it into github:<br>
>>><br>
>>> <a href="http://github.com/stephenh/fakehttp" target="_blank">http://github.com/stephenh/fakehttp</a><br>
>>><br>
>>> Being a hobby project, I also wrote it in Scala and, purposefully<br>
>>> trying to keep it small, have kept it to ~450 LOC so far.<br>
>>><br>
>>> - Stephen<br>
>>><br>
>>> _______________________________________________<br>
>>> netty-users mailing list<br>
>>> <a href="mailto:netty-users@lists.jboss.org" target="_blank">netty-users@lists.jboss.org</a><br>
>>> <a href="https://lists.jboss.org/mailman/listinfo/netty-users" target="_blank">https://lists.jboss.org/mailman/listinfo/netty-users</a><br>
>><br>
>><br>
>><br>
>> --<br>
>> Adam Fisk<br>
>> <a href="http://www.littleshoot.org" target="_blank">http://www.littleshoot.org</a> | <a href="http://adamfisk.wordpress.com" target="_blank">http://adamfisk.wordpress.com</a> |<br>
>> <a href="http://twitter.com/adamfisk" target="_blank">http://twitter.com/adamfisk</a><br>
><br>
><br>
><br>
> --<br>
> Adam Fisk<br>
> <a href="http://www.littleshoot.org" target="_blank">http://www.littleshoot.org</a> | <a href="http://adamfisk.wordpress.com" target="_blank">http://adamfisk.wordpress.com</a> |<br>
> <a href="http://twitter.com/adamfisk" target="_blank">http://twitter.com/adamfisk</a><br>
><br>
> _______________________________________________<br>
> netty-users mailing list<br>
> <a href="mailto:netty-users@lists.jboss.org" target="_blank">netty-users@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/netty-users" target="_blank">https://lists.jboss.org/mailman/listinfo/netty-users</a><br>
><br>
><br>
<br>
_______________________________________________<br>
netty-users mailing list<br>
<a href="mailto:netty-users@lists.jboss.org" target="_blank">netty-users@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/netty-users" target="_blank">https://lists.jboss.org/mailman/listinfo/netty-users</a><br>
</div></div></blockquote></div><br><br clear="all"><br></div></div>-- <br><div class="im">Adam Fisk<br><a href="http://www.littleshoot.org" target="_blank">http://www.littleshoot.org</a> | <a href="http://adamfisk.wordpress.com" target="_blank">http://adamfisk.wordpress.com</a> | <a href="http://twitter.com/adamfisk" target="_blank">http://twitter.com/adamfisk</a><br>
</div></div></div>
</blockquote></div><br><br clear="all"><br>-- <br>Adam Fisk<br><a href="http://www.littleshoot.org">http://www.littleshoot.org</a> | <a href="http://adamfisk.wordpress.com">http://adamfisk.wordpress.com</a> | <a href="http://twitter.com/adamfisk">http://twitter.com/adamfisk</a><br>