OK Trustin,<div><br></div><div>I'll give it a go over the next 2-3 weeks (my day job is getting a bit busy).</div><div><br></div><div>I'm not sure how this fits into your release time frames but if anyone else can do it sooner, let me know. Don't want to unnecessarily double up effort.</div>
<div><br></div><div>Thanks</div><div><br></div><div>Regards</div><div>Vibul</div><div><br><br><div class="gmail_quote">On 26 August 2011 14:01, ÀÌÈñ½Â (Trustin Lee) <span dir="ltr"><<a href="mailto:trustin@gmail.com">trustin@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div>
Hi,
</div><div><br></div><div>Sure. It would be great if Netty could provide the up-to-date Web Socket codec and everyone can leverage it. Please feel free to contact the authors.</div><div><br></div><div>If supporting hixie 75/76 and hybi drafts together is not too complex, I'm OK with the suggestion. We will see what we can do with protocol version management soon. :-)</div>
<div><br></div><div>Cheers </div>
<div><br>-- <br><font color="#888888"><a href="http://gleamynode.net/" target="_blank">Trustin Lee</a><br></font></div><div><div></div><div class="h5">
<p style="color:#A0A0A8">On Wednesday, August 17, 2011 at 9:01 AM, Vibul Imtarnasan wrote:</p>
<blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px">
<span><div><div>Hi,<div><br></div><div>In doing some surfing around, I found that the webbit web server (based on netty) has already implemented this.</div><div><br></div><div><a href="https://github.com/joewalnes/webbit/tree/0356ba12f5c21f8a297a5afb433215bb2f738008/src/main/java/org/webbitserver/netty" target="_blank">https://github.com/joewalnes/webbit/tree/0356ba12f5c21f8a297a5afb433215bb2f738008/src/main/java/org/webbitserver/netty</a></div>
<div><br></div><div>Should we attempt to take the work that has already been done and merge it into Netty? The work is published under a BSD license. If yes, I'll attempt to contact the authors and see if they wish to take part in this exercise.</div>
<div><br></div><div><br></div><div>Also, I'm coming around to the thinking that we should support <b><u>both </u></b>the existing hixie 75 and 76 as well as the new hybi standard. The reasons for this are:</div><div>
<br></div><div>1. Although Chrome and Firefox are upgrading, there is no news for Safari as yet.</div><div><br></div><div>2. There are existing hixie client libraries that are being used in existing apps. Netty based apps that rely on this may resist upgrading netty if hixie is no longer available. For example, HornetQ.</div>
<div><br></div><div>3. What if there is a new version of hybi in 12 month's time. We may as well build in a framework for protocol version management now.</div><div><br></div><div><br></div><div>Thoughts?</div><div>
<br>
</div><div>Regards</div><div>Vibul</div><div><br></div><div><br></div><div><br><div>On 17 August 2011 09:40, ÀÌÈñ½Â (Trustin Lee) <span dir="ltr"><<a href="mailto:trustin@gmail.com" target="_blank">trustin@gmail.com</a>></span> wrote:<br>
<blockquote type="cite"><div>
<div>Hi Oli,<div><br></div><div>Thanks for trying to help us! I really appreciate that.</div><div><br></div><div>I believe the latest draft changed quite a lot from the older ones. Last time I checked, both handshake and frame format were changed. Therefore, the existing handshake code will need a rewrite.</div>
<div><br></div><div>HTH</div></div>
<div><br>-- <br><font color="#888888"><a href="http://gleamynode.net/" target="_blank">Trustin Lee</a><br></font></div><div><div>
<p style="color:#A0A0A8">On Wednesday, August 17, 2011 at 3:18 AM, wool.in.silver wrote:</p><blockquote type="cite"><div>
<span><div><div>Hi Trustin / Vibul,<br><br>I would agree that there is no need to retain support for the older Hixie-76<br>version of the protocol, as (for example) Chromium 14 seems to have dropped<br>
support for that version.<br><br>I can perhaps help with testing any new implementation. My organisation is<br>using Netty to develop WebSocket applications; we see that to support<br>Chromium 14 (and apparently Firefox 6) we will need code changes. Probably<br>
we will not support earlier browsers due to security concerns with earlier<br>versions of the WebSocket protocol.<br><br>Am I correct to say that both the handshake *and* framing for WebSockets has<br>changed in version HyBi-10? Where would changes need to be made to Netty -<br>
it is confined to the handshake method and the WebSocketFrameDecoder/Encoder<br>classes I believe?<br><br>Yours,<br>Oli<br><br>--<br>View this message in context: <a href="http://netty-forums-and-mailing-lists.685743.n2.nabble.com/Websocket-draft-ietf-hybi-thewebsocketprotocol-10-tp6672115p6692350.html" target="_blank">http://netty-forums-and-mailing-lists.685743.n2.nabble.com/Websocket-draft-ietf-hybi-thewebsocketprotocol-10-tp6672115p6692350.html</a><br>
Sent from the Netty User Group mailing list archive at <a href="http://Nabble.com" target="_blank">Nabble.com</a>.<br>_______________________________________________<br>netty-users mailing list<br><a href="mailto:netty-users@lists.jboss.org" target="_blank">netty-users@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/netty-users" target="_blank">https://lists.jboss.org/mailman/listinfo/netty-users</a><br></div></div></span>
</div></blockquote><div>
<br>
</div>
</div></div><br>_______________________________________________<br>
netty-users mailing list<br>
<a href="mailto:netty-users@lists.jboss.org" target="_blank">netty-users@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/netty-users" target="_blank">https://lists.jboss.org/mailman/listinfo/netty-users</a><br></div></blockquote></div><br></div>
</div><div>_______________________________________________<br>netty-users mailing list<br><a href="mailto:netty-users@lists.jboss.org" target="_blank">netty-users@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/netty-users" target="_blank">https://lists.jboss.org/mailman/listinfo/netty-users</a><br>
</div></div></span>
</blockquote>
<div>
<br>
</div>
</div></div><br>_______________________________________________<br>
netty-users mailing list<br>
<a href="mailto:netty-users@lists.jboss.org">netty-users@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/netty-users" target="_blank">https://lists.jboss.org/mailman/listinfo/netty-users</a><br></blockquote></div><br></div>