[overlord-issues] [JBoss JIRA] (RTGOV-329) Consider refactoring/cleanup of ActivtyServerLogger

[Gary Brown (JIRA)]

     [ https://issues.jboss.org/browse/RTGOV-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Brown updated RTGOV-329:
-----------------------------
    Fix Version/s:     (was: 2.1.0.Final)


> Consider refactoring/cleanup of ActivtyServerLogger
> ---------------------------------------------------
>
>                 Key: RTGOV-329
>                 URL: https://issues.jboss.org/browse/RTGOV-329
>             Project: RTGov (Run Time Governance)
>          Issue Type: Quality Risk
>          Components: Activity Collector
>    Affects Versions: 1.0.0.Final
>            Reporter: Jiri Pechanec
>            Assignee: Gary Brown
>         Attachments: Performance.java
>
>
> 1) I consider the code to be overcomplicated - are we really getting any performance boost with reusing the ArrayList of events? I found on the web that clear() might be even slower than new allocation
> 2) There is unsynced access to fields _sequenceNumber and _failuresSinceLastSuccess
> 3) I am not sure if it is wise to mix synchronization on Java level - _timer in BatchedActivityUnitLogger - and Java EE level - method synchornization on @Singleton



--
This message was sent by Atlassian JIRA
(v6.3.1#6329)