<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 05/05/2016 03:46 PM, Weinan Li
wrote:<br>
</div>
<blockquote
cite="mid:E69D182F-D511-4C21-9748-32046DDB84FB@redhat.com"
type="cite">
<pre wrap="">
--
Weinan Li / JBoss
</pre>
<blockquote type="cite">
<pre wrap="">On May 5, 2016, at 9:21 PM, Rostislav Svoboda <a class="moz-txt-link-rfc2396E" href="mailto:rsvoboda@redhat.com"><rsvoboda@redhat.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
On 05/04/2016 11:36 AM, Weinan Li wrote:
</pre>
<blockquote type="cite">
<pre wrap="">--
Weinan Li / JBoss
</pre>
<blockquote type="cite">
<pre wrap="">On May 4, 2016, at 8:02 PM, Rostislav Svoboda <a class="moz-txt-link-rfc2396E" href="mailto:rsvoboda@redhat.com"><rsvoboda@redhat.com></a> wrote:
Moving the discussion to the mailing list ++ adding few notes about the
project structure and TS.
Structure:
- why is there one module jaxrs in the root of repo -
<a class="moz-txt-link-freetext" href="https://github.com/resteasy/Resteasy">https://github.com/resteasy/Resteasy</a> ?
</pre>
</blockquote>
<pre wrap="">It's added by Bill but I forget the reason. I don't like it either :-) We
can remove it now as JAX-RS is moved outside RESTEasy repo.
</pre>
<blockquote type="cite">
<pre wrap="">- there are too many modules (in root jaxrs module) from my perspective
-- multi module project structure can affect build time
-- find . | grep pom.xml | wc -l reports 226 pom.xml files
</pre>
</blockquote>
<pre wrap="">The 'example' module contains all the Bill's book examples. We need to ask
him for permission to move these away.
</pre>
</blockquote>
<pre wrap="">
They go into the distribution zip file.
</pre>
</blockquote>
<pre wrap="">
ok, proper isolation in project as suggested by Alession is probably the best option.
And there will be no regression in stuff delivered in zip.
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap=""> -- find . | grep pom.xml | grep -v arquillian | grep -v exam | grep -v
test | wc -l reports 58 pom.xml files
- not clear where is the real code and what is just add-odd like examples,
book stuff
- naming of modules in not in sync, some are starting resteasy-*, some do
not have such prefix
Commits:
- commit messages do not follow same/similar format - see
<a class="moz-txt-link-freetext" href="https://github.com/resteasy/Resteasy/commits/master">https://github.com/resteasy/Resteasy/commits/master</a>
-- I would expect jira id at the beginning of the commit message, it's
there sometime but in different format - e.g. RESTEASY-1328 vs.
[RESTEASY-1331]
</pre>
</blockquote>
</blockquote>
<pre wrap="">
Even better is the whole URL, so you can click and go there.
</pre>
</blockquote>
<pre wrap="">
Not so sure, [RESTEASY-xxx] is the best option from my side, jira can handle integration / parsing of commit messages
</pre>
<blockquote type="cite">
<pre wrap="">
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">- massive commit message like
<a class="moz-txt-link-freetext" href="https://github.com/resteasy/Resteasy/commit/fdd1f9f31edb894fa6f8684f2608224c39519e6c">https://github.com/resteasy/Resteasy/commit/fdd1f9f31edb894fa6f8684f2608224c39519e6c</a>
- commit related to RESTEASY-1323 are really "fun"
-- <a class="moz-txt-link-freetext" href="https://github.com/resteasy/Resteasy/pull/756/files">https://github.com/resteasy/Resteasy/pull/756/files</a>
-- one fix in code (4 lines removed) + two tests done in 7 commits :(
-- these commits should have been squashed
</pre>
</blockquote>
<pre wrap="">+1
</pre>
<blockquote type="cite">
<pre wrap="">Versions:
- will leave this to Tomaz :)
TS:
- unit tests are mixed with integration tests
-- integration tests should be in separate module
-- tests should be running in different maven phases
- there are only few tests against WF
- such tests are not executed against latest WF, but mainly against WF 8
</pre>
</blockquote>
</blockquote>
<pre wrap="">
At some point I started adding new arquillian tests to RESTEASY-TEST-WF8
to reduce the number of times wildfly starts up. I have a
RESTEASY-TEST-WF10, but it depends on JDK 1.8, so it's not activated yet.
</pre>
</blockquote>
<pre wrap="">
Shouldn't be JDK 8 the default ?
Public JDK 7 is not receiving updates for 1 year - see <a class="moz-txt-link-freetext" href="http://www.oracle.com/technetwork/java/eol-135779.html">http://www.oracle.com/technetwork/java/eol-135779.html</a> or <a class="moz-txt-link-freetext" href="http://www.oracle.com/technetwork/java/javase/downloads/jdk7-downloads-1880260.html">http://www.oracle.com/technetwork/java/javase/downloads/jdk7-downloads-1880260.html</a>
Last release was April 2015</pre>
</blockquote>
</blockquote>
Is it really necessary to support RESTEasy with JDK7?<br>
For WF10: Java 7 support has been discontinued allowing for deeper
integration with the Java 8 runtime.
<blockquote
cite="mid:E69D182F-D511-4C21-9748-32046DDB84FB@redhat.com"
type="cite">
<blockquote type="cite">
<pre wrap="">
</pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">- I would like to see ARQ + WF10+ and get rid of tjws
</pre>
</blockquote>
<pre wrap="">Get ridding of TJWS is not practical because it will make the test time
unacceptable. But replacing them with undertow container would be great
:-)
</pre>
</blockquote>
<pre wrap="">
A lot of tests just don't depend on the environment. I create arquillian
</pre>
</blockquote>
<pre wrap="">
But there are tests which pass on tjws, but failed with WF10 / EAP7, you can check the jira link I shared in previous email or see below</pre>
</blockquote>
</blockquote>
<ul>
<li>I run upstream TS on perf-machine. I build resteasy. Then I
run tests: <br>
</li>
<ul>
<li>Tests tooks 10 minutes.</li>
</ul>
<li>I run qe-internal-resteasy-ts on the same perf-machine.
Qe-internal-resteasy-ts contains all tests from upstream. These
tests are run against EAP.</li>
<ul>
<li>Tests tooks 13 minutes. </li>
</ul>
</ul>
So in my point of view, test time with ARQ + WF10 is definitelly
acceptable.<br>
<br>
Marek<br>
<blockquote
cite="mid:E69D182F-D511-4C21-9748-32046DDB84FB@redhat.com"
type="cite">
<blockquote type="cite">
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">tests only when the environment seems to matter. I agree it would be
nice to use undertow, but who's going to take the time to do that?
</pre>
</blockquote>
<pre wrap="">
There is product TS which can be reused / pulled back.
</pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">
EAP 7 situation for TS:
- we migrated upstream ts to use ARQ and run against EAP 7 and not tjws
- we discovered half of reported issues thanks to this migrated TS, these
issues wouldn't be noticed bu community TS executed against tjws
</pre>
</blockquote>
<pre wrap="">Totally removing TJWS is also not possible, because many users are using
this 'internal' feature in their production env. We can't estimate how the
impact will be.
</pre>
</blockquote>
</blockquote>
<pre wrap="">
Well, I'm surprised about tjws use in production environment
quick check shows this:
resteasy-jaxrs-3.0.16.Final-redhat-1.jar | grep tjws
0 02-22-2016 03:06 org/jboss/resteasy/plugins/server/tjws/
2015 02-22-2016 03:06 org/jboss/resteasy/plugins/server/tjws/TJWSServletDispatcher.class
2110 02-22-2016 03:06 org/jboss/resteasy/plugins/server/tjws/TJWSServletServer$FileMappingServe.class
5244 02-22-2016 03:06 org/jboss/resteasy/plugins/server/tjws/TJWSServletServer.class
1467 02-22-2016 03:06 org/jboss/resteasy/plugins/server/tjws/AuthenticatedHttpServletRequest.class
3172 02-22-2016 03:06 org/jboss/resteasy/plugins/server/tjws/TJWSRequestPreProcessor.class
3136 02-22-2016 03:06 org/jboss/resteasy/plugins/server/tjws/TJWSEmbeddedJaxrsServer.class
2854 02-22-2016 03:06 org/jboss/resteasy/plugins/server/tjws/PatchedHttpServletRequest.class
resteasy-spring-3.0.16.Final-redhat-1.jar | grep tjws
0 02-22-2016 03:09 org/jboss/resteasy/springmvc/tjws/
2034 02-22-2016 03:09 org/jboss/resteasy/springmvc/tjws/TJWSEmbeddedSpringMVCServer.class
1794 02-22-2016 03:09 org/jboss/resteasy/springmvc/tjws/TJWSSpringMVCDispatcher.class
2809 02-22-2016 03:09 org/jboss/resteasy/springmvc/tjws/TJWSEmbeddedSpringMVCServerBean.class
</pre>
</blockquote>
<pre wrap="">
And also the 'tjws' module itself.
</pre>
<blockquote type="cite">
<pre wrap="">
Do you know more about customer use-cases ?
</pre>
</blockquote>
<pre wrap="">
I recently fixed a tjws ssl use case requested by customer: <a class="moz-txt-link-freetext" href="https://github.com/resteasy/Resteasy/pull/761/files">https://github.com/resteasy/Resteasy/pull/761/files</a>
</pre>
<blockquote type="cite">
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">Yeah, I learned that only recently. I'm amazed. But it's true: "If it's
there, they'll use it."
</pre>
</blockquote>
<pre wrap="">
Agree, it's bad that we realized that so late :(
</pre>
<blockquote type="cite">
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">
We can try to remove TJWS for testing purposes in RESTEasy project itself.
But the RESTEasy TJWS module should be maintained as a feature.
</pre>
<blockquote type="cite">
<pre wrap=""> -- 19 from 38 jiras -
<a class="moz-txt-link-freetext" href="https://issues.jboss.org/issues/?jql=project%20%3D%20JBEAP%20AND%20issuetype%20%3D%20Bug%20AND%20resolution%20in%20%28Unresolved%2C%20Done%2C%20%22Out%20of%20Date%22%29%20AND%20component%20%3D%20REST">https://issues.jboss.org/issues/?jql=project%20%3D%20JBEAP%20AND%20issuetype%20%3D%20Bug%20AND%20resolution%20in%20%28Unresolved%2C%20Done%2C%20%22Out%20of%20Date%22%29%20AND%20component%20%3D%20REST</a>
- we will keep this TS for 7.0.z
- we would like to consume & prod-patch upstream (ARQ + WF based) TS for
the future releases
Upstream and QE specific TS should somehow converge into a single one.
</pre>
</blockquote>
<pre wrap="">+1
</pre>
<blockquote type="cite">
<pre wrap="">My feeling is that (upstream) TS should be a bit isolated from the rest to
make it easier for QE to test against products - like EAP.
Something similar what is in JBWS and maybe even beyond - no dependency on
parent to have deps clearly defined.
For JBWS we consume upstream ts, patch it little bit + use prod based
dependencies.
Cheers.
Rostislav
----- Original Message -----
</pre>
<blockquote type="cite">
<pre wrap="">Hey Alessio,
yes setting up mailing list or even better forums on developer.jboss.org
would be great.
for the changes I had in mind from top of my head
- restructure project to move it one folder up so we, get rid of "jaxrs"
folder, but that can be done later
- unify versions of jetty used for tests
- make project build on various platforms and be able to release new
version maven-release-plugin
- get rid of tjws
- get rid of book
<a class="moz-txt-link-freetext" href="https://github.com/resteasy/Resteasy/tree/master/jaxrs/examples/oreilly-jaxrs-2.0-workbook">https://github.com/resteasy/Resteasy/tree/master/jaxrs/examples/oreilly-jaxrs-2.0-workbook</a>
- probably best to move it to different repo
- think about examples, maybe move them to different repo or clean them
up
so build would work properly.
and lots of other ideas, but that would just be cleaning up the codebase
so
it would be easier to work from there.
But yes, lets talk about it next week, as I also have some stuff to
finish
this week.
--
tomaz
On Thu, Apr 28, 2016 at 9:38 PM, Alessio Soldano <a class="moz-txt-link-rfc2396E" href="mailto:asoldano@redhat.com"><asoldano@redhat.com></a>
wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi Rostislav, hi Tomaz,
thanks for the references. We'll have to go and parse the changes (and
also see what still applies and what would be out-of-date ;-) ).
Generally speaking, why not, let's listen to what "stage 0" tasks you
have
in mind. I'm very busy till the end of the week, but I hope to have time
to
spend on this next week. I'm still fixing few things with the team,
including having jboss mailing lists for the project.. if it makes sense
to
you, I would propose to have some discussion on the proposed tasks on a
dev
mailing list, ok?
Cheers
Alessio
Il 28/04/2016 18:10, Rostislav Svoboda ha scritto:
</pre>
<blockquote type="cite">
<pre wrap="">Hi Alessio.
Several months ago I spoke with Tomaz about RESTEasy and Tomaz's effort
with project cleanup + version sync. For example
<a class="moz-txt-link-freetext" href="https://github.com/resteasy/Resteasy/commit/1f95cefc716d88533551c282977aa9b0ba2a8f10">https://github.com/resteasy/Resteasy/commit/1f95cefc716d88533551c282977aa9b0ba2a8f10</a>
was merged, probably some more ideas are waiting for sunlight in
branches
like <a class="moz-txt-link-freetext" href="https://github.com/ctomc/Resteasy/tree/build-cleanup">https://github.com/ctomc/Resteasy/tree/build-cleanup</a>
I pinged Tomaz today because of that and we spoke a bit about RESTEasy,
Tomaz has some ideas for few "stage 0" tasks that should be done before
anything else is going on. He [CCed to confirm that ;)] is also wiling
to
take few days to work on it if we agree on them being merged.
So here we go, discussion can begin. Hope RESTEasy project structure
will
be in good condition soon!
Cheers.
Rostislav
</pre>
</blockquote>
<pre wrap="">--
Alessio Soldano
Web Service Lead, JBoss
</pre>
</blockquote>
</blockquote>
<pre wrap="">_______________________________________________
resteasy-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:resteasy-dev@lists.jboss.org">resteasy-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/resteasy-dev">https://lists.jboss.org/mailman/listinfo/resteasy-dev</a>
</pre>
</blockquote>
<pre wrap="">
_______________________________________________
resteasy-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:resteasy-dev@lists.jboss.org">resteasy-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/resteasy-dev">https://lists.jboss.org/mailman/listinfo/resteasy-dev</a>
</pre>
</blockquote>
<pre wrap="">
--
My company's smarter than your company (unless you work for Red Hat)
_______________________________________________
resteasy-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:resteasy-dev@lists.jboss.org">resteasy-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/resteasy-dev">https://lists.jboss.org/mailman/listinfo/resteasy-dev</a>
</pre>
</blockquote>
<pre wrap="">_______________________________________________
resteasy-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:resteasy-dev@lists.jboss.org">resteasy-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/resteasy-dev">https://lists.jboss.org/mailman/listinfo/resteasy-dev</a>
</pre>
</blockquote>
<pre wrap="">
_______________________________________________
resteasy-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:resteasy-dev@lists.jboss.org">resteasy-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/resteasy-dev">https://lists.jboss.org/mailman/listinfo/resteasy-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>