<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi Alessio, <br>
If you look at these examples, all the test scenarios are already
covered in resteasy testsuite . Let me give some examples : <br>
jaxrs-2.0.-workbook-ex03_1 demonstrated the usage of @Path, @GET,
PUT, POST, and @PathParam. Almost each resteasy test is using
some of these annotation or all above annotations.<br>
jaxrs-2.0.-workbook-ex04_1 is showing usage how to create your own
HTTP method annotation. This feature is already tested by
org.jboss.resteasy.test.client.SyncInvoketest<br>
jaxrs-2.0-workbook-ex09_1 demonstrates the client accept media
type to pick between XML and JSON. And this is already checked by
org.jboss.resteasy.test.resteasy1296.ValidationThroughRestIT. <br>
jaxrs-2.0-workbook-ex11-1 is showing the usage of CacheControl and
Request.evaluatePreconditions(). We can find this is already
verified by org.jboss.resteasy.test.client.cache.ClientCacheTest.
<br>
Each example's demonstration usage can be found in resteasy
testsuite and It is checking the duplicate things if we run this
in the build, so I don't think there is any issue will be
introduced if we move all examples dir to resteasy-examples repo
too.
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
<br>
Cheers,<br>
Jim <br>
<br>
<br>
On 06/29/2016 11:07 PM, Alessio Soldano wrote:<br>
</div>
<blockquote
cite="mid:3234bed0-b7e3-8425-cbc8-20dfe1925bbd@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Hi Jim,<br>
we previously discussed a bit about this topic. I believe we
should keep the oreilly-jaxrs-2.0-workbook examples there
because they cover basic jaxrs 2.0 scenarios. Having the
examples be automatically run in the build ensures no
regressions happen. We already have the resteasy-examples repo,
which we moved a bunch of examples to (and which needs to be
fixed, while the workbook ones just run fine ;) ).<br>
As for the other examples (war-tests) I agree on turning them
into plain integration tests.<br>
<br>
Regarding RESTEASY-1425, that can possibly be fixed by moving
the jetty-plugin to a profile that is only enabled if
-DskipTests=true is not specified.<br>
Cheers<br>
Alessio<br>
<br>
Il 29/06/2016 11:40, Jim Ma ha scritto:<br>
</div>
<blockquote cite="mid:5773977C.1000109@redhat.com" type="cite">
<pre wrap="">Hi all,
When I was looking at the build issue:
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://issues.jboss.org/browse/RESTEASY-1425">https://issues.jboss.org/browse/RESTEASY-1425</a>, I thought the examples
module should be moved to another repository (for example, name it to
resteasy-examples) to make resteasy build run faster. From travis build
log, remove these modules can save us about 3 mins build time. If there
is some important thing should be checked in these examples, we can
change to a test and add it in resteasy repo, not package war file ,
start/stop Jetty in resteasy build. Besides this, I think these examples
only need to run against resteasy release version. WDYT?
Cheers,
Jim
_______________________________________________
resteasy-dev mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:resteasy-dev@lists.jboss.org">resteasy-dev@lists.jboss.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/resteasy-dev">https://lists.jboss.org/mailman/listinfo/resteasy-dev</a>
</pre>
</blockquote>
<br>
<p><br>
</p>
<pre class="moz-signature" cols="72">--
Alessio Soldano
Web Service Lead, JBoss</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
resteasy-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:resteasy-dev@lists.jboss.org">resteasy-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/resteasy-dev">https://lists.jboss.org/mailman/listinfo/resteasy-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>