<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Hi John,</p>
<p>I haven't drilled into this yet, but it reminds me of something
which might be relevant. I remember working on an issue, the
details of which I forget but probably related to validation, in
which I was also seeing nondeterministic behavior. In particular,
sometimes I was seeing an object in the form of a Weld proxy, and
at other times the same object was showing up as an EJB proxy. I
don't remember the outcome of the issue, but I think I never found
an explanation for the behavior. Maybe something to do with timing
as the application was installed?</p>
<p>-Ron<br>
</p>
<br>
<div class="moz-cite-prefix">On 10/27/2017 03:03 AM, John O'Hara
wrote:<br>
</div>
<blockquote
cite="mid:CA+HD-p3rz75frCf9erQ3jKBNaQLt5j+bK3EQpC4h0BYPskDCFg@mail.gmail.com"
type="cite">
<div dir="ltr"><span
id="gmail-docs-internal-guid-6a371e78-5c9b-bfaf-8ff7-6739edd31b00">
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;vertical-align:baseline;white-space:pre-wrap">Thank you for your responses. If I fill you in on a bit of background about what I have experienced, then it might help clarify the issue I see. </span></p>
<br>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;background-color:transparent;font-weight:700;vertical-align:baseline;white-space:pre-wrap">Background</span></p>
<br>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">I am running a JEE benchmark on EAP7.1 (using resteasy 3.0.24.Final). One of rest endpoints has a @Valid annotation on a method parameter for a complex object. </span></p>
<br>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt;margin-left:4pt"><span style="font-size:11pt;font-family:Arial;color:rgb(128,128,0);background-color:transparent;vertical-align:baseline;white-space:pre-wrap">@POST</span></p>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt;margin-left:4pt"><span style="font-size:11pt;font-family:Arial;color:rgb(128,128,0);background-color:transparent;vertical-align:baseline;white-space:pre-wrap">@Path</span><span style="font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">(</span><span style="font-size:11pt;font-family:Arial;color:rgb(0,128,0);background-color:transparent;font-weight:700;vertical-align:baseline;white-space:pre-wrap">"/foo"</span><span style="font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">)</span></p>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt;margin-left:4pt"><span style="font-size:11pt;font-family:Arial;color:rgb(128,128,0);background-color:transparent;vertical-align:baseline;white-space:pre-wrap">@Consumes</span><span style="font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">(MediaType.</span><span style="font-size:11pt;font-family:Arial;color:rgb(102,14,122);background-color:transparent;font-weight:700;font-style:italic;vertical-align:baseline;white-space:pre-wrap">APPLICATION_JSON</span><span style="font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">)</span></p>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt;margin-left:4pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,128);background-color:transparent;font-weight:700;vertical-align:baseline;white-space:pre-wrap">public void </span><span style="font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">addFoo(</span><span style="font-size:11pt;font-family:Arial;color:rgb(128,128,0);background-color:transparent;vertical-align:baseline;white-space:pre-wrap">@Valid </span><span style="font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">Foo bar) </span><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,128);background-color:transparent;font-weight:700;vertical-align:baseline;white-space:pre-wrap">throws </span><span style="font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">Exception {</span></p>
<br>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">The Foo class contains different validation annotations, such as @NotNull, @Size, @Pattern and a custom validation annotation. </span></p>
<br>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">One test determines how WF/EAP handles invalid requests. </span><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline;white-space:pre-wrap">When I invoke the endpoint above I see a non-deterministic response from the app server. If I invoke the endpoint with an invalid json object I receive a HTTP 400 exception as expected, but if I invoke the endpoint with a valid object, and *then* invoke the endpoint </span><span style="font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">with an invalid object I receive a HTTP 500 error. </span></p>
<br>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">This exception only occurs on some property validation annotations and not all (e.g. @NotNull works as expected)</span></p>
<br>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">The test is being run in the context of CDI, and the HTTP 500 error is coming from the ejb3 subsystem. The ejb3 subsystem is wrapping the ConstraintValidationException raised by hibernate-validator.</span></p>
<br>
<br>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;background-color:transparent;font-weight:700;vertical-align:baseline;white-space:pre-wrap">Observations</span></p>
<br>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">In the call stack I capture [1], and WF thread dump [2] I can see;</span></p>
<br>
<ol style="margin-top:0pt;margin-bottom:0pt">
<li dir="ltr"
style="list-style-type:decimal;font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline">
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">The test is run in the context of CDI. The HTTP 500 response code message is caused by the ejb3 subsystem wrapping a ConstraintValidationException raised by hibernate-validator</span></p>
</li>
</ol>
<br>
<ol style="margin-top:0pt;margin-bottom:0pt" start="2">
<li dir="ltr"
style="list-style-type:decimal;font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline">
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">The validator is not called in ResourceMethodInvoker.invokeOnTarget() [3] as isValidatable is false [4], a ResteasyViolationException is not thrown</span></p>
</li>
</ol>
<br>
<ol style="margin-top:0pt;margin-bottom:0pt" start="3">
<li dir="ltr"
style="list-style-type:decimal;font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline">
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">The request is validated again here [5], the validation exceptions are not acted upon in this method call and the reflected method (which happens to be the Foo class constructor) is called here [6]</span></p>
</li>
</ol>
<br>
<br>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;background-color:transparent;font-weight:700;vertical-align:baseline;white-space:pre-wrap">Questions</span></p>
<br>
<ol style="margin-top:0pt;margin-bottom:0pt">
<li dir="ltr"
style="list-style-type:decimal;font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline">
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">Why is ResourceMethodInvoker.isValidatable false in WF/EAP?</span></p>
</li>
<li dir="ltr"
style="list-style-type:decimal;font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline">
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">If isValidatable is false, and validation occurs again at MethodInjectorImpl.invoke() can we not check for validation errors and raise the correct exception there as well?</span></p>
</li>
</ol>
<br>
<br>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">I have a standalone test that I will clean up and push out. There are some aspects of the test that can not be published publicly, so I need to modify them first.</span></p>
<br>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">Thanks,</span></p>
<br>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">John</span></p>
<br>
<br>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">[1] - see failing_4.stack </span></p>
<p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">[2] - see WF_stackTrace.out</span></p>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">[3] - </span><a
moz-do-not-send="true"
href="https://github.com/resteasy/Resteasy/blob/master/resteasy-jaxrs/src/main/java/org/jboss/resteasy/core/ResourceMethodInvoker.java#L305"
style="text-decoration-line:none"><span style="font-size:11pt;font-family:Arial;background-color:transparent;text-decoration-line:underline;vertical-align:baseline;white-space:pre-wrap">https://github.com/resteasy/Resteasy/blob/master/resteasy-jaxrs/src/main/java/org/jboss/resteasy/core/ResourceMethodInvoker.java#L305</span></a></p>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline;white-space:pre-wrap">[4] - </span><a
moz-do-not-send="true"
href="https://github.com/resteasy/Resteasy/blob/master/providers/resteasy-validator-provider-11/src/main/java/org/jboss/resteasy/plugins/validation/GeneralValidatorImpl.java#L223"
style="text-decoration-line:none"><span style="font-size:11pt;font-family:Arial;background-color:transparent;text-decoration-line:underline;vertical-align:baseline;white-space:pre-wrap">https://github.com/resteasy/Resteasy/blob/master/providers/resteasy-validator-provider-11/src/main/java/org/jboss/resteasy/plugins/validation/GeneralValidatorImpl.java#L223</span></a></p>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline;white-space:pre-wrap">[5] - </span><a
moz-do-not-send="true"
href="https://github.com/resteasy/Resteasy/blob/master/resteasy-jaxrs/src/main/java/org/jboss/resteasy/core/MethodInjectorImpl.java#L119"
style="text-decoration-line:none"><span style="font-size:11pt;font-family:Arial;background-color:transparent;text-decoration-line:underline;vertical-align:baseline;white-space:pre-wrap">https://github.com/resteasy/Resteasy/blob/master/resteasy-jaxrs/src/main/java/org/jboss/resteasy/core/MethodInjectorImpl.java#L119</span></a></p>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline;white-space:pre-wrap">[6] - </span><span style="text-decoration-line:underline;font-size:11pt;font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap"><a moz-do-not-send="true" href="https://github.com/resteasy/Resteasy/blob/master/resteasy-jaxrs/src/main/java/org/jboss/resteasy/core/MethodInjectorImpl.java#L140" style="text-decoration-line:none">https://github.com/resteasy/Resteasy/blob/master/resteasy-jaxrs/src/main/java/org/jboss/resteasy/core/MethodInjectorImpl.java#L140</a></span></p>
<div><br>
</div>
</span>
<div class="gmail_extra">
<div
class="gmail-m_3837250096923988484gmail-m_-5821345287519690629gmail_signature">
<div dir="ltr">
<div
style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px"><br>
</div>
</div>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
resteasy-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:resteasy-dev@lists.jboss.org">resteasy-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/resteasy-dev">https://lists.jboss.org/mailman/listinfo/resteasy-dev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
My company's smarter than your company (unless you work for Red Hat)</pre>
</body>
</html>