[rhmessaging-commits] rhmessaging commits: r1046 - in mgmt: notes and 1 other directory.

rhmessaging-commits at lists.jboss.org rhmessaging-commits at lists.jboss.org
Sat Oct 13 14:56:00 EDT 2007


Author: justi9
Date: 2007-10-13 14:56:00 -0400 (Sat, 13 Oct 2007)
New Revision: 1046

Modified:
   mgmt/cumin/python/wooly/__init__.py
   mgmt/notes/Todo
Log:
Checks that placeholders that match widget methods are actually
callable.



Modified: mgmt/cumin/python/wooly/__init__.py
===================================================================
--- mgmt/cumin/python/wooly/__init__.py	2007-10-13 18:49:14 UTC (rev 1045)
+++ mgmt/cumin/python/wooly/__init__.py	2007-10-13 18:56:00 UTC (rev 1046)
@@ -671,12 +671,11 @@
 
         return fragments
 
-    # XXX Ought to make sure what we're returning is a method.
     def find_method(self, name):
         for cls in self.widget.__class__.__mro__:
             method = getattr(cls, name, None)
 
-            if method:
+            if method and callable(method):
                 return method
 
     def render(self, session, object, writer):

Modified: mgmt/notes/Todo
===================================================================
--- mgmt/notes/Todo	2007-10-13 18:49:14 UTC (rev 1045)
+++ mgmt/notes/Todo	2007-10-13 18:56:00 UTC (rev 1046)
@@ -69,3 +69,5 @@
  * Remove log messages from host template view
 
  * Consider having a cssclass set on widgets
+
+ * Use page attributes for session errors, redirect
\ No newline at end of file




More information about the rhmessaging-commits mailing list