[rhmessaging-commits] rhmessaging commits: r1802 - in mgmt: cumin/python/wooly and 2 other directories.

[rhmessaging-commits at lists.jboss.org]

Author: justi9
Date: 2008-03-27 10:48:15 -0400 (Thu, 27 Mar 2008)
New Revision: 1802

Modified:
   mgmt/cumin/python/cumin/broker.py
   mgmt/cumin/python/cumin/exchange.py
   mgmt/cumin/python/cumin/widgets.py
   mgmt/cumin/python/wooly/__init__.py
   mgmt/cumin/python/wooly/forms.py
   mgmt/cumin/python/wooly/parameters.py
   mgmt/misc/boneyard.py
   mgmt/notes/justin-todo.txt
Log:
Eliminate set_default.



Modified: mgmt/cumin/python/cumin/broker.py
===================================================================
--- mgmt/cumin/python/cumin/broker.py	2008-03-27 12:28:06 UTC (rev 1801)
+++ mgmt/cumin/python/cumin/broker.py	2008-03-27 14:48:15 UTC (rev 1802)
@@ -472,7 +472,7 @@
         self.add_attribute(self.addr_errors)
 
         self.group_param = BrokerGroupParameter(app, "group_param")
-        self.group_param.set_default(None)
+        self.group_param.default = None
         self.add_parameter(self.group_param)
         self.add_form_parameter(self.group_param)
 
@@ -481,7 +481,7 @@
         self.add_form_parameter(self.groups)
 
         self.fields = IntegerParameter(app, "fields")
-        self.fields.set_default(3)
+        self.fields.default = 3
         self.add_parameter(self.fields)
 
         self.field_tmpl = Template(self, "field_html")

Modified: mgmt/cumin/python/cumin/exchange.py
===================================================================
--- mgmt/cumin/python/cumin/exchange.py	2008-03-27 12:28:06 UTC (rev 1801)
+++ mgmt/cumin/python/cumin/exchange.py	2008-03-27 14:48:15 UTC (rev 1802)
@@ -265,7 +265,7 @@
         self.add_child(self.exchange_name)
 
         self.type = Parameter(app, "type")
-        self.type.set_default("direct")
+        self.type.default = "direct"
         self.add_parameter(self.type)
 
         self.direct = RadioInput(app, "direct", self)

Modified: mgmt/cumin/python/cumin/widgets.py
===================================================================
--- mgmt/cumin/python/cumin/widgets.py	2008-03-27 12:28:06 UTC (rev 1801)
+++ mgmt/cumin/python/cumin/widgets.py	2008-03-27 14:48:15 UTC (rev 1802)
@@ -248,7 +248,7 @@
         self.titles[state] = title
 
         if self.param.default is None:
-            self.param.set_default(state)
+            self.param.default = state
 
     def get(self, session):
         return self.param.get(session)

Modified: mgmt/cumin/python/wooly/__init__.py
===================================================================
--- mgmt/cumin/python/wooly/__init__.py	2008-03-27 12:28:06 UTC (rev 1801)
+++ mgmt/cumin/python/wooly/__init__.py	2008-03-27 14:48:15 UTC (rev 1802)
@@ -25,9 +25,6 @@
         else:
             self.path = self.name
 
-    def set_required(self, required):
-        self.required = required
-
     def validate(self, session):
         value = self.get(session)
         
@@ -55,9 +52,6 @@
     def get_default(self, session):
         return self.default
 
-    def set_default(self, default):
-        self.default = default
-
     def __repr__(self):
         return "%s('%s')" % (self.__class__.__name__, self.path)
 

Modified: mgmt/cumin/python/wooly/forms.py
===================================================================
--- mgmt/cumin/python/wooly/forms.py	2008-03-27 12:28:06 UTC (rev 1801)
+++ mgmt/cumin/python/wooly/forms.py	2008-03-27 14:48:15 UTC (rev 1802)
@@ -73,9 +73,6 @@
     def get_default(self, session):
         return self.param.get_default(session)
 
-    def set_default(self, default):
-        return self.param.set_default(default)
-
     def set_tab_index(self, tab_index):
         self.tab_index = tab_index
 

Modified: mgmt/cumin/python/wooly/parameters.py
===================================================================
--- mgmt/cumin/python/wooly/parameters.py	2008-03-27 12:28:06 UTC (rev 1801)
+++ mgmt/cumin/python/wooly/parameters.py	2008-03-27 14:48:15 UTC (rev 1802)
@@ -36,7 +36,7 @@
     def __init__(self, model, name):
         Parameter.__init__(self, model, name)
 
-        self.set_default(False)
+        self.default = False
 
     def do_unmarshal(self, string):
         return string == "t"
@@ -45,9 +45,6 @@
         return object and "t" or "f"
 
 class VoidBooleanParameter(Parameter):
-    def set_default(self, default):
-        raise Exception("Unsupported operation")
-
     def get(self, session):
         return self.path in session.values
 

Modified: mgmt/misc/boneyard.py
===================================================================
--- mgmt/misc/boneyard.py	2008-03-27 12:28:06 UTC (rev 1801)
+++ mgmt/misc/boneyard.py	2008-03-27 14:48:15 UTC (rev 1802)
@@ -150,7 +150,7 @@
         self.add_parameter(self.param)
 
         self.source = Parameter(app, "source")
-        self.source.set_default("local")
+        self.source.default = "local"
         self.add_parameter(self.source)
 
         self.profile = RadioInput(app, "profile", self)

Modified: mgmt/notes/justin-todo.txt
===================================================================
--- mgmt/notes/justin-todo.txt	2008-03-27 12:28:06 UTC (rev 1801)
+++ mgmt/notes/justin-todo.txt	2008-03-27 14:48:15 UTC (rev 1802)
@@ -1,7 +1,5 @@
 Current
 
- * Resolve design questions around view navigation
-
  * Tables: Make null values in tables dashes, not zeroes
 
  * Get rid of single object confirms
@@ -16,8 +14,12 @@
 
  * Fix the status box updates, to avoid the "/sec" display
 
+ * Fix obnoxious HTML resizing bug
+
 Deferred
 
+ * Resolve design questions around view navigation
+
  * Blow up if we try to call set_redirect_url twice in a session
 
  * Need to add cherrypy bsd license to binary dist?
@@ -56,11 +58,6 @@
 
  * Avoid dirtying js namespace with updateFoo methods
 
- * Add a widget for the html client side of chart images
-
- * Directly set attr.default for static defaults; eliminate
-   attr.set_default
-
  * So that list params can embed an item param, find a way to avoid
    the need to attach params to widgets in every instance