[rhmessaging-commits] rhmessaging commits: r4283 - mgmt/newdata/cumin/python/cumin.

[rhmessaging-commits at lists.jboss.org]

Author: eallen
Date: 2010-09-14 09:50:43 -0400 (Tue, 14 Sep 2010)
New Revision: 4283

Modified:
   mgmt/newdata/cumin/python/cumin/main.py
Log:
Fixed BZ 633455: Don't display top submissions records if they don't have a valid jobServerRef_id

Modified: mgmt/newdata/cumin/python/cumin/main.py
===================================================================
--- mgmt/newdata/cumin/python/cumin/main.py	2010-09-14 13:18:00 UTC (rev 4282)
+++ mgmt/newdata/cumin/python/cumin/main.py	2010-09-14 13:50:43 UTC (rev 4283)
@@ -381,10 +381,25 @@
         self.adapter.query.add_filter(filter)
 
         filter = SqlComparisonFilter(table._qmf_update_time,
-                                     "now() - interval '600000 seconds'", ">=")
+                                     "now() - interval '60 seconds'", ">=")
         self.adapter.query.add_filter(filter)
 
+    def render_rows(self, session):
+        data = self.data.get(session)
+
+        writer = Writer()
+
+        for record in data:
+            # if we can't get the collector, don't render the row
+            submission_id = record[0]
+            collector = self.get_collector(session, submission_id)
+            if collector:
+                writer.write(self.row.render(session, record))
+
+        return writer.to_string()
+
     def get_collector(self, session, submission_id):
+        try:
             cls = self.cls
             submission = cls.get_object_by_id(session.cursor, submission_id)
 
@@ -393,6 +408,8 @@
 
             cls = self.app.model.com_redhat_grid.Collector
             return cls.get_object(session.cursor, Pool=job_server.Pool)
+        except Exception, e:
+            log.exception(e)
 
     class NameColumn(ObjectLinkColumn):
         def render_cell_href(self, session, record):