[richfaces-issues] [JBoss JIRA] (RF-13082) Change the orderingList component to use the new orderingList widget
Brian Leathem (JIRA)
jira-events at lists.jboss.org
Tue Sep 24 19:08:45 EDT 2013
[ https://issues.jboss.org/browse/RF-13082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12807041#comment-12807041 ]
Brian Leathem commented on RF-13082:
------------------------------------
On further experimentation, I believe it would be a good idea to keep the height/width attributes. Because the pickList uses the Bootstrap grid mechanism to provide a responsive widget, one cannot simply set the height of the parent container and expect the nested divs to fit in that height. While achievable in the "desktop" or wide-screen layout, the floating columns quickly spill out of the height constrained parent when the widget is displayed in "mobile" or narrow-screen layout.
Instead of setting the height style at the top-level of the component, one has to instead style several internal classes of the widgets (very much an implementation detail). This has been abstracted out using LESS, but I believe that the use case of tailoring the height of an ordering/pick list warrants a more straightforward approach then rebuilding an applications skin everytime the height of an ordering/pick list needs to be adjusted.
I will proceed with keeping the height/width attributes for the initial implementation. Th topic of their inclusion can be further discussed as we see how other responsive widgets/components unfold.
{panel:title=TL/DR}
We should consider only removing component style-related attributes that are replaceable by using the _style_ attribute of the component.
(Note: this does not apply to removing the multitude of redundant *Class attributes).
{panel}
> Change the orderingList component to use the new orderingList widget
> --------------------------------------------------------------------
>
> Key: RF-13082
> URL: https://issues.jboss.org/browse/RF-13082
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: component-selects
> Reporter: Brian Leathem
> Assignee: Brian Leathem
> Fix For: 5.0.0.Alpha2
>
> Original Estimate: 1 day
> Remaining Estimate: 1 day
>
> Attributes to be dropped in the RF5 implementation:
> * disabledClass
> * headerClass
> * itemClass
> * selectItemClass
> * listHeight
> * listWidth
> * listMaxHeight
> * listMaxWidth
> It is felt that the *Class attributes are redundant. Custom component styling can be achieved with the combination of the CSS class specified by the _styleClass_ attribute, along with the relevant stateful CSS class (_disabled_, _header_, _ui-selectee_, ui-selected_).
> Similarly the height/width CSS attributes are better set with CSS styles, rather than via facelet attributes.
> Additionally, we should consider dropping the onlist* event handlers, as there is considerable overlap with their on* counterparts. For instance, are there really use cases that require differentiating between onmouveover and onlistmouseover?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the richfaces-issues
mailing list