[richfaces-issues] [JBoss JIRA] (RF-13278) Add support for a 'header' meta-component to the rich:tabPanel
Brian Leathem (JIRA)
issues at jboss.org
Thu Jan 2 21:31:33 EST 2014
[ https://issues.jboss.org/browse/RF-13278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933424#comment-12933424 ]
Brian Leathem edited comment on RF-13278 at 1/2/14 9:30 PM:
------------------------------------------------------------
Thanks for the review Lukas. Your commit is sensible.
Having thought about this issue over the break, and speaking about it with @lfryc today I've come to the following conclusions:
# The tabPanel headers should be visited in the walk of the component tree, because they are visible on the page (RF-13455)
# Having a tabPanel at header\{s} meta-component would still be useful (despite 1)
# The @active item should be the default value of the tabPanel, but should be overridden when a user sets the render attribute of the tabPanel (RF-13456)
We will address 1) in 4.3, however 2) and 3) will be included in 4.5/5.0.
was (Author: bleathem):
Thanks for the review Lukas. Your commit is sensible.
Having thought about this issue over the break, and speaking about it with @lfryc today I've come to the following conclusions:
# The tabPanel headers should be visited in the walk of the component tree, because they are visible on the page (RF-13455)
# Having a tabPanel at header\{s} meta-component would still be useful (despite 1)
# The @active item should be the default value of the tabPanel, but should be overridden when a user sets the render attribute of the tabPanel
We will address 1) in 4.3, however 2) and 3) will be included in 4.5/5.0.
> Add support for a 'header' meta-component to the rich:tabPanel
> --------------------------------------------------------------
>
> Key: RF-13278
> URL: https://issues.jboss.org/browse/RF-13278
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: component-panels-layout-themes
> Affects Versions: 4.3.4
> Environment: java 7,
> tomcat 7, JBoss AS,
> mojarra, myfaces
> chrome, firefox
> Reporter: Alexey Shakov
> Assignee: Brian Leathem
> Fix For: 5.0.0.Alpha3
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> I use ajax to update the header label of rich:tab. That is why label is placed in a header-facet. Since RF 4.3.4 this does not work:
> {code:xml}
> <?xml version="1.0" encoding="UTF-8"?>
> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
> "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> <html xmlns="http://www.w3.org/1999/xhtml" xmlns:ui="http://java.sun.com/jsf/facelets" xmlns:h="http://java.sun.com/jsf/html"
> xmlns:c="http://java.sun.com/jsp/jstl/core" xmlns:rich="http://richfaces.org/rich" xmlns:a4j="http://richfaces.org/a4j"
> xmlns:f="http://java.sun.com/jsf/core" xml:lang="en" lang="en">
> <h:head>
> </h:head>
> <h:body>
>
> <a4j:log hotkey="M" mode="popup" />
> <h:form id="form" prependId="false">
> <rich:tabPanel id="tabPanel">
> <rich:tab header="tab 1">
> <a4j:commandLink value="click me" action="#{testBean.put('clicks',testBean.clicks + 1)}" render="label" execute="@this" />
> </rich:tab>
> <rich:tab>
> <f:facet name="header">
> <h:outputText id="label" value="#{testBean.clicks} clicks" />
> </f:facet>
> </rich:tab>
> </rich:tabPanel>
> </h:form>
> </h:body>
> </html>
> {code}
> testBean is a simple session-scoped HashMap.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the richfaces-issues
mailing list