[richfaces-svn-commits] JBoss Rich Faces SVN: r14537 - branches/community/3.3.X/framework/impl/src/main/java/org/ajax4jsf/webapp.

[richfaces-svn-commits at lists.jboss.org]

Author: nbelaevski
Date: 2009-06-05 10:21:24 -0400 (Fri, 05 Jun 2009)
New Revision: 14537

Modified:
   branches/community/3.3.X/framework/impl/src/main/java/org/ajax4jsf/webapp/BaseFilter.java
Log:
BaseFilter: added MyFaces Extension filter misconfiguration diagnostic

Modified: branches/community/3.3.X/framework/impl/src/main/java/org/ajax4jsf/webapp/BaseFilter.java
===================================================================
--- branches/community/3.3.X/framework/impl/src/main/java/org/ajax4jsf/webapp/BaseFilter.java	2009-06-05 13:18:55 UTC (rev 14536)
+++ branches/community/3.3.X/framework/impl/src/main/java/org/ajax4jsf/webapp/BaseFilter.java	2009-06-05 14:21:24 UTC (rev 14537)
@@ -301,6 +301,26 @@
 	
 	}
 	
+	private static final String MYFACES_FILTER_CHECKED = BaseFilter.class.getName() + ":MyFacesFilterChecked";
+    
+	private static final String MYFACES_DOFILTER_CALLED = "org.apache.myfaces.component.html.util.ExtensionFilter.doFilterCalled"; 
+    
+	private boolean myfacesMessagePrinted = false;
+	
+	private void checkMyFacesExtensionsFilter(HttpServletRequest request) {
+		if (request.getAttribute(MYFACES_FILTER_CHECKED) == null) {
+			if (request.getAttribute(MYFACES_DOFILTER_CALLED) != null) {
+				if (!this.myfacesMessagePrinted) {
+					log.warn("MyFaces Extensions Filter should be configured to execute *AFTER* RichFaces filter. Refer to SRV.6.2.4 section of Servlets specification on how to achieve that.");
+					
+					this.myfacesMessagePrinted = true;
+				}
+			}
+			
+			request.setAttribute(MYFACES_FILTER_CHECKED, Boolean.TRUE);
+		}
+	}
+	
 	/**
 	 * Method catches upload files request. Request parameter
 	 * <b>org.ajax4jsf.Filter.UPLOAD_FILES_ID</b> indicates if request
@@ -491,7 +511,7 @@
 					// first stage - detect/set encoding of request. Same as in
 					// Myfaces External Context.
 					setupRequestEncoding(httpServletRequest);
-					
+					checkMyFacesExtensionsFilter(httpServletRequest);
 					processUploadsAndHandleRequest(httpServletRequest, httpServletResponse, chain);
 				}
 			} finally {