<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<TITLE>Message</TITLE>
<META content="MSHTML 6.00.2800.1561" name=GENERATOR></HEAD>
<BODY text=#000000 bgColor=#ffffff>
<DIV><FONT face=Garamond color=#0000ff size=4><SPAN
class=848514707-06042007>Mark:</SPAN></FONT></DIV>
<DIV> </DIV>
<DIV><SPAN class=848514707-06042007>></SPAN>I commented out the bad code, so
I can continue with getting testing to work. The test target is now getting
executed but I get the following error:<BR><SPAN
class=848514707-06042007>></SPAN>eclipse-test:<BR><SPAN
class=848514707-06042007>></SPAN> [echo] Running
org.drools.eclipse.AllTests<BR> <SPAN
class=848514707-06042007>></SPAN> [java] Class not found "A
fragment bundle cannot load classes: org.drools.eclipse.AllTests"<BR> <SPAN
class=848514707-06042007>></SPAN> [java] Java Result:
2</DIV>
<DIV><FONT face=Garamond color=#0000ff size=4><SPAN class=848514707-06042007>The
code from Alex blewitt is wrong,.</SPAN></FONT></DIV>
<DIV><FONT face=Garamond color=#0000ff size=4><SPAN class=848514707-06042007>I
fixed it: see rev 10798.</SPAN></FONT></DIV>
<DIV><FONT face=Garamond color=#0000ff size=4><SPAN class=848514707-06042007>A
fragment does NOT have a class laoder.</SPAN></FONT></DIV>
<DIV><FONT face=Garamond color=#0000ff size=4><SPAN
class=848514707-06042007><FONT size=4>
<P align=left></FONT><FONT color=#3f7f5f size=4>//PO: this is wrong. we need to
use the PLUGIN_ID of the host, not that of the </P></FONT><FONT size=4>
<P align=left></FONT><FONT color=#3f7f5f size=4>// fragment</P>
<P align=left>// public static final String PLUGIN_NAME =
AllTests.class.getPackage()</P>
<P align=left>// .getName();</P></FONT><FONT size=4>
<P></FONT><B><FONT color=#7f0055 size=4>public</B></FONT><FONT size=4>
</FONT><B><FONT color=#7f0055 size=4>static</B></FONT><FONT size=4>
</FONT><B><FONT color=#7f0055 size=4>final</B></FONT><FONT size=4> String
</FONT><I><FONT color=#0000c0 size=4>PLUGIN_NAME</I></FONT><FONT size=4> =
</FONT><FONT color=#2a00ff size=4>"org.drools.eclipse"</FONT><FONT
size=4>;</P></FONT></SPAN></FONT></DIV>
<DIV><FONT face=Garamond color=#0000ff size=4></FONT> </DIV>
<DIV><FONT face=Garamond color=#0000ff size=4></FONT> </DIV>
<DIV><SPAN class=848514707-06042007><FONT face=Garamond color=#0000ff size=4>for
the jars stuffs, you may not want to use the flag crteate update jar in the
build.properties.</FONT></SPAN></DIV>
<DIV><SPAN class=848514707-06042007><FONT face=Garamond color=#0000ff size=4>Or
else it crteate update style jars for each plugin/feature.</FONT></SPAN></DIV><!-- Converted from text/plain format --><BR>
<P><FONT size=2>--<BR>Cheers<BR>Philippe<BR><BR>philippe ombredanne | 1 650 799
0949 | pombredanne at nexb.com<BR>nexB - Open by Design (tm) - <A
href="http://www.nexb.com/">http://www.nexb.com</A><BR><BR><BR></FONT></P>
<BLOCKQUOTE
style="PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: #0000ff 2px solid; MARGIN-RIGHT: 0px">
<DIV></DIV>
<DIV class=OutlookMessageHeader lang=en-us dir=ltr align=left><FONT
face=Tahoma size=2>-----Original Message-----<BR><B>From:</B> Mark Proctor
[mailto:mproctor@codehaus.org] <BR><B>Sent:</B> Thursday, April 05, 2007 11:18
PM<BR><B>To:</B> Rules Dev List<BR><B>Cc:</B> Kris Verlaenen; Philippe
Ombredanne<BR><B>Subject:</B> Re: [rules-dev]
drools-eclipse<BR><BR></FONT></DIV><BR><BR>Also the testing environment
expects the plugins and features to be packages as directories inside the
zips, but for deployment we really want a jars inside a zjp. Any way to have
the test plugin/feature use directories and the main plugin/feature use a jar?
Or is the only way to unzip the jars to folders and delete the
jars?<BR><BR>Mark<BR>Mark Proctor wrote:
<BLOCKQUOTE cite=mid:4615BD98.7010906@codehaus.org type="cite">I have two
unit tests failing to compiler still:<BR>DRLCompletionProcessTest is failing
becuase "DefaultCompletionProcessor.filterProposalsOnPrefix" is not a static
method call. Which is confirmed here <A class=moz-txt-link-freetext
href="http://anonsvn.labs.jboss.com/labs/jbossrules/trunk/drools-eclipse/drools-eclipse-plugin/src/main/java/org/drools/eclipse/editors/completion/AbstractCompletionProcessor.java"
moz-do-not-send="true">http://anonsvn.labs.jboss.com/labs/jbossrules/trunk/drools-eclipse/drools-eclipse-plugin/src/main/java/org/drools/eclipse/editors/completion/AbstractCompletionProcessor.java</A><BR><BR>RuleContentOutlinePage
is failing because page.populatePackageTreeNode( source ) does not expect a
parameter. Which is confirmed here <A class=moz-txt-link-freetext
href="http://anonsvn.labs.jboss.com/labs/jbossrules/trunk/drools-eclipse/drools-eclipse-plugin/src/main/java/org/drools/eclipse/editors/outline/RuleContentOutlinePage.java"
moz-do-not-send="true">http://anonsvn.labs.jboss.com/labs/jbossrules/trunk/drools-eclipse/drools-eclipse-plugin/src/main/java/org/drools/eclipse/editors/outline/RuleContentOutlinePage.java</A><BR><BR>When
doing "run as junit" inside eclipse the ZoomControlTests fail, "worspace
closed".<BR><BR>LocationDeterminatorTest has a failure for
"testCheckLocationDetermination" "expected <2> but was:
<1><BR><BR>Mark<BR>Kris Verlaenen wrote:
<BLOCKQUOTE
cite=mid:a429603e0704051822p352fdf09ke542318045803733@mail.gmail.com
type="cite">
<DIV>I have now fixed most tests, at least they seem to be running here
locally.</DIV>
<DIV>Note that one of the tests (ZoomControlTest) is actually a plugin
test, not sure if you can run those within the automatic build, as they
need the eclipse IDE to startup when testing (not sure, maybe maven has
support for eclipse plugin unit tests?). Not sure how important that
test is (I commented out some lines to get it working, I'll fix that
later). <BR><BR>Let me know if you need more help in getting the build for
the eclipse-plugin integrated in the overall build.</DIV>
<DIV> </DIV>
<DIV>Kris</DIV>
<DIV> </DIV>
<DIV><SPAN class=gmail_quote>On 4/5/07, <B class=gmail_sendername>Kris
Verlaenen</B> <<A href="mailto:kris.verlaenen@gmail.com"
moz-do-not-send="true">kris.verlaenen@gmail.com</A>> wrote:</SPAN>
<BLOCKQUOTE class=gmail_quote
style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: rgb(204,204,204) 1px solid">
<DIV>I will try to fix all tests for the eclipse-plugin as soon as
possible (hope I can get them working tonight).</DIV>
<DIV>So that includes uncommenting tests again, making sure they compile
and making sure they are executed succesfully.</DIV><SPAN class=sg>
<DIV> </DIV>
<DIV>Kris<BR> </DIV></SPAN>
<DIV><SPAN class=e id=q_111c3b066d9f693f_2>
<DIV><SPAN class=gmail_quote>On 4/4/07, <B class=gmail_sendername>Mark
Proctor</B> <<A
onclick="return top.js.OpenExtLink(window,event,this)"
href="mailto:mproctor@codehaus.org" target=_blank
moz-do-not-send="true">mproctor@codehaus.org </A>> wrote:</SPAN>
<BLOCKQUOTE class=gmail_quote
style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: rgb(204,204,204) 1px solid">Also
not only are many tests commented out, but most tests fail,
would<BR>be good if we can sort this out. <BR><BR>Mark<BR>Mark Proctor
wrote:<BR>> Just a reminder that I have refactored the eclipse
stuff and there are<BR>> now four directories.under drools-eclipse,
drools-ide no long exists.<BR>> drools-eclipse-plugin <BR>>
drools-eclipse-feature<BR>> drools-eclipse-test<BR>>
drools-eclipse-test-feature<BR>><BR>> We are gradually fully
automating and customising maven so the top<BR>> level build.xml
will be killed off. soon, and most likely no longer <BR>> works.
However ant is still used to build the documentation and the<BR>>
eclipse plugin, it is just integrated into the mavne lifecycle
using<BR>> the antrun plugin.<BR>><BR>> We will continue
include the engine, eclipse and brms in the same <BR>> build system
for now as the project is quite fluid and we need close<BR>>
co-operation. In the future, when the engine api and language
features<BR>> mature, we may look at seperating brms and eclipse,
or atleast the <BR>> brms, so that they baseline with a specific
version of the engine<BR>> release, this will allow projects to do
releases on their own.<BR>><BR>> I have automed the eclipse
plugin build, although still trying to get <BR>> the unit tests
automated, and that is now part of the maven life<BR>> cycle. Edson
is currently investigating having the various ant and<BR>> manfiest
files having their information populated from maven - i.e .<BR>>
dependencies and version info.<BR>><BR>> drools-eclipse is now
activated as a profile, using the eclipse.home<BR>> settings, this
is part of the automation process and the libs will not<BR>> be
copied across unless you do this. <BR>> mvn -Dmaven.test.skip
-Declipse.home=c:\java\eclipse install<BR>><BR>> The following
classes have commented out tests, can I ask who ever is<BR>>
responsible for them to sort this out. I want to get the eclipse
<BR>> automation and testing ship shape, which will make things
easier for<BR>> the future.<BR>> IncompleteParsingTest<BR>>
ReteooLayoutFactoryTest<BR>> RuleContentOutlineTest<BR>><BR>>
Mark<BR>> _______________________________________________ <BR>>
rules-dev mailing list<BR>> <A
onclick="return top.js.OpenExtLink(window,event,this)"
href="mailto:rules-dev@lists.jboss.org" target=_blank
moz-do-not-send="true">rules-dev@lists.jboss.org</A><BR>> <A
onclick="return top.js.OpenExtLink(window,event,this)"
href="https://lists.jboss.org/mailman/listinfo/rules-dev"
target=_blank
moz-do-not-send="true">https://lists.jboss.org/mailman/listinfo/rules-dev
</A><BR>><BR><BR></BLOCKQUOTE></DIV><BR></SPAN></DIV></BLOCKQUOTE></DIV><BR></BLOCKQUOTE><BR><PRE wrap=""><HR width="90%" SIZE=4>
_______________________________________________
rules-dev mailing list
<A class=moz-txt-link-abbreviated href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</A>
<A class=moz-txt-link-freetext href="https://lists.jboss.org/mailman/listinfo/rules-dev">https://lists.jboss.org/mailman/listinfo/rules-dev</A>
</PRE></BLOCKQUOTE><BR></BLOCKQUOTE></BODY></HTML>