<div dir="ltr"><br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div dir="ltr">Hi Toni,<br><br> I checked out the drools-verifier code. For a little acclimatization I went through a few files. Looks like Verifier.java is the main<br>
class for verifier tool. I went on to check how the Consequences are being handled but could only find the interface Consequence.java and <br>
TextConsequence.java which doesn't do too much. <br>It would be helpful to have some higher level description of the relevant class relationships. (who's who).<br>Also, it may be helpful to know how to build this code and how to run it. I checked out the code from the url: <br>
<a href="http://anonsvn.labs.jboss.com/labs/jbossrules/trunk/drools-verifier/" target="_blank">http://anonsvn.labs.jboss.com/labs/jbossrules/trunk/drools-verifier/</a> but could not get any build script or instructions.<br>
<br>I hope I am going in the right direction.<br>
<br>Siddharth<div><div></div><div class="Wj3C7c"><br><br><br><br> <br><br><br><div class="gmail_quote">On Mon, Oct 6, 2008 at 6:56 PM, Toni Rikkola <span dir="ltr"><<a href="mailto:trikkola@redhat.com" target="_blank">trikkola@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi Siddharth<br>
<br>
Your work sounds interesting and I would like to hear more about it. Looks like your version is smarter with dependencies.<br>
<br>
The report data is used in Guvnor and in the HTML-report, but it can also be retrieved as XML or java objects.<br>
<br>
The HTML-report lists all the fields, rules and object types. So you can see what rules use certain object type and the field view shows what values are compared against the field. This dependency data is also used in the verification rules when searching for issues from the rule base.<br>
<br>
Like Mark said, the verifier is still quite blind for the RHS. Right now it just handles it as a string. So it can't really tell what objects were modified and how. This information is important to solve what rule creates or modifies facts to satisfy another rule. This dependency data can then again be used to find subsumption, loops ect.<br>
<br>
I hope that we can discuss about this soon.<br>
<br>
Toni<br>
<br>
Mark Proctor wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div>
Siddharth Angrish wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi Mark<br>
<br>
I went through the RuleAnalytics Module document. It looks like there is a good compatibility between your visions of Rule Analysis and our rule dependency generation work. I'll be excited to further develop and integrate my work with drools-verifier module code.<br>
<br>
Just a short summary of how I had approached the problem:<br>
<br>
We have long ruleflow which consists of other ruleflows, ruleflow groups, split conditions. Using drools API I was<br>
able to traverse through the main ruleflow including (recursively) constituent nodes. So at any node I knew which rules<br>
are relevant. Now, to find out dependency between rules I required very intricate information about any given rule. I could not<br>
find sufficient drools APIs to get this information. There are methods to get LHS and RHS of a rule but they do not give information about individual attributes. For RHS its more worse. No textual information was availabe about it. (I am using 4.0.7 and I had even posted my questions on Drools user mailing list)<br>
<br>
As a result, I wrote my own .drl file parser using javacc (which was very interesting to do) and got whatever information I required.<br>
Now I knew which rule modifies which attribute (and of which class) and which rule uses what atrributes in its conditional part. Its much easier to get dependecy sequence now. I know a few cases where this approach might produce a false dependency sequence but using other rule-flow(salience, agenda) information can help us avoid that.<br>
<br>
Now, how shall we go about it? I have installed irc on my system and I think I require some url to be able to connect to you guys.<br>
</blockquote>
The details of connecting with irc are here:<br>
<a href="http://www.jboss.org/drools/irc.html" target="_blank">http://www.jboss.org/drools/irc.html</a><br>
<br>
you want to speak to Rikkola online if you see him.<br>
<br>
We don't want to add another DRL parser, as we already build up an internal tree - including consequence. So in the drools-verifier you already see how we build the descr tree, although that doesn't yet have an AST for the consequence, however we have java analysier that currently does (using antlr) and this and pulls out used identifiers:<br>
<a href="http://anonsvn.labs.jboss.com/labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/java/JavaExprAnalyzer.java" target="_blank">http://anonsvn.labs.jboss.com/labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/java/JavaExprAnalyzer.java</a><br>
<br>
We also extended our antlr grammar to understand the modify(...) {......} keyword. So you should be able to re-use the code inside of java expr analyzer to rewrite your existing stuff and also reusing our existing descr tree. Hopefully Toni Rikolla can help you with this online.<br>
<br>
Mark<br>
<br>
</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Siddharth<div><div></div><div><br>
<br>
On Sun, Oct 5, 2008 at 7:40 PM, Mark Proctor <<a href="mailto:mproctor@codehaus.org" target="_blank">mproctor@codehaus.org</a> <mailto:<a href="mailto:mproctor@codehaus.org" target="_blank">mproctor@codehaus.org</a>>> wrote:<br>
<br>
Drools 5.0 has the drools-verifier. This does a variety of<br>
verifications and analysis, like where class fields are used, gap<br>
analysis etc. The Guvnor BRMS can produce HTML reports for this<br>
information. Subsumption isn't done yet, we needed to analys the<br>
consequences for update/modify to try and detect potential<br>
impacted rules - this is also needed to detect which rules depend<br>
on other rules.<br>
<a href="http://anonsvn.labs.jboss.com/labs/jbossrules/trunk/drools-verifier/" target="_blank">http://anonsvn.labs.jboss.com/labs/jbossrules/trunk/drools-verifier/</a><br>
<a href="http://wiki.jboss.org/wiki/RuleAnalyticsModule" target="_blank">http://wiki.jboss.org/wiki/RuleAnalyticsModule</a><br>
<br>
So we would love to have your work as additions to this, but it<br>
will need to be integrated with the existing drools-verifier<br>
module code and the HTML reporting - can you make that happen? It<br>
would be ideal, as it then means your code is part of the main<br>
project and will be maintained and improved by the community.<br>
<br>
Maybe you could pop onto irc, and chat to us about it more?<br>
<a href="http://www.jboss.org/drools/irc.html" target="_blank">http://www.jboss.org/drools/irc.html</a><br>
<br>
Do you have any visualisation plans? If on the web GWT-Diagram is<br>
turning out to be a great tool<br>
<a href="http://code.google.com/p/gwt-diagrams/" target="_blank">http://code.google.com/p/gwt-diagrams/</a><br>
<br>
Mark<br>
<br>
<br>
<br>
Sangrish wrote:<br>
<br>
Hi<br>
<br>
I have been using Drools Rules Engine in our application<br>
for past<br>
couple of weeks.<br>
One of the requirements in our project was to let a user<br>
(anyone who is<br>
writing/analysing the rules) find out<br>
what other rules a given rule depends upon. There were a few<br>
kinds of<br>
dependencies:<br>
1) Object Attribute dependency: The attributes of an object<br>
being used in<br>
the conditional part of a rule<br>
might be getting modified in the consequence part of<br>
another rule. We<br>
wanted all such rules with each rule having its own<br>
dependency list.<br>
2) Rule Salience based dependency. A rule having lower<br>
salience should be<br>
executed only after a higher (if any) salience rule has<br>
already been<br>
executed.<br>
3) Dependency caused by a specific Rule flow. Rules in a<br>
ruleflow group<br>
should be executed only if (if any) Split condition gets<br>
satisfied.<br>
4) Agenda flow dependency (i.e., one agenda following another)<br>
We could not find much support for this in the Drools API.<br>
Hence we<br>
decided to write our own dependency generator. The tool we<br>
are writing<br>
caters to first 3 dependencies. We might even handle the 4th<br>
one. Since Drools is open source, we thought of<br>
contributing our bit towards<br>
its development. If the drools team wants I can happily work<br>
with them on<br>
getting this functionality plugged in the Drools system.<br>
<br>
<br>
Thanks<br>
Siddharth<br>
<br>
<br>
_______________________________________________<br>
rules-dev mailing list<br></div></div>
<a href="mailto:rules-dev@lists.jboss.org" target="_blank">rules-dev@lists.jboss.org</a> <mailto:<a href="mailto:rules-dev@lists.jboss.org" target="_blank">rules-dev@lists.jboss.org</a>><div><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
<br>
<br>
------------------------------------------------------------------------<br>
<br>
_______________________________________________<br>
rules-dev mailing list<br>
<a href="mailto:rules-dev@lists.jboss.org" target="_blank">rules-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
<br>
</div></blockquote>
<br>
------------------------------------------------------------------------<div><br>
<br>
_______________________________________________<br>
rules-dev mailing list<br>
<a href="mailto:rules-dev@lists.jboss.org" target="_blank">rules-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
<br>
</div></blockquote><div><div></div><div>
<br>
_______________________________________________<br>
rules-dev mailing list<br>
<a href="mailto:rules-dev@lists.jboss.org" target="_blank">rules-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
</div></div></blockquote></div><br></div></div></div>
</blockquote></div><br></div>