<br> Pablo,<br><br> Thanks! Go ahead and do it. If any configuration attribute is missing, it will show up in the tests and we will be able to fix.<br><br> Edson<br><br><div class="gmail_quote">2009/12/11 Pablo Nussembaum <span dir="ltr"><<a href="mailto:baunax@gmail.com">baunax@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div text="#000000" bgcolor="#ffffff">
I agree that making those would simplify a lot, I can make these
changes if everyone (or at least the half plus one) agrees. <br><font color="#888888">
<br>
-- <br>
Bauna</font><div><div></div><div class="h5"><br>
<br>
On 12/10/2009 08:32 PM, Edson Tirelli wrote:
<blockquote type="cite"><br>
Hi Pablo,<br>
<br>
Thanks for looking into that. I am not sure why I added the
chained properties in there.. probably a copy&paste from older
classes, but the idea is that the main configuration classes are the
implementations of:<br>
<br>
KnowledgeBuilderConfiguration<br>
KnowledgeBaseConfiguraiton<br>
KnowledgeSessionConfiguration<br>
<br>
So, any configuration should be an attribute of these classes.
Whatever is not in these classes, should not be considered an actual
configuration. The chained properties class was supposed to be a
read-once utility class to initialize the configuration classes based
on files, sysproperties, etc. So, first thing I would do now would be
to remove the chained properties from the configuration class. That
will simplify everything. <br>
<br>
Any configuration option will be explicit, and once the actual
session/base/builder is created, it becomes immutable. No need for
inspecting APIs other than what is provided in the classes. The chained
properties class would still be used just to initialize the values of
the attributes, but would be thrown away after that.<br>
<br>
Mark, what do you think?<br>
<br>
Edson<br>
<br>
<div class="gmail_quote">2009/12/10 Pablo Nussembaum <span dir="ltr"><<a href="mailto:baunax@gmail.com" target="_blank">baunax@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hi
all,<br>
I'm working on drools spring and I've come upon some issues in<br>
SessionConfiguration that are stopping/confusing me.<br>
Here are my lists of doubts/concerns about SessionConfiguration:<br>
<br>
1) It stores 2 properties using Option instances variables and the rest<br>
inside a ChainedProperties class.<br>
2) There is no way no way to know what props are in the<br>
ChainedProperties from outside the SessionConfiguration.<br>
3) When the SessionConfiguration is immutable, it's still possible to<br>
add more Properties using the addProperties method.<br>
4) The ChainedProperties class is add only, in other words it isn't<br>
possible change props values. Moreover it's also possible to have two<br>
props with different values.<br>
<br>
I'm attaching a patch that fix some these issues. I've updated<br>
SessionConfiguration (g|s)etProperty(String name) method and added the<br>
ability to ChainedProperties update existing props.<br>
<br>
WDYT?<br>
<font color="#888888">--<br>
Bauna<br>
<br>
<br>
<br>
<br>
</font><br>
_______________________________________________<br>
rules-dev mailing list<br>
<a href="mailto:rules-dev@lists.jboss.org" target="_blank">rules-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
<br>
</blockquote>
</div>
<br>
<br clear="all">
<br>
-- <br>
Edson Tirelli<br>
JBoss Drools Core Development<br>
JBoss by Red Hat @ <a href="http://www.jboss.com" target="_blank">www.jboss.com</a><br>
<pre><fieldset></fieldset>
_______________________________________________
rules-dev mailing list
<a href="mailto:rules-dev@lists.jboss.org" target="_blank">rules-dev@lists.jboss.org</a>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a>
</pre>
</blockquote>
</div></div></div>
<br>_______________________________________________<br>
rules-dev mailing list<br>
<a href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br> Edson Tirelli<br> JBoss Drools Core Development<br> JBoss by Red Hat @ <a href="http://www.jboss.com">www.jboss.com</a><br>