<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 17/01/2010 22:53, Michael Neale wrote:
<blockquote
cite="mid:96ab3ced1001171453v123318cevfc846239eab10094@mail.gmail.com"
type="cite">hmm... I wonder if a script can automate that. <br>
</blockquote>
it can yes. Actually you could make a script to automate the re-packing
of all our depencies, without having to point to springsource ones. The
main thing to remember is the main jar you are wrapping must be
unzipped, but just look at the jxls, smooks and mvel examples I did to
see what i mean. PaxConstruct attempts to help with this automation:<br>
<a class="moz-txt-link-freetext" href="http://wiki.ops4j.org/display/paxconstruct/Pax+Construct">http://wiki.ops4j.org/display/paxconstruct/Pax+Construct</a><br>
<br>
Geoffrey feels we should differentiate the repackaged bundles by a
classifier and not by an artifactid prefix.<br>
<br>
Mark<br>
<blockquote
cite="mid:96ab3ced1001171453v123318cevfc846239eab10094@mail.gmail.com"
type="cite"><br>
<div class="gmail_quote">On Mon, Jan 18, 2010 at 9:48 AM, Mark
Proctor <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:mproctor@codehaus.org">mproctor@codehaus.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div bgcolor="#ffffff" text="#000000">
<div class="im">On 17/01/2010 21:57, Michael Neale wrote:
<blockquote type="cite">I don't understand why the groupIds had to
change - I
assume it is to pick up the osgi-ified versions - but why do the names
have to change so dramatically? (and I don't think it should break
things - that seems a mistake). <br>
</blockquote>
</div>
I can revert trunk back to the origianl deps, and maintain a module by
hand that has all the osgi versions. We just need to remember to keep
them in sync.<br>
<font color="#888888"><br>
Mark</font>
<div>
<div class="h5"><br>
<blockquote type="cite"><br>
<div class="gmail_quote">On Mon, Jan 18, 2010 at 6:02 AM,
Geoffrey De
Smet <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:ge0ffrey.spam@gmail.com" target="_blank">ge0ffrey.spam@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hi
guys,<br>
<br>
The OSGi ready commit on trunk of a couple of days ago, changed many<br>
pom.xml files, including the Drools core and Drools Planner pom.xml's.<br>
<br>
For example, something like this:<br>
<br>
<dependency><br>
<groupId>commons-lang</groupId><br>
<artifactId>commons-lang</artifactId><br>
</dependency><br>
<br>
Became:<br>
<br>
<dependency><br>
<groupId>org.apache.commons</groupId><br>
<artifactId>com.springsource.org.apache.commons.lang</artifactId><br>
</dependency><br>
<br>
<br>
See for example this pom.xml file:<br>
<a moz-do-not-send="true"
href="http://fisheye.jboss.org/browse/JBossRules/trunk/drools-planner/drools-planner-core/pom.xml?r1=30817&r2=31054"
target="_blank">http://fisheye.jboss.org/browse/JBossRules/trunk/drools-planner/drools-planner-core/pom.xml?r1=30817&r2=31054</a><br>
<br>
<br>
This gives rise to 2 problems:<br>
<br>
1) It uses different groupId:artifactId's!<br>
The ramifications of this are big & very backward incompatible:<br>
Lets say project X depends on drools:<br>
- X excludes commons-lang:commons-lang from the drools dependency, now<br>
he'll get it anyway, because<br>
org.apache.commons:com.springsource.org.apache.commons.lang is something<br>
else<br>
- X depends on commons-lang:commons-lang, now he'll get it twice<br>
- X depends on commons-lang:commons-lang in a different version, now<br>
he'll get it twice and maven will not get a change to do version<br>
conflict resolution (picking the highest), now he'll get it twice<br>
and drools might end up being run with a too low commons-lang version!<br>
<br>
Remember: most users don't use OSGi and don't like a "com.springsource"<br>
in their artifactId's.<br>
<br>
2) Build problems too apparently:<br>
<br>
<nheron> Project ID: org.drools.planner:drools-planner-core<br>
<nheron> POM Location:<br>
/home/nheron/workspace-IntellJ-planner/drools-planner-core/pom.xml<br>
<nheron> Validation Messages:<br>
<nheron> [0] 'dependencies.dependency.version' is missing for<br>
org.apache.commons:com.springsource.org.apache.commons.lang<br>
<nheron> [1] 'dependencies.dependency.version' is missing for<br>
org.apache.commons:<a moz-do-not-send="true"
href="http://com.springsource.org.apache.commons.io" target="_blank">com.springsource.org.apache.commons.io</a><br>
<nheron> [2] 'dependencies.dependency.version' is missing for<br>
com.thoughtworks.xstream:com.springsource.com.thoughtworks.xstream<br>
<br>
<br>
<br>
Because it is backward incompatible, I propose to shelve the OSGi ready<br>
changes till drools 6.0?<br>
<font color="#888888"><br>
--<br>
With kind regards,<br>
Geoffrey De Smet<br>
<br>
_______________________________________________<br>
rules-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:rules-dev@lists.jboss.org" target="_blank">rules-dev@lists.jboss.org</a><br>
<a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/rules-dev"
target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
</font></blockquote>
</div>
<br>
<br clear="all">
<br>
-- <br>
Michael D Neale<br>
home: <a moz-do-not-send="true" href="http://www.michaelneale.net"
target="_blank">www.michaelneale.net</a><br>
blog: <a moz-do-not-send="true" href="http://michaelneale.blogspot.com"
target="_blank">michaelneale.blogspot.com</a><br>
<pre><fieldset></fieldset>
_______________________________________________
rules-dev mailing list
<a moz-do-not-send="true" href="mailto:rules-dev@lists.jboss.org"
target="_blank">rules-dev@lists.jboss.org</a>
<a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/rules-dev"
target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a>
</pre>
</blockquote>
<br>
</div>
</div>
</div>
<br>
_______________________________________________<br>
rules-dev mailing list<br>
<a moz-do-not-send="true" href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a><br>
<a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/rules-dev"
target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
<br>
</blockquote>
</div>
<br>
<br clear="all">
<br>
-- <br>
Michael D Neale<br>
home: <a moz-do-not-send="true" href="http://www.michaelneale.net">www.michaelneale.net</a><br>
blog: <a moz-do-not-send="true" href="http://michaelneale.blogspot.com">michaelneale.blogspot.com</a><br>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
rules-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/rules-dev">https://lists.jboss.org/mailman/listinfo/rules-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>