This doesn't work for me. The annotations org.junit.Test and ...Ignore can be imported, but running JUnit tests from Eclipse still executes the so annotated test method.<br><br>Do I have to wear a special hat?<br><br>
-W<br><br><br><div class="gmail_quote">On 27 December 2010 10:26, Geoffrey De Smet <span dir="ltr"><<a href="mailto:ge0ffrey.spam@gmail.com">ge0ffrey.spam@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi guys,<br>
<br>
Spread over all the modules, there are 63 tests which are commented out.<br>
These tests should probably either be:<br>
- removed (if we don't want to keep them)<br>
- commented in and annotated with @Test @Ignore (if we want to keep them)<br>
- commented in (if they succeed and you got time to check that now)<br>
That way all "ignored" tests will be annotated with @Ignore and easy to<br>
detect (also by hudson).<br>
Also, that code (no longer commented out) will be refactored along<br>
(instead of becoming horribly stale).<br>
<br>
Can you take a look at module(s) you work on and clean that up?<br>
(Do a "git pull --rebase" first.)<br>
It shouldn't take long.<br>
<br>
I 'll take on drools-repository(2), drools-guvnor(0) and<br>
drools-planner-core(1).<br>
<br>
Targets<br>
String '^[ \t]*//[ \t]+public[ \t]+(final[ \t]+)?void[ \t]+test'<br>
Found usages (63 usages)<br>
drools-camel (1 usage)<br>
org.drools.camel.component (1 usage)<br>
JSonBatchExecutionTest.java (1 usage)<br>
(36: 1) // public void testVsmPipeline() throws<br>
Exception {<br>
drools-clips (11 usages)<br>
org.drools.clips (11 usages)<br>
ClipsShellTest.java (1 usage)<br>
(97: 1) // public void test1() {<br>
CompiledFunctionsTest.java (10 usages)<br>
(26: 1) // public void testPrintout() throws<br>
Exception {<br>
(45: 1) // public void testBindAndModify() throws<br>
Exception {<br>
(63: 1) // public void testSimpleCreate$() throws<br>
Exception {<br>
(83: 1) // public void testNestedCreate$() throws<br>
Exception {<br>
(130: 1) // public void testIf() throws Exception {<br>
(168: 1) // public void testWhile() throws Exception {<br>
(199: 1) // public void testForeach() throws Exception {<br>
(215: 1) // public void testSwitch() throws Exception {<br>
(250: 1) // public void testProgn() throws Exception {<br>
(264: 1) // public void testDefTemplate() throws<br>
Exception {<br>
drools-compiler (13 usages)<br>
org.drools.compiler (1 usage)<br>
RuleBaseLoaderTest.java (1 usage)<br>
(33: 1) // public void testEngineType() throws<br>
Exception {<br>
org.drools.integrationtests (9 usages)<br>
CepEspTest.java (1 usage)<br>
(1352: 1) // public void<br>
testTransactionCorrelation() throws Exception {<br>
MultithreadTest.java (5 usages)<br>
(80: 1) // public void<br>
testRuleBaseConcurrentCompilation() {<br>
(176: 1) // public void testExpectedFires() {<br>
(225: 1) // public void<br>
testMultithreadDateStringConstraints() {<br>
(326: 1) // public void<br>
testSharedPackagesThreadDeadLock() throws Exception {<br>
(392: 1) // public void testEventExpiration() {<br>
OutOfMemoryTest.java (1 usage)<br>
(100: 1) // public void testMemoryLeak() {<br>
StatelessSessionTest.java (2 usages)<br>
(259: 1) // public void testInAndOutParams() throws<br>
Exception {<br>
(307: 1) // public void testInOutAndOutParams()<br>
throws Exception {<br>
org.drools.lang (2 usages)<br>
RuleParserTest.java (2 usages)<br>
(776: 1) // public void testFrom() throws Exception {<br>
(1532: 1) // public void<br>
testExpanderUnExpandableErrorLines() throws Exception {<br>
org.drools.rule.builder.dialect (1 usage)<br>
JavaAndMVELCombinedTest.java (1 usage)<br>
(37: 1) // public void testJavaMVELCombination()<br>
throws Exception {<br>
drools-core (8 usages)<br>
org.drools.agent (5 usages)<br>
CompilerIndependenceTest.java (2 usages)<br>
(69: 1) // public void testDRL() throws Exception {<br>
(97: 1) // public void testPKG() throws Exception {<br>
RuleAgentTest.java (2 usages)<br>
(167: 1) // public void testSpaces() throws Exception {<br>
(406: 1) // public void<br>
testPollingFilesRuleBaseReplace2() throws Exception {<br>
URLScannerTest.java (1 usage)<br>
(88: 1) // public void testGetURL() throws Exception {<br>
org.drools.base (1 usage)<br>
EvaluatorFactoryTest.java (1 usage)<br>
(836: 1) // public void testRegexFoo() {<br>
org.drools.event.rule (1 usage)<br>
AgendaEventSupportTest.java (1 usage)<br>
(86: 1) // public void testIsSerializable() {<br>
org.drools.reteoo (1 usage)<br>
SchedulerTest.java (1 usage)<br>
(288: 1) // public void testExceptionHandler()<br>
throws Exception {<br>
drools-decisiontables (1 usage)<br>
org.drools.decisiontable.parser (1 usage)<br>
RuleWorksheetParseTest.java (1 usage)<br>
(132: 1) // public void<br>
testComplexWorksheetMissingConditions() throws Exception {<br>
drools-grid-impl (7 usages)<br>
org.drools.grid.local (1 usage)<br>
LocalGridNodeTest.java (1 usage)<br>
(92: 1) // public void<br>
testWhitePagesAddRemoveAddresss() {<br>
org.drools.grid.time.impl (5 usages)<br>
DistributedSchedulerTest.java (5 usages)<br>
(80: 1) // public void test1() throws Exception {<br>
(119: 1) // public void<br>
testDistributedJobSchedullingLocal() {<br>
(165: 1) // public void<br>
testDistributedJobSchedulingRemote() {<br>
(219: 1) // public void testMultipleSchedulersTest() {<br>
(256: 1) // public void testGetDataFromCoreServices() {<br>
org.drools.io.mina (1 usage)<br>
RegisterServicesTest.java (1 usage)<br>
(76: 1) // public void testRegisterInCoreServices() {<br>
drools-ide-common (5 usages)<br>
org.drools.ide.common.assistant (1 usage)<br>
VariableBindingTest.java (1 usage)<br>
(94: 1) // public void testThisDontWorks() {<br>
org.drools.ide.common.modeldriven.dt (1 usage)<br>
GuidedDecisionTableTest.java (1 usage)<br>
(39: 1) // public void testGetCol() {<br>
org.drools.ide.common.server.util (3 usages)<br>
BRDRLPersistenceTest.java (2 usages)<br>
(181: 1) // public void testRoundTrip() {<br>
(361: 1) // public void testLoadEmpty() {<br>
GuidedDTXMLPersistenceTest.java (1 usage)<br>
(34: 1) // public void testXML() {<br>
drools-jsr94 (1 usage)<br>
org.drools.jsr94.rules.admin (1 usage)<br>
RuleExecutionSetProviderTest.java (1 usage)<br>
(95: 1) // public void testCreateFromElement( )<br>
throws Exception<br>
drools-pipeline (1 usage)<br>
org.drools.runtime.pipeline.impl (1 usage)<br>
JaxbTest.java (1 usage)<br>
(58: 1) // public void testModelLoad() throws<br>
Exception {<br>
drools-planner-core (1 usage)<br>
org.drools.planner.core.localsearch.decider.forager (1 usage)<br>
AcceptedForagerTest.java (1 usage)<br>
(137: 1) // public void testPickMoveRandomly() {<br>
drools-repository (2 usages)<br>
org.drools.repository (2 usages)<br>
PackageItemTest.java (1 usage)<br>
(57: 1) // public void testAddPackageProperties()<br>
throws Exception {<br>
ScalabilityTest.java (1 usage)<br>
(84: 1) // public void testBare() throws Exception {<br>
drools-spring (2 usages)<br>
org.drools.container.spring.beans.persistence (2 usages)<br>
VariablePersistenceStrategyTest.java (2 usages)<br>
(402: 1) // public void<br>
testPersistenceVariablesWithTypeChange() {<br>
(453: 1) // public void<br>
testPersistenceVariablesSubProcess() {<br>
drools-verifier (9 usages)<br>
org.drools.verifier (6 usages)<br>
RangeCheckCleanTest.java (6 usages)<br>
(37: 1) // public void<br>
testUselessIntegerGapsLesser() throws Exception {<br>
(127: 1) // public void<br>
testUselessIntegerGapsGreater() throws Exception {<br>
(222: 1) // public void<br>
testUselessDoubleGapsLesser() throws Exception {<br>
(317: 1) // public void<br>
testUselessDoubleGapsGreater() throws Exception {<br>
(412: 1) // public void testUselessDateGapsLesser()<br>
throws Exception {<br>
(507: 1) // public void testUselessDateGapsGreater()<br>
throws Exception {<br>
org.drools.verifier.subsumption (3 usages)<br>
SubsumptantSubRulesTest.java (3 usages)<br>
(81: 1) // public void testSubpatternSubsumption2()<br>
throws Exception {<br>
(119: 1) // public void testSubpatternSubsumption3()<br>
throws Exception {<br>
(158: 1) // public void testSubpatternSubsumption4()<br>
throws Exception {<br>
org.drools.osgi.test (1 usage)<br>
org.drools.osgi.integrationtests (1 usage)<br>
JpaOsgi.java (1 usage)<br>
(74: 1) // public void<br>
testPersistenceWithUserTransactions() throws Exception {<br>
<br>
Note: this list doesn't include drools-eclipse or any of the flow/jBPM<br>
stuff.<br>
<br>
--<br>
With kind regards,<br>
Geoffrey De Smet<br>
<br>
<br>
_______________________________________________<br>
rules-dev mailing list<br>
<a href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
</blockquote></div><br>