This is a great feature! Unfortunately, I had to learn it the hard way ;)<div><br></div><div>Best Regards,<br clear="all"><br>XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX<br><br>Esteban Aliverti<br>- Developer @ <a href="http://www.plugtree.com" target="_blank">http://www.plugtree.com </a><br>
- Blog @ <a href="http://ilesteban.wordpress.com" target="_blank">http://ilesteban.wordpress.com</a><br>
<br><br><div class="gmail_quote">On Fri, Jan 28, 2011 at 5:58 AM, Geoffrey De Smet <span dir="ltr"><<a href="mailto:ge0ffrey.spam@gmail.com">ge0ffrey.spam@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hi guys,<br>
<br>
Until now, when a code change was committed and pushed by someone else<br>
and you did not agree with the code change(s),<br>
there were only 3 things you could do:<br>
- Fix it and commit it, if you're a 90%+ sure that it's a mistake (and<br>
probably mail the original committer so he has a chance to disagree)<br>
- Postpone it and hope you run into the original committer on IRC (or<br>
mail him), still remember the issue, still remember the class and line<br>
name and discuss it...<br>
- Ignore it, especially if you're less than 50% sure that it's a problem.<br>
Most of the times, we probably ignored it, to avoid stepping on people<br>
toes and because it's a lot of work copying the affected code.<br>
<br>
But thanks to github, there's an 4th way: look up the commit on<br>
<a href="http://github.com" target="_blank">github.com</a> and click left of the line(s) with which you don't agree.<br>
It has a couple of advantages:<br>
- Your concerns are hooked to the code line of your concerns, making it<br>
much easier for the original author to understand your point<br>
- The original author might invalidate your concerns or find a bug in<br>
your proposed changes<br>
- If the original author validates your concerns, he has learned and<br>
won't make the same mistake again<br>
- The original author might have made a similar mistake in other code<br>
(which only he knows about)<br>
<br>
Here's a recent successful conversation:<br>
<br>
<a href="https://github.com/droolsjbpm/droolsjbpm/commit/e9cbcf0e874cc2103ebda44ceafebed2473a556c#L0R359" target="_blank">https://github.com/droolsjbpm/droolsjbpm/commit/e9cbcf0e874cc2103ebda44ceafebed2473a556c#L0R359</a><br>
<br>
You can find a list of all commit comments here:<br>
<a href="https://github.com/droolsjbpm/droolsjbpm/comments" target="_blank">https://github.com/droolsjbpm/droolsjbpm/comments</a><br>
<br>
--<br>
With kind regards,<br>
Geoffrey De Smet<br>
<br>
<br>
_______________________________________________<br>
rules-dev mailing list<br>
<a href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
</blockquote></div><br></div>