<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<title></title>
</head>
<body text="#000000" bgcolor="#ffffff">
Hi Sayhi,<br>
<br>
Thanks for noticing this issue and creating a patch.<br>
<br>
Unfortunately I cannot accept and apply this patch because:<br>
- By changing the build resources to only include
src/main/resources/**/*.gwt.xml, it breaks the backend which needs
other resources out of src/main/resources.<br>
- By changing the build resources to include the java files from
src/main/java, it clutters the deployed jars and dirties the build
(those things are in source jars already).<br>
- It's stale when compared to master on
<a class="moz-txt-link-freetext" href="https://github.com/droolsjbpm/guvnor">https://github.com/droolsjbpm/guvnor</a><br>
-- drools-factconstraints has been removed some time already on
master<br>
-- droolsjbpm-ide-common is ne<br>
- The changes are obfuscated with style changes that do not follow
our guidelines.<br>
-- See README
<a class="moz-txt-link-freetext" href="https://github.com/droolsjbpm/droolsjbpm-build-bootstrap">https://github.com/droolsjbpm/droolsjbpm-build-bootstrap</a><br>
--- More specifically about indentation<br>
<br>
I believe a much better way to deal with the gwt:run problem is to
fix this issue:<br>
<a class="moz-txt-link-freetext" href="https://issues.jboss.org/browse/GUVNOR-1196">https://issues.jboss.org/browse/GUVNOR-1196</a><br>
But that's stuck on the fact that I don't know if and how
intellij/eclipse can deal with hosted mode in that structure.<br>
Any experiments and data to answer that question will help that
issue forward.<br>
<pre class="moz-signature" cols="72">--
With kind regards,
Geoffrey De Smet</pre>
<br>
Op 24-02-11 02:17, Sayhi Aymen schreef:
<blockquote
cite="mid:AANLkTi=vRbaHctdDdKSP5ghgtLPPgtAiw9mmdfK778WL@mail.gmail.com"
type="cite">
<div><br>
</div>
Here is the patch. I hope it helps !
<div>
<div><br>
<div class="gmail_quote">2011/2/23 Mauricio Salatino <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:salaboy@gmail.com">salaboy@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
Sounds really cool.. if you can help to get maven working
better for the project I think that the dev team will
highly appreciate that.<br>
Greetings.<br>
<br>
<div class="gmail_quote">
<div>
<div class="h5">On Wed, Feb 23, 2011 at 1:36 PM, Sayhi
Aymen <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:sayhi.aymen@gmail.com"
target="_blank">sayhi.aymen@gmail.com</a>></span>
wrote:<br>
</div>
</div>
<blockquote class="gmail_quote" style="border-left: 1px
solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex;
padding-left: 1ex;">
<div>
<div class="h5">
<div><br>
</div>
Hi everybody,
<div><br>
I checked Drools 5.2.0.M1.x sources yesterday in
order to look with more insight to <i>Guvnor </i>internals.<br>
<br>
</div>
<div>I built the whole project with <i>Maven</i> and
that was ok.<br>
<br>
</div>
<div>But when I tried to run <i>Guvnor </i>with <i>Maven </i>(mvn
gwt:run) I was surprised to see that the <i>Maven </i>config
do not allow that, I get a lot of errors !<br>
<br>
</div>
<div>Thankfully I fixed that (after a hard night)
and I want to contribute with that <i>Maven </i>config
fix.<br>
<br>
</div>
<div>Are you interested ?<br>
<br>
</div>
<div>By the way, I've already been <i>Maven </i>maintainer
of an open source project on sourceforge, <i><a
moz-do-not-send="true"
href="http://noon.gilead.free.fr/gilead/index.php?page=thanks"
target="_blank">Gilead</a></i>. And I can
help you in the future for anything related to <i>Maven</i>.</div>
<br>
-- <br>
Best Regards<br>
<font color="#888888">Aymen SAYHI<br>
<br>
<br>
</font><br>
</div>
</div>
_______________________________________________<br>
rules-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:rules-dev@lists.jboss.org"
target="_blank">rules-dev@lists.jboss.org</a><br>
<a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/rules-dev"
target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
<br>
</blockquote>
</div>
<font color="#888888"><br>
<br clear="all">
<br>
-- <br>
- CTO @ <a moz-do-not-send="true"
href="http://www.plugtree.com" target="_blank">http://www.plugtree.com</a>
<br>
- MyJourney @ <a moz-do-not-send="true"
href="http://salaboy.wordpress.com" target="_blank">http://salaboy.wordpress.com</a><br>
- Co-Founder @ <a moz-do-not-send="true"
href="http://www.jbug.com.ar" target="_blank">http://www.jbug.com.ar</a><br>
<br>
- Salatino "Salaboy" Mauricio -<br>
</font></blockquote>
</div>
<br>
<br clear="all">
<br>
-- <br>
Best Regards<br>
Aymen SAYHI<br>
<br>
<br>
</div>
</div>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
rules-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/rules-dev">https://lists.jboss.org/mailman/listinfo/rules-dev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">
</pre>
</body>
</html>