<span class="Apple-style-span" style="border-collapse: collapse; font-family: arial, sans-serif; font-size: 13px; ">Hi Geoffrey,<div><br></div><div>I've fixed all things you've talked about and I've some remarks:</div>
</span><br><div class="gmail_quote">2011/2/24 Geoffrey De Smet <span dir="ltr"><<a href="mailto:ge0ffrey.spam@gmail.com">ge0ffrey.spam@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div text="#000000" bgcolor="#ffffff">
Hi Sayhi,<br>
<br>
Thanks for noticing this issue and creating a patch.<br>
<br>
Unfortunately I cannot accept and apply this patch because:<br>
- By changing the build resources to only include
src/main/resources/**/*.gwt.xml, it breaks the backend which needs
other resources out of src/main/resources.<br></div></blockquote><div><br></div><div><span class="Apple-style-span" style="border-collapse: collapse; font-family: arial, sans-serif; font-size: 13px; ">Fixed : you're right !</span></div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div text="#000000" bgcolor="#ffffff">
- By changing the build resources to include the java files from
src/main/java, it clutters the deployed jars and dirties the build
(those things are in source jars already).<br></div></blockquote><div><br></div><div><span class="Apple-style-span" style="border-collapse: collapse; font-family: arial, sans-serif; font-size: 13px; "><div>Maintained: </div>
<div>Projects "drools-factconstraint" and "drools-ide-common" are seen as gwt libraries by "drools-guvnor", one of the rules for developing gwt libraries is that when packaged, classes that reside in the client package (i.e. those that will be used in client code of projets using the library) should have their sources packaged with them. The reason for this is that sources should be available on the classpath for the gwt compiler.</div>
<div><br></div><div>You can check this in gwt-user.jar itself :</div><div><a href="http://repo1.maven.org/maven2/com/google/gwt/gwt-user/2.1.1/gwt-user-2.1.1.jar" target="_blank" style="color: rgb(0, 0, 204); ">http://repo1.maven.org/maven2/com/google/gwt/gwt-user/2.1.1/gwt-user-2.1.1.jar</a></div>
<div><br></div><div>And in the famous library Ext GWT :</div><div><a href="http://repo1.maven.org/maven2/com/extjs/gxt/2.2.0/gxt-2.2.0.jar" target="_blank" style="color: rgb(0, 0, 204); ">http://repo1.maven.org/maven2/com/extjs/gxt/2.2.0/gxt-2.2.0.jar</a></div>
</span></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div text="#000000" bgcolor="#ffffff">
- It's stale when compared to master on
<a href="https://github.com/droolsjbpm/guvnor" target="_blank">https://github.com/droolsjbpm/guvnor</a><br>
-- drools-factconstraints has been removed some time already on
master<br>
-- droolsjbpm-ide-common is ne<br></div></blockquote><div><br></div><div>This patch is intended for "origin/5.2.0.M1.x" branch, not for master.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div text="#000000" bgcolor="#ffffff">
- The changes are obfuscated with style changes that do not follow
our guidelines.<br>
-- See README
<a href="https://github.com/droolsjbpm/droolsjbpm-build-bootstrap" target="_blank">https://github.com/droolsjbpm/droolsjbpm-build-bootstrap</a><br>
--- More specifically about indentation<br>
<br></div></blockquote><div><br></div><div>Fixed: sorry for that :) I'm using your cleaning and formatting settings now.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div text="#000000" bgcolor="#ffffff">
I believe a much better way to deal with the gwt:run problem is to
fix this issue:<br>
<a href="https://issues.jboss.org/browse/GUVNOR-1196" target="_blank">https://issues.jboss.org/browse/GUVNOR-1196</a></div></blockquote><div><br></div><div>You don't really think it is needed to do All that in order to run the guvnor project with maven.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div text="#000000" bgcolor="#ffffff"><br>
But that's stuck on the fact that I don't know if and how
intellij/eclipse can deal with hosted mode in that structure.<br>
Any experiments and data to answer that question will help that
issue forward.<br><font color="#888888">
<pre cols="72">--
With kind regards,
Geoffrey De Smet</pre>
<br></font></div></blockquote><div><br></div><div><div>I attached a patch (fixed one :)) to this e-mail for those who are using branch 5.2.0.M1.x and need to run the guvnor project in hosted mode with maven.</div><div>
<br></div><div>P.S. sorry for the previous e-mail, it was incomplete.</div></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div text="#000000" bgcolor="#ffffff">
<font color="#888888">
Op 24-02-11 02:17, Sayhi Aymen schreef:
</font><div><div></div><div class="h5"><blockquote type="cite">
<div><br>
</div>
Here is the patch. I hope it helps !
<div>
<div><br>
<div class="gmail_quote">2011/2/23 Mauricio Salatino <span dir="ltr"><<a href="mailto:salaboy@gmail.com" target="_blank">salaboy@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">
Sounds really cool.. if you can help to get maven working
better for the project I think that the dev team will
highly appreciate that.<br>
Greetings.<br>
<br>
<div class="gmail_quote">
<div>
<div>On Wed, Feb 23, 2011 at 1:36 PM, Sayhi
Aymen <span dir="ltr"><<a href="mailto:sayhi.aymen@gmail.com" target="_blank">sayhi.aymen@gmail.com</a>></span>
wrote:<br>
</div>
</div>
<blockquote class="gmail_quote" style="border-left:1px solid rgb(204, 204, 204);margin:0pt 0pt 0pt 0.8ex;padding-left:1ex">
<div>
<div>
<div><br>
</div>
Hi everybody,
<div><br>
I checked Drools 5.2.0.M1.x sources yesterday in
order to look with more insight to <i>Guvnor </i>internals.<br>
<br>
</div>
<div>I built the whole project with <i>Maven</i> and
that was ok.<br>
<br>
</div>
<div>But when I tried to run <i>Guvnor </i>with <i>Maven </i>(mvn
gwt:run) I was surprised to see that the <i>Maven </i>config
do not allow that, I get a lot of errors !<br>
<br>
</div>
<div>Thankfully I fixed that (after a hard night)
and I want to contribute with that <i>Maven </i>config
fix.<br>
<br>
</div>
<div>Are you interested ?<br>
<br>
</div>
<div>By the way, I've already been <i>Maven </i>maintainer
of an open source project on sourceforge, <i><a href="http://noon.gilead.free.fr/gilead/index.php?page=thanks" target="_blank">Gilead</a></i>. And I can
help you in the future for anything related to <i>Maven</i>.</div>
<br>
-- <br>
Best Regards<br>
<font color="#888888">Aymen SAYHI<br>
<br>
<br>
</font><br>
</div>
</div>
_______________________________________________<br>
rules-dev mailing list<br>
<a href="mailto:rules-dev@lists.jboss.org" target="_blank">rules-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
<br>
</blockquote>
</div>
<font color="#888888"><br>
<br clear="all">
<br>
-- <br>
- CTO @ <a href="http://www.plugtree.com" target="_blank">http://www.plugtree.com</a>
<br>
- MyJourney @ <a href="http://salaboy.wordpress.com" target="_blank">http://salaboy.wordpress.com</a><br>
- Co-Founder @ <a href="http://www.jbug.com.ar" target="_blank">http://www.jbug.com.ar</a><br>
<br>
- Salatino "Salaboy" Mauricio -<br>
</font></blockquote>
</div>
<br>
<br clear="all">
<br>
-- <br>
Best Regards<br>
Aymen SAYHI<br>
<br>
<br>
</div>
</div>
<pre><fieldset></fieldset>
_______________________________________________
rules-dev mailing list
<a href="mailto:rules-dev@lists.jboss.org" target="_blank">rules-dev@lists.jboss.org</a>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a>
</pre>
</blockquote>
<br>
<pre cols="72"></pre>
</div></div></div>
<br>_______________________________________________<br>
rules-dev mailing list<br>
<a href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br><br></blockquote></div><div><br>-- <br>Best Regards<br>Aymen SAYHI<br><br><br>
</div>