<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
<br>
<br>
Op 10-05-11 11:42, Nicolas Héron schreef:
<blockquote
cite="mid:BANLkTinoxF4rhs3KVsSQ=AvsvOMmURRfnA@mail.gmail.com"
type="cite">
<pre wrap="">Hello,
just a stupid question : what is a pull request when you have to push
your commits on github ?
</pre>
</blockquote>
For example:<br>
you fork drools,<br>
clone your fork,<br>
push your commits to your fork on github<br>
create a pull request for those commits,<br>
and then edson <i>pulls</i> your commits into the blessed drools
repository.<br>
<br>
Hence the name "pull request": you want edson to pull your changes.<br>
<a class="moz-txt-link-freetext" href="http://help.github.com/pull-requests/">http://help.github.com/pull-requests/</a><br>
<blockquote
cite="mid:BANLkTinoxF4rhs3KVsSQ=AvsvOMmURRfnA@mail.gmail.com"
type="cite">
<pre wrap="">Thanks
Nicolas
2011/5/10 Geoffrey De Smet <a class="moz-txt-link-rfc2396E" href="mailto:ge0ffrey.spam@gmail.com"><ge0ffrey.spam@gmail.com></a>:
</pre>
<blockquote type="cite">
<pre wrap="">+1 It might help to keep hudson blue more often.
but pull requests need to be merged as soon as possible.
So per git repository it needs to be clear who's taking care of the pull
requests.
Otherwise no one might and they might go stale and we 'd loose valuable
commits,
which would be worse than before.
For example:
droolsjbpm-build-bootstrap => Geoffrey
knowledge-api => Edson (same person as on drools I presume)
drools => Edson
drools-planner => Geoffrey
jbpm => Kris
droolsjbpm-integration => ?
guvnor => ?
tools => Bob Bolt?
build-distribution (the OSGi stuff) => ?
Op 10-05-11 10:56, Mark Proctor schreef:
</pre>
<blockquote type="cite">
<pre wrap="">We've been monitoring github over the last few weeks. Github now makes
it trivial for people to work in their own forks and submit pull
requests. We have found that from time to time people don't rebase
properly or check their commits after a push, and thus end up
overwritting other people's work. We are thinking of trialing the
leuitenant model for a while, where just core people are responsible for
accepting and applying pull requests. With git's distributedd model,
this should hopefully work out well.
So from this point on, unless you are a core developer responsible for a
specific module, can I ask that you submit pull requests for future work?
thanks
Mark
_______________________________________________
rules-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/rules-dev">https://lists.jboss.org/mailman/listinfo/rules-dev</a>
</pre>
</blockquote>
<pre wrap="">
--
With kind regards,
Geoffrey De Smet
_______________________________________________
rules-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/rules-dev">https://lists.jboss.org/mailman/listinfo/rules-dev</a>
</pre>
</blockquote>
<pre wrap="">_______________________________________________
rules-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/rules-dev">https://lists.jboss.org/mailman/listinfo/rules-dev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
With kind regards,
Geoffrey De Smet</pre>
</body>
</html>