Just a remark, everytime you fetch from upstream and merge/push into your own fork, that commit is automagically added to the pull request, so if you're doing that "synchronization" often, your pull request won't get stale.<br>
<br>Since, it's a risky one, my pull request (<a href="https://github.com/droolsjbpm/drools/pull/2">https://github.com/droolsjbpm/drools/pull/2</a>) is on the waiting list since 5/April, for example, and it can still be "automatically merged" according to github.<br>
<br>Cheers,<br>Leo.<br><br><div class="gmail_quote">On Tue, May 10, 2011 at 11:17 AM, Geoffrey De Smet <span dir="ltr"><<a href="mailto:ge0ffrey.spam@gmail.com">ge0ffrey.spam@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
+1 It might help to keep hudson blue more often.<br>
<br>
but pull requests need to be merged as soon as possible.<br>
So per git repository it needs to be clear who's taking care of the pull<br>
requests.<br>
Otherwise no one might and they might go stale and we 'd loose valuable<br>
commits,<br>
which would be worse than before.<br>
<br>
For example:<br>
<br>
droolsjbpm-build-bootstrap => Geoffrey<br>
knowledge-api => Edson (same person as on drools I presume)<br>
drools => Edson<br>
drools-planner => Geoffrey<br>
jbpm => Kris<br>
droolsjbpm-integration => ?<br>
guvnor => ?<br>
tools => Bob Bolt?<br>
build-distribution (the OSGi stuff) => ?<br>
<br>
<br>
<br>
Op 10-05-11 10:56, Mark Proctor schreef:<br>
<div><div></div><div class="h5">> We've been monitoring github over the last few weeks. Github now makes<br>
> it trivial for people to work in their own forks and submit pull<br>
> requests. We have found that from time to time people don't rebase<br>
> properly or check their commits after a push, and thus end up<br>
> overwritting other people's work. We are thinking of trialing the<br>
> leuitenant model for a while, where just core people are responsible for<br>
> accepting and applying pull requests. With git's distributedd model,<br>
> this should hopefully work out well.<br>
><br>
> So from this point on, unless you are a core developer responsible for a<br>
> specific module, can I ask that you submit pull requests for future work?<br>
><br>
> thanks<br>
><br>
> Mark<br>
><br>
> _______________________________________________<br>
> rules-dev mailing list<br>
> <a href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
><br>
<br>
</div></div>--<br>
With kind regards,<br>
<font color="#888888">Geoffrey De Smet<br>
</font><div><div></div><div class="h5"><br>
<br>
_______________________________________________<br>
rules-dev mailing list<br>
<a href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
</div></div></blockquote></div><br>