<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 10/07/2011 00:23, Mark Proctor wrote:
<blockquote cite="mid:4E18E308.8020807@codehaus.org" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
On 10/07/2011 00:20, Mark Proctor wrote:
<blockquote cite="mid:4E18E23A.5090907@codehaus.org" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
On 09/07/2011 23:59, Mikael Lönneberg wrote:
<blockquote
cite="mid:CAOnUFFMqsbgwg5SeXMgmaxhryCMJqG=iNxBtDGLrHb_r4StGVA@mail.gmail.com"
type="cite">Hi,
<div><br>
</div>
<div>In trying to fix JBRULES-2730 and JBRULES-3063, I noticed
that fixing this issue will actually break
MiscTest#testRuleReplacement.</div>
<div>So should this test case be rewritten to not allow rule
replacement, or are there circumstances where rule
replacements are allowed and if that is the case what are
those circumstances?</div>
</blockquote>
Rule replacement is allowed and an important part of a dynamic
rule engine. I believe what we do is disallow it from the same
resource (should double check that) i.e. a drl that repeats the
rule twice is an error. If you load a later resource it will
overwrite the previous.<br>
</blockquote>
Thinking about this some more. We should probably add a
"getWarnings" as well as getErrors. Rule overwriting would come
with a warning.<br>
<br>
We might even find a way build warning filters, a composite set of
warnings to fail on, but user defineable.<br>
</blockquote>
If you want to work on a separate jira for this?<br>
<br>
1) add warnings list to packagebuilder<br>
2) add hasWarnings and getWarnings, in mirror of errors.<br>
3) allow hashWarnings and getWarnings to take positive/negative
warnings. i.e. ignore duplicate resource (hasWarnings would return
false), report duplicate file (is returned in list). This should be
some sort of chainable or compositable filter, with sane defaults.<br>
<br>
For us to include this it will need to be well unit tested and
ideally report other types of warnings too... Ideas on other types
of warnings (note this is different to verification and analysis)<br>
<br>
Mark<br>
<blockquote cite="mid:4E18E308.8020807@codehaus.org" type="cite">
<blockquote cite="mid:4E18E23A.5090907@codehaus.org" type="cite">
<blockquote
cite="mid:CAOnUFFMqsbgwg5SeXMgmaxhryCMJqG=iNxBtDGLrHb_r4StGVA@mail.gmail.com"
type="cite">
<div><br>
</div>
<div>ConsequenceOffsetTest.testConsequenceOffset also fails
due to loading two resource files with the same package and
rule name defined in the different files.</div>
<div><br>
</div>
</blockquote>
Sounds like a bug, can you update some stronger tests and fix?<br>
<br>
Mark<br>
<blockquote
cite="mid:CAOnUFFMqsbgwg5SeXMgmaxhryCMJqG=iNxBtDGLrHb_r4StGVA@mail.gmail.com"
type="cite">
<div><br>
</div>
<div>Kind regards</div>
<div><br>
</div>
<div>Mikael Lonneberg - gwendo</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
rules-dev mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/rules-dev">https://lists.jboss.org/mailman/listinfo/rules-dev</a>
</pre>
</blockquote>
<br>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
rules-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/rules-dev">https://lists.jboss.org/mailman/listinfo/rules-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>