<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 10/07/2011 00:20, Mark Proctor wrote:
<blockquote cite="mid:4E18E23A.5090907@codehaus.org" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
On 09/07/2011 23:59, Mikael Lönneberg wrote:
<blockquote
cite="mid:CAOnUFFMqsbgwg5SeXMgmaxhryCMJqG=iNxBtDGLrHb_r4StGVA@mail.gmail.com"
type="cite">Hi,
<div><br>
</div>
<div>In trying to fix JBRULES-2730 and JBRULES-3063, I noticed
that fixing this issue will actually break
MiscTest#testRuleReplacement.</div>
<div>So should this test case be rewritten to not allow rule
replacement, or are there circumstances where rule
replacements are allowed and if that is the case what are
those circumstances?</div>
</blockquote>
Rule replacement is allowed and an important part of a dynamic
rule engine. I believe what we do is disallow it from the same
resource (should double check that) i.e. a drl that repeats the
rule twice is an error. If you load a later resource it will
overwrite the previous.<br>
</blockquote>
Thinking about this some more. We should probably add a
"getWarnings" as well as getErrors. Rule overwriting would come with
a warning.<br>
<br>
We might even find a way build warning filters, a composite set of
warnings to fail on, but user defineable.<br>
<blockquote cite="mid:4E18E23A.5090907@codehaus.org" type="cite">
<blockquote
cite="mid:CAOnUFFMqsbgwg5SeXMgmaxhryCMJqG=iNxBtDGLrHb_r4StGVA@mail.gmail.com"
type="cite">
<div><br>
</div>
<div>ConsequenceOffsetTest.testConsequenceOffset also fails due
to loading two resource files with the same package and rule
name defined in the different files.</div>
<div><br>
</div>
</blockquote>
Sounds like a bug, can you update some stronger tests and fix?<br>
<br>
Mark<br>
<blockquote
cite="mid:CAOnUFFMqsbgwg5SeXMgmaxhryCMJqG=iNxBtDGLrHb_r4StGVA@mail.gmail.com"
type="cite">
<div><br>
</div>
<div>Kind regards</div>
<div><br>
</div>
<div>Mikael Lonneberg - gwendo</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
rules-dev mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/rules-dev">https://lists.jboss.org/mailman/listinfo/rules-dev</a>
</pre>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>