<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 2011/11/27 1:30, Michael Anstis wrote:
<blockquote
cite="mid:CAAG9P0v+qASCJeOoyH-n4r1FNM=y8+YAnhVqZ7RaUyKVknB-4A@mail.gmail.com"
type="cite">Top banana Jervis :)<br>
<br>
JVMDateConverter is only used by Drools Guvnor (for the decision
tables) so might not (or should not be duplicated).<br>
<br>
I also don't understand why GuvnorTestBase and
MockAssetItemIterator cannot simply live in guvnor-core as
guvnor-drools references it.<br>
</blockquote>
GuvnorTestBase and MockAssetItemIterator are located under the test
director. I dont know if there is anyway to reference them from
guvnor-webapp-drools module.<br>
<blockquote
cite="mid:CAAG9P0v+qASCJeOoyH-n4r1FNM=y8+YAnhVqZ7RaUyKVknB-4A@mail.gmail.com"
type="cite">
<br>
I suspect we should split up the resources folders between
guvnor-core and guvnor-drools as you say constants.properties.<br>
<br>
Anyway, I imported the new modules today and am able to run Guvnor
Drools (preliminary tests) without problem.<br>
<br>
With kind regards,<br>
<br>
Mike<br>
<br>
<div class="gmail_quote">On 26 November 2011 06:40, Jervis Liu <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:jliu@redhat.com">jliu@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex;">
Done.<br>
<br>
To-do-list:<br>
1. I have to duplicate GuvnorTestBase.java,
MockAssetItemIterator.java<br>
and JVMDateConverter in guvnor-webapp-core and
guvnor-webapp-drools<br>
modules. One solution is to create another module called<br>
guvnor-webapp-testutils. Let me know if you have better ideas.<br>
2. guvnor-webapp-core and guvnor-webapp-drools both have a
same copy of<br>
constants.properties. Need to remove unused constants from
this file<br>
(and different language versions) for each module.
Straightforward to<br>
do, but definitely takes time.<br>
3. Need to refactor and split sever side code.<br>
<br>
Cheers,<br>
Jervis<br>
<div class="HOEnZb">
<div class="h5">On 2011/11/24 10:30, Jervis Liu wrote:<br>
> Michael Anstis wrote:<br>
>> Just a thought.<br>
>><br>
>> When is the BRMS 5.3 freeze?<br>
>><br>
>> Back-porting Guvnor fixes post this split is
going to be a PITA.<br>
>><br>
> What I heard is after the Christmas.<br>
>> On 23 November 2011 07:43, Jervis Liu <<a
moz-do-not-send="true" href="mailto:jliu@redhat.com">jliu@redhat.com</a><br>
>> <mailto:<a moz-do-not-send="true"
href="mailto:jliu@redhat.com">jliu@redhat.com</a>>>
wrote:<br>
>><br>
>> Hi,<br>
>><br>
>> As part of the ongoing work to refactor
Guvnor towards a generic<br>
>> service<br>
>> repository framework (Guvnor NG. Please check
this thread for<br>
>> relevant<br>
>> discussions: <a moz-do-not-send="true"
href="http://community.jboss.org/thread/173484"
target="_blank">http://community.jboss.org/thread/173484</a>),
I am<br>
>> going to<br>
>> split guvnor-webapp module to three modules:
guvnor-webapp-core,<br>
>> guvnor-webapp-drools, guvnor-webapp-soa. The
split has been done<br>
>> on my<br>
>> local branch and the plan is to merge the
change to master this<br>
>> Friday.<br>
>> To avoid huge merge conflicts after my split,
I strongly<br>
>> encourage you<br>
>> to commit whatever changes you have to
master before this<br>
>> Friday. Let<br>
>> me know if you have any questions. I will
start the merge this<br>
>> Friday<br>
>> morning (10AM, GMT +8) if I dont hear any
objections. Thanks.<br>
>><br>
>> Cheers,<br>
>> Jervis<br>
>>
_______________________________________________<br>
>> rules-dev mailing list<br>
>> <a moz-do-not-send="true"
href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a>
<mailto:<a moz-do-not-send="true"
href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a>><br>
>> <a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/rules-dev"
target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
>><br>
>><br>
>>
------------------------------------------------------------------------<br>
>><br>
>> _______________________________________________<br>
>> rules-dev mailing list<br>
>> <a moz-do-not-send="true"
href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a><br>
>> <a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/rules-dev"
target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
><br>
><br>
<br>
_______________________________________________<br>
rules-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a><br>
<a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/rules-dev"
target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
</div>
</div>
</blockquote>
</div>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
rules-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/rules-dev">https://lists.jboss.org/mailman/listinfo/rules-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>