<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Big fix just went in for property specific. Mask calculation is now
fully determined at network build time, and not runtime. Much
greater test coverage for various network build configurations. Lots
of edge cases are now fixed as a result of increased tests, and also
ability to test at build time, rather runtime. Rule removal is now
supported and masks will be recalculated.<br>
<a class="moz-txt-link-freetext" href="https://github.com/droolsjbpm/drools/commit/5dad95a82ee462965c8b79fcf66e76e39ecf56f2">https://github.com/droolsjbpm/drools/commit/5dad95a82ee462965c8b79fcf66e76e39ecf56f2</a><br>
<a class="moz-txt-link-freetext" href="https://github.com/droolsjbpm/drools/blob/master/drools-compiler/src/test/java/org/drools/integrationtests/PropertySpecificTest.java">https://github.com/droolsjbpm/drools/blob/master/drools-compiler/src/test/java/org/drools/integrationtests/PropertySpecificTest.java</a><br>
<br>
Cell() Will not listen to any changes without adding an a @watch;
i.e. a pattern without any constraints is equivalent to @watch(!*)<br>
<br>
With regards to @PropertySpecific. I'm now leaning towards the
following two:<br>
ClassListener<br>
PropertyListener<br>
<br>
Which is short for:<br>
ClassChangeListener<br>
PropertyChangeListener<br>
<br>
I don't think we need the longer version as it should be pretty
clear what the shorter versions are. The names are very generic, so
we just need to be sure they don't clash with other potential
annotations.<br>
<br>
The above two require no attributes, but must be used exclusively.
The alternative is:<br>
ChangeListener(Property)<br>
ChangeListener(Class)<br>
<br>
Mark<br>
On 16/02/2012 18:32, Mark Proctor wrote:
<blockquote cite="mid:4F3D4BCE.4050102@codehaus.org" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
On 16/02/2012 17:43, Mario Fusco wrote:
<blockquote
cite="mid:CAPYjU_kLgtE-rG+cYp362om2hRxQnsS-4ZnDcD3CYPO_g+qBqw@mail.gmail.com"
type="cite">If you're referring to the discussion about the
annotation's names, we haven't taken a decision yet, but it is
something that needs to be addressed next week latest.<br>
At the moment I committed my code using the annotations
@PropertySpecific and @NotPropertySpecific but nobody like them
(including myself) so I will rename them as soon as we will take
a decision.<br>
</blockquote>
yup, we are struggling to find something that is consistent and
doesn't look pants :(<br>
<br>
So far we just keep coming back to PropertySpecific, which is ok
for now. But once we reverse the behaviour with the common use
case becoming PropertySpecific(false) we lose a little bit of
language ergenomics imho. Btw I say common use case, because
PropertySpecific with no arguments won't be useful as that will be
the default behaviour at that point.<br>
<br>
Mark<br>
<blockquote
cite="mid:CAPYjU_kLgtE-rG+cYp362om2hRxQnsS-4ZnDcD3CYPO_g+qBqw@mail.gmail.com"
type="cite"> <br>
Mario <br>
<br>
<div class="gmail_quote">On Thu, Feb 16, 2012 at 6:35 PM,
Wolfgang Laun <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:wolfgang.laun@gmail.com">wolfgang.laun@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"> There was
a brief discussion about annotation class names a few days
<div>ago - has this been finalized, and if so, what is the
result? </div>
<div><br>
</div>
<div>Thanks</div>
<div><span class="HOEnZb"><font color="#888888">Wolfgang</font></span>
<div>
<div class="h5"><br>
<br>
<div class="gmail_quote">On 16 February 2012 18:26,
Mark Proctor <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:mproctor@codehaus.org"
target="_blank">mproctor@codehaus.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">We
are just fine tuning PropertySpecific behahviour.<br>
<br>
Initially a pattern without any properties' mask
was set to<br>
LONG.MAX_VALUE so that it responded to any field
changes.<br>
<br>
However we've now changed it to 0, so Cell() will
respond to the initial<br>
insertion, but it will not respond to any
modifies.<br>
<br>
Should you want it to respond to modifies you must
add @watch(*).<br>
<br>
The other aspect is that we are adding a kbuillder
configration to set<br>
the default behaviour. Currently it is off. With
it defaulting to off<br>
using PropertySpecific as an annotation makes
sense. If we default it to<br>
on you then need to use PropertySpecific(true).
i.e. the reversing of<br>
the logic means for the common case we now need an
argument. Considering<br>
this common case will become default at some point
in the future, i.e.<br>
you want the parameterless version to be the
common use case.<br>
NonPropertySpecific is a bit long :)<br>
<br>
Mark<br>
_______________________________________________<br>
rules-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:rules-dev@lists.jboss.org"
target="_blank">rules-dev@lists.jboss.org</a><br>
<a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/rules-dev"
target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
<br>
_______________________________________________<br>
rules-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a><br>
<a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/rules-dev"
target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
<br>
</blockquote>
</div>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
rules-dev mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/rules-dev">https://lists.jboss.org/mailman/listinfo/rules-dev</a>
</pre>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>