I have cloned it and running benchmarks on it. Might not be able to complete it tonight.<div>-W</div><div><br><div><br><div class="gmail_quote">On 28 February 2012 19:55, Edson Tirelli <span dir="ltr"><<a href="mailto:ed.tirelli@gmail.com">ed.tirelli@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><br></div> I am sure he would not deny that... :) you are helping to make the world a better place... :) <div><br>
</div><div> In any case, please open a JIRA so that this does not get lost in the e-mails. It is a low hanging fruit, very isolated and simple to fix. So anyone looking for a starting work to contribute to the project can do it. Otherwise I will do it when I get the time.</div>
<div><br></div><div> Thanks,</div><div> Edson</div><div><div><div><div class="h5"><br><div class="gmail_quote">On Tue, Feb 28, 2012 at 1:45 PM, SirMungus <span dir="ltr"><<a href="mailto:Patrick_Rusk@ssga.com" target="_blank">Patrick_Rusk@ssga.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Edson Tirelli-4 wrote<br>
<div>><br>
> I see what you are saying and I think it works. Although, it will be<br>
> heavier, it would cover scenarios not covered by the current<br>
> implementation.<br>
><br>
> My suggestion is if you can, please create a test case for the problem,<br>
> change the collectSet accumulate function to do what you propose and send<br>
> a<br>
> pull request. I will review it and apply. I think in this case, making<br>
> user's life easier by not requiring immutability might trump performance,<br>
> but we need to evaluate some tests just in case.<br>
><br>
</div>Edson, thanks for the offer. I'll see what I can do. Since I work at a<br>
financial services company, I practically have to get Obama's permission to<br>
do anything official on an open source project. :)<br>
<br>
--<br>
View this message in context: <a href="http://drools.46999.n3.nabble.com/BUG-5-3-0-Final-CollectSetAccumulateFunction-should-probably-use-IdentityHashMap-internally-tp3774079p3784963.html" target="_blank">http://drools.46999.n3.nabble.com/BUG-5-3-0-Final-CollectSetAccumulateFunction-should-probably-use-IdentityHashMap-internally-tp3774079p3784963.html</a><br>
<div><div>Sent from the Drools: Developer (committer) mailing list mailing list archive at Nabble.com.<br>
_______________________________________________<br>
rules-dev mailing list<br>
<a href="mailto:rules-dev@lists.jboss.org" target="_blank">rules-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><div class="im">-- <br> Edson Tirelli<br> JBoss Drools Core Development<br> JBoss by Red Hat @ <a href="http://www.jboss.com" target="_blank">www.jboss.com</a><br>
</div></div></div>
<br>_______________________________________________<br>
rules-dev mailing list<br>
<a href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
<br></blockquote></div><br></div></div>