Yes Jervis you are correct.<br><br>This is the current impact of the regression:-<br><ul><li>Broken Gunvor tests</li><ul><li>org.drools.ide.common.server.rules.SuggestionCompletionLoaderTest.testGeneratedBeansExtendsSimple</li>
<li>org.drools.ide.common.server.rules.SuggestionCompletionLoaderTest.testGeneratedBeansExtendsPOJOComplex<br></li></ul><li><a href="https://bugzilla.redhat.com/show_bug.cgi?id=796612" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=796612</a></li>
<li><a href="https://bugzilla.redhat.com/show_bug.cgi?id=754093" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=754093</a></li></ul>With kind regards,<br><br>Mike<br><br><div class="gmail_quote">On 1 March 2012 08:34, Jervis Liu <span dir="ltr"><<a href="mailto:jliu@redhat.com">jliu@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Hi Mike, <br>
<br>
I believe it is the same regression problem you mentioned that
caused following 2 tests failed on 5.3.x branch?<br>
<br>
<a href="http://hudson.qa.jboss.com/hudson/job/guvnor-5.3.x/564/" target="_blank">http://hudson.qa.jboss.com/hudson/job/guvnor-5.3.x/564/</a><br>
<br>
BTW, we started to get those 2 failures around Feb 9, 2012 , if this
info helps to find out whom is to blame ;-). Please check
<a href="http://hudson.qa.jboss.com/hudson/job/guvnor-5.3.x/473/" target="_blank">http://hudson.qa.jboss.com/hudson/job/guvnor-5.3.x/473/</a>. The build
473 was triggered by a upstream change. <br>
<br>
Thanks,<br>
Jervis<br>
On 2012/2/17 21:30, Michael Anstis wrote:
<blockquote type="cite">Hi,<br>
<br>
There appears to be a regression in TypeDeclarationDescr in 5.3.x
branch, as illustrated by the below.<br>
<br>
Bean2 is shown as having a super-type of "Object" whereas it
should be "Bean1". The fields are correctly listed.<br>
<br>
This is causing tests in Guvnor to fail.<br>
<br>
Could somebody please take a look?<br>
<br>
Thanks,<br>
<br>
Mike<br>
<br>
<span style="font-family:courier new,monospace">package
org.drools.ide.common.server.rules;</span><br style="font-family:courier new,monospace">
<br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">import
java.io.StringReader;</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">import
java.util.List;</span><br style="font-family:courier new,monospace">
<br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">import
org.drools.compiler.DrlParser;</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">import
org.drools.compiler.DroolsError;</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">import
org.drools.compiler.PackageBuilder;</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">import
org.drools.definition.type.FactField;</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">import
org.drools.lang.descr.PackageDescr;</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">import
org.drools.lang.descr.TypeDeclarationDescr;</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">import
org.junit.Test;</span><br style="font-family:courier new,monospace">
<br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">public class
RegressionTest {</span><br style="font-family:courier new,monospace">
<br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace"> @Test</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace"> public void
regression() {</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace"> String drl
= "package foo \n"</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
+ "declare Bean1 \n"</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
+ "age: int \n"</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
+ "name : String \n"</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
+ "end \n"</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
+ "declare Bean2 extends Bean1\n"</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
+ "cheese : String \n"</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
+ "end";</span><br style="font-family:courier new,monospace">
<br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
PackageBuilder builder = new PackageBuilder();</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace"> try {</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
DrlParser parser = new DrlParser();</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
PackageDescr pkgDescr = parser.parse( drl );</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace"> for (
TypeDeclarationDescr baseType : pkgDescr.getTypeDeclarations() )
{</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
String declaredSuperTypeName = baseType.getSuperTypeName();</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
System.out.println( baseType.getTypeName() + " extends " +
declaredSuperTypeName );</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace"> }</span><br style="font-family:courier new,monospace">
<br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
builder.addPackageFromDrl( new StringReader( drl ) );</span><br style="font-family:courier new,monospace">
<br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
System.out.println("foo.Bean1 fields=");</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
List<FactField> fieldsBean1 =
builder.getPackage().getFactType( "foo.Bean1" ).getFields();</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace"> for (
FactField field : fieldsBean1 ) {</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
System.out.println( field.getName() );</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace"> }</span><br style="font-family:courier new,monospace">
<br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
System.out.println("foo.Bean2 fields=");</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
List<FactField> fieldsBean2 =
builder.getPackage().getFactType( "foo.Bean2" ).getFields();</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace"> for (
FactField field : fieldsBean2 ) {</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
System.out.println( field.getName() );</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace"> }</span><br style="font-family:courier new,monospace">
<br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace"> if (
builder.hasErrors() ) {</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
for ( DroolsError e : builder.getErrors().getErrors() ) {</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
System.out.println( e.getMessage() );</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace"> }</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace"> }</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace"> } catch (
Exception e ) {</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">
e.printStackTrace();</span><br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace"> }</span><br style="font-family:courier new,monospace">
<br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace"> }</span><br style="font-family:courier new,monospace">
<br style="font-family:courier new,monospace">
<span style="font-family:courier new,monospace">}</span><br style="font-family:courier new,monospace">
<br>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
rules-dev mailing list
<a href="mailto:rules-dev@lists.jboss.org" target="_blank">rules-dev@lists.jboss.org</a>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a>
</pre>
</blockquote>
<br>
</div>
<br>_______________________________________________<br>
rules-dev mailing list<br>
<a href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br>
<br></blockquote></div><br>