<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Quotes from Javadoc of 6.0.0 Beta 3<br>
<br>
(1)<br>
org.kie.api.builder Interface KieBuilder<br>
<br>
"Sets the other KieModules from which the KieModule that has to be<br>
built by this KieBuilder depends on"<br>
<br>
"Sets the other Resources from which the KieModule that has to be<br>
built by this KieBuilder depends on"<br>
<br>
I had to read these several times... Does this mean:<br>
<br>
The KieModule to be built by this KieBuilder depends on the given KieModules.<br>
<br>
The KieModule to be built by this KieBuilder depends on the given Dependencies.<br></blockquote><div><br></div><div>Not sure I get the difference between these last 2 sentences. It means the given KieModules are dependencies for the KieModule that is going to be built. Can you suggest a better way to make this more understandable in plain English?<br>
</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
=*=*=<br>
(2)<br>
org.kie.api Interface KieBase<br>
<br>
removeProcess(String processId)<br>
Removes a process from the specified package.<br>
<br>
Where is the "specified package"? Either javadoc is incorrect or the<br>
parameter is missing.<br></blockquote><div><br></div><div>Wrong Javadoc. Fixed.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
=*=*=<br>
(3)<br>
Which English is it?<br>
<br>
EqualityBehaviorOption getEqualsBehavior()<br>
Returns the EqualityBehavior of this KieBaseModel<br>
EqualityBehaviorOption - Enum in org.kie.api.conf<br>
An Enum for EqualityBehavior option.<br>
<br>
BUT<br>
<br>
org.kie.api.management.KieBaseConfigurationMonitorMBean.getAssertBehaviour()<br></blockquote><div><br></div><div>I guess that last method name should be changed, but I am not sure it is a good idea to do it now since it will break compatibility.<br>
</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
=*=*=<br>
(4)<br>
getClockType() - Method in interface org.kie.api.builder.model.KieSessionModel<br>
Returns the EqualityBehavior of this KieSessionModel<br>
REALLY?<br></blockquote><div><br></div><div>Bad copy&paste. Fixed.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
=*=*=<br>
(5)<br>
execute(Iterable) - Method in interface<br>
org.kie.api.runtime.rule.StatelessRuleSession<br>
Execute a StatelessKnowledSession, iterate the Iterable inserting<br>
each of it's elements.<br>
<br>
=> its<br>
<br>
(Several times.)<br></blockquote><div><br></div><div>Fixed.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
=*=*=<br>
(6)<br>
org.kie.api.runtime Interface KieRuntime<br>
<br>
setGlobal(String identifier, Object value)<br>
Sets a global value on the internal collection<br>
<br>
Which "internal collection"? A global becomes an object in a KieSessions?<br></blockquote><div><br></div><div>Fixed.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
=*=*=<br>
(7)<br>
org.kie.api.runtime.rule Interface StatelessRuleSession<br>
<br>
StatelessKnowledSession => Stateless?????Session<br>
<br>
Rule? Knowledge? (Occurs several times.)<br></blockquote><div><br></div><div>It should have been StatelessKieSession. Fixed.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
=*=*=<br>
(8)<br>
org.kie.api.runtime Class ClassObjectFilter<br>
<br>
Filters Objects by Class, only accepting Classes of the specified type<br>
=><br>
Filters objects by class, only accepting objects of the class<br>
specified in the constructor<br>
<br>
Returning true means the Iterator accepts, and thus returns, the<br>
current Object's Class type.<br>
=><br>
Returns true if the Iterator accepts the given object according to its class.<br></blockquote><div><br></div><div>Ok.<br> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
=*=*=<br>
(9)<br>
Package org.kie.api.runtime<br>
<br>
The runtime engine classes, including StatefulKnowledgeSession and<br>
StatelessKnowledgeSession.<br>
<br>
StatelessKnowledgeSession and StatefulKnowledgeSession are gone now,<br>
aren't they?<br>
=*=*=<br>
(10)<br>
org.kie.api.runtime Interface CommandExecutor<br>
<br>
Batch Executor allows for the scripting of of a Knowledge session<br>
using Commands, both the StatelessKnowledgeSession and<br>
StatefulKnowledgeSession implement this interface.<br>
<br>
StatelessKnowledgeSession and StatefulKnowledgeSession are gone now,<br>
aren't they?<br></blockquote><div><br>StatelessKnowledgeSession and StatefulKnowledgeSession have been replaced respectively by KieSession and StatelessKieSession. We are keeping the first ones as aliases for the second ones in kie-internal only for compatibility reasons.<br>
</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
=*=*=<br>
(11)<br>
org.kie.api.runtime Interface KieSessionConfiguration<br>
<br>
(a)<br>
KnowledgeSessionConfiguration A class to store Session related configuration<br>
=><br>
A class to store a session related configuration.<br>
<br>
(b)<br>
KnowledgeSession => KieSession (?, occurs several times)<br>
<br>
(c) Doesn't seem right:<br>
...behaviour inside KnowledgeSession. drools.keepReference = drools.clockType =<br></blockquote><div><br></div><div>FIxed. <br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
=*=*=<br>
(12)<br>
Message is not a good choice. KieMessage would have been better...<br>
=*=*=<br></blockquote><div><br></div><div>Too late to change it now.<br></div><div> <br></div><div>Thanks a lot for having reviewed this.<br></div><div>Mario<br></div></div></div></div>