<div dir="ltr"><div><div><div>Joe, <br><br></div>as said by Mark the DummyKieScanner acts only as a placeholder to avoid tons of null checks inside the code. But you're right when you wrote that it should fail fast when requested to load an artifact. I'll make the DummyKieScanner.loadArtifact methods to throw a more meaningful Exception when invoked.<br>
<br></div>Thank you for having reported this,<br></div>Mario<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Mar 8, 2014 at 3:53 AM, Mark Proctor <span dir="ltr"><<a href="mailto:mproctor@codehaus.org" target="_blank">mproctor@codehaus.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">I suspect the DummyKieScanner was there to avoid people getting null pointers. But I think actually it may be best to throw an exception, to fail fast. The dummy can’t be used for anything, and it will jut confuse users. <div>
<br></div><div>@mario: thoughts?<br><div><div><br></div><div>Mark<br><div><div><div class="h5"><div>On 7 Mar 2014, at 23:18, Joe White <<a href="mailto:Joe.White@recondotech.com" target="_blank">Joe.White@recondotech.com</a>> wrote:</div>
<br></div></div><blockquote type="cite"><div link="#0563C1" vlink="#954F72" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" lang="EN-US">
<div><div class="h5"><div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif">In the KieRepositoryImpl code what is the purpose of instantiating to the DummyScanner if the kie-ci jar is not on the classpath. Lines 120-126 in the impl. Ultimately this results in a Not Found exception downstream but masks the true issue of the missing jar. Seems like it would be better off throwing the exception back out to the caller so they know they are missing the jar?<u></u><u></u></div>
<div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif">I’m just trying to get a handle on how it is all wired together and spent a couple of hours chasing why it wouldn’t find my kmodule jar when the core problem was my ear was just missing the kie-ci.<u></u><u></u></div>
<div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif">Thanks,<u></u><u></u></div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif">
<u></u> <u></u></div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><span style="color:rgb(31,73,125)">Joe</span><span style="color:rgb(31,73,125)"><u></u><u></u></span></div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif">
<u></u> <u></u></div></div></div></div>_______________________________________________<br>rules-dev mailing list<br><a href="mailto:rules-dev@lists.jboss.org" style="color:rgb(149,79,114);text-decoration:underline" target="_blank">rules-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" style="color:rgb(149,79,114);text-decoration:underline" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a></div></blockquote></div><br></div>
</div></div></div><br>_______________________________________________<br>
rules-dev mailing list<br>
<a href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br></blockquote></div><br></div>