<div dir="ltr">Hi Joe,<div><br></div><div>I'm just merging your PR - and tweaking a couple of bits - there was potential for a NPE and some tests were failing.</div><div><br></div><div>Please submit as a new PR.</div><div>
<br></div><div>Thanks,</div><div><br></div><div>Mike</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 21 March 2014 19:58, Joe White <span dir="ltr"><<a href="mailto:Joe.White@recondotech.com" target="_blank">Joe.White@recondotech.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Thanks Mike.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I will update to deploy to default profile repositories as well and add that to the pull request.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Joe<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> <a href="mailto:rules-dev-bounces@lists.jboss.org" target="_blank">rules-dev-bounces@lists.jboss.org</a> [mailto:<a href="mailto:rules-dev-bounces@lists.jboss.org" target="_blank">rules-dev-bounces@lists.jboss.org</a>]
<b>On Behalf Of </b>Michael Anstis<br>
<b>Sent:</b> Friday, March 21, 2014 1:48 PM<br>
<b>To:</b> Rules Dev List<br>
<b>Subject:</b> Re: [rules-dev] Pull request for remote deploy (GUVNOR-2088)<u></u><u></u></span></p><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<p>Great stuff Joe!<u></u><u></u></p>
<p>We like to promote that KIE operates "like normal" with regards to Maven. If you've noticed another short fall it'd be great for if you could plug that gap too I'll merge the lot next week.
<u></u><u></u></p>
<p>Other aspects of KIE honour Maven conventions (such as default profiles) and the workbench in this regard should be no different.
<u></u><u></u></p>
<p>Thanks,<u></u><u></u></p>
<p>Mike<u></u><u></u></p>
<p>Sent on the move<u></u><u></u></p>
<div>
<p class="MsoNormal">On 21 Mar 2014 19:31, "Joe White" <<a href="mailto:Joe.White@recondotech.com" target="_blank">Joe.White@recondotech.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<p class="MsoNormal">I have created a pull request that updates the GuvnorM2Repository code to deploy to a remote repository if one is configured in the <distributionManagement> section of a pom in
the workbench. If the repository requires authentication the system will fetch the credentials by repository id from the settings.xml file.<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">I tested this publishing to both a snapshot and a release repository. Both require credentials and both worked (thanks to mfusco).<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">One question:<u></u><u></u></p>
<p class="MsoNormal">Currently it does not publish to the default profile repositories in the settings.xml. Should it? In other words, if the user has a default profile in their settings should Guvnor
go ahead and deploy to the configured repository? This would fit with normal maven operation but I don’t know if the user would expect the workbench code to be handled differently.<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">If you guys want Guvnor to publish to the settings.xml repositories automatically let me know and I can make that update as well.<u></u><u></u></p>
<p class="MsoNormal"><span style="color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="color:#1f497d">Once the above is decided I’ll update the documentation and create a pull request for that as well.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="color:#1f497d"><a href="https://github.com/droolsjbpm/guvnor/pull/111" target="_blank">https://github.com/droolsjbpm/guvnor/pull/111</a></span><u></u><u></u></p>
<p class="MsoNormal"><span style="color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="color:#1f497d">Joe</span><u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><br>
_______________________________________________<br>
rules-dev mailing list<br>
<a href="mailto:rules-dev@lists.jboss.org" target="_blank">rules-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><u></u><u></u></p>
</blockquote>
</div>
</div></div></div>
</div>
<br>_______________________________________________<br>
rules-dev mailing list<br>
<a href="mailto:rules-dev@lists.jboss.org">rules-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-dev</a><br></blockquote></div><br></div>