[rules-users] 5.4.0.Beta2 parse error in consequence /* in string

[Benjamin Bennett]

Got permission from my company.  Digging around think , correct me if
I am wrong.

The bug is actually most likely in the mvel project.

I checked out the mvel project.

In the mvel project there is method call skipWhiteSpace()   .


This method skips different types of comments.

It is a minor issue. Just going to try start with something small.



On Tue, Feb 28, 2012 at 9:45 AM, Benjamin Bennett <benbennett at gmail.com> wrote:
> Working on the sign contributer agreement. Have to fill out the permission
> slip at the company I work for to contribute back in my free time.
>
> I submitted at merge request https://github.com/droolsjbpm/drools/pull/102
>
> If the commit looks fine but just waiting on the Contributor Agreement . If
> there is something I did wrong in the commit or comment just looking for
> feedback.
>
>
>
> Just going to add the // /* to the array to test it.
>
> Yeah I didn't test the // with 5.3.0 but I am pretty sure it happens in
> latest master .
>
> I was going to use the commit
> https://github.com/benbennett/drools/commit/d5325b93589aafdfaeb1f45077eb4da3a8970a2f
> .
>
> And add // and /*   to the array to cycle through.
>
>
>
>
>
>
> 2012/2/28 Mark Proctor <mproctor at codehaus.org>
>>
>> On 27/02/2012 15:44, Benjamin Bennett wrote:
>>
>> I had created issue JBRULES-3399 for the issue. I tracked it a bit , it is
>> any comment.
>>
>> // or /*  , think the lexar expression for comment isn't correct .
>>
>> I am working towards a fix but not a  antlr expert. I have used yacc.
>>
>> just a reminder to read this page, on how to correctly comment your
>> commits, how to submit pull requests etc:
>> http://www.athico.com/Getting_Involved/gettinginvolved.html
>>
>> Mark
>>
>>
>>
>>
>> On Mon, Feb 27, 2012 at 1:38 AM, Wolfgang Laun <wolfgang.laun at gmail.com>
>> wrote:
>>>
>>> Submitted: JBRULES-3401.
>>>
>>> -W
>>>
>>>
>>> On 24/02/2012, Benjamin Bennett <benbennett at gmail.com> wrote:
>>> > Just passing on I am using the drools 5.4.0Beta2
>>> >
>>> > The following doesn't compile using the mvel dialect .
>>> > rule "some rule"
>>> >  when
>>> > fact: Fact()
>>> > then
>>> > BasicFact fault= new BasicFact( "/*");
>>> > end
>>> >
>>> > but
>>> > rule "some rule"
>>> >  when
>>> > fact: Fact()
>>> > then
>>> > BasicFact fault= new BasicFact( "/ *");
>>> > end
>>> >
>>> > does compile some how /* is being parsed as an expression I think and
>>> > not a
>>> > string literal.
>>> >
>>> > Thanks,
>>> > Ben
>>> >
>>> _______________________________________________
>>> rules-users mailing list
>>> rules-users at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/rules-users
>>
>>
>>
>>
>> --
>> Sincerely,
>>
>> Benjamin Bennett
>> 314.246.0645
>> benbennett at gmail.com
>>
>> "For a successful technology, reality must take precedence over public
>> relations, for Nature cannot be fooled."
>> Richard Feynman
>>
>>
>> _______________________________________________
>> rules-users mailing list
>> rules-users at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/rules-users
>>
>>
>>
>> _______________________________________________
>> rules-users mailing list
>> rules-users at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/rules-users
>>
>
>
>
> --
> Sincerely,
>
> Benjamin Bennett
> 314.246.0645
> benbennett at gmail.com
>
> "For a successful technology, reality must take precedence over public
> relations, for Nature cannot be fooled."
> Richard Feynman



-- 
Sincerely,

Benjamin Bennett
314.246.0645
benbennett at gmail.com

"For a successful technology, reality must take precedence over public
relations, for Nature cannot be fooled."
Richard Feynman