<div dir="ltr"><br> Are use setting the global in your application code?<br><br><div class="gmail_quote">2008/9/16 Warren, David [USA] <span dir="ltr"><<a href="mailto:warren_david@bah.com">warren_david@bah.com</a>></span><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div>
<div dir="ltr" align="left"><span><font color="#0000ff" size="2" face="Arial">Edson -</font></span></div>
<div dir="ltr" align="left"><span><font color="#0000ff" size="2" face="Arial">Thank you very much for the reply. I have one more
question. </font></span><span><font color="#0000ff" size="2" face="Arial">In the example below I changed RulesUtil to be a
global name 'ruleUtil' (since its member variables do not change), and reran the
rule (with the 'ruleUtil:RulesUtil()' line omitted).</font></span></div>
<div dir="ltr" align="left"><span><font color="#0000ff" size="2" face="Arial"></font></span> </div>
<div dir="ltr" align="left"><span><font color="#0000ff" size="2" face="Arial">When I do this, and execute the rule below, I get a null
pointer exception on PredicateConstraint. The first and last
parts of the stack trace are:</font></span></div>
<div dir="ltr" align="left"><span><font color="#0000ff" size="2" face="Arial">org.drools.RuntimeDroolsException: Exception executing
predicate <a href="mailto:com.bah.aims.rules.Rule_my_rule_0ReturnValue0Invoker@36289b82" target="_blank">com.bah.aims.rules.Rule_my_rule_0ReturnValue0Invoker@36289b82</a><br> at
org.drools.rule.PredicateConstraint.isAllowed(PredicateConstraint.java:216)<br> at
org.drools.reteoo.AlphaNode.assertObject(AlphaNode.java:132)<br> at
org.drools.reteoo.CompositeObjectSinkAdapter.propagateAssertObject(CompositeObjectSinkAdapter.java:318)<br> at
org.drools.reteoo.AlphaNode.assertObject(AlphaNode.java:140)<br> at
org.drools.reteoo.CompositeObjectSinkAdapter.propagateAssertObject(CompositeObjectSinkAdapter.java:299)<br> at
org.drools.reteoo.ObjectTypeNode.assertObject(ObjectTypeNode.java:153)<br>...</font></span></div>
<div dir="ltr" align="left"><span><font color="#0000ff" size="2" face="Arial">Caused by: java.lang.NullPointerException<br> at
com.bah.aims.rules.Rule_my_rule__0.returnValue0(Rule_my_rule_0.java:27)<br> at
com.bah.aims.rules.Rule_my_rule_0ReturnValue0Invoker.evaluate(Rule_myRule_0ReturnValue0Invoker.java:21)<br> at
org.drools.rule.PredicateConstraint.isAllowed(PredicateConstraint.java:210)<br> ...
29 more</font></span></div>
<div dir="ltr" align="left"><span><font color="#0000ff" size="2" face="Arial"></font></span> </div>
<div dir="ltr" align="left"><span><font color="#0000ff" size="2" face="Arial">I'm not sure what is causing this. Any
thoughts?</font></span></div>
<div dir="ltr" align="left"><span><font color="#0000ff" size="2" face="Arial">If it helps, RulesUtil.containsKeywordString() checks
to see if a string passed in is present in a list of keywords held in the
class.</font></span></div>
<div dir="ltr" align="left"><span><font color="#0000ff" size="2" face="Arial"></font></span> </div>
<div dir="ltr" align="left"><span><font color="#0000ff" size="2" face="Arial">Thanks - </font></span></div>
<div dir="ltr" align="left"><span><font color="#0000ff" size="2" face="Arial">David</font></span></div>
<div dir="ltr" align="left"><span><font color="#0000ff" size="2" face="Arial"></font></span> </div><font color="#0000ff" size="2" face="Arial"></font><font color="#0000ff" size="2" face="Arial"></font><font color="#0000ff" size="2" face="Arial"></font><font color="#0000ff" size="2" face="Arial"></font><font color="#0000ff" size="2" face="Arial"></font><font color="#0000ff" size="2" face="Arial"></font><br>
<div dir="ltr" align="left" lang="en-us">
<hr>
<font size="2" face="Tahoma"><div class="Ih2E3d"><b>From:</b> <a href="mailto:rules-users-bounces@lists.jboss.org" target="_blank">rules-users-bounces@lists.jboss.org</a>
[mailto:<a href="mailto:rules-users-bounces@lists.jboss.org" target="_blank">rules-users-bounces@lists.jboss.org</a>] <b>On Behalf Of </b>Edson
Tirelli<br></div><b>Sent:</b> Tuesday, September 16, 2008 9:56 AM<br><b>To:</b> Rules
Users List<br><b>Subject:</b> Re: [rules-users] Request for assistance in
removing eval from a rule<br></font><br></div><div><div></div><div class="Wj3C7c">
<div></div>
<div dir="ltr"><font color="#0000ff" size="2" face="Arial"></font><font color="#0000ff" size="2" face="Arial"></font><font color="#0000ff" size="2" face="Arial"></font><font color="#0000ff" size="2" face="Arial"></font><font color="#0000ff" size="2" face="Arial"></font><font color="#0000ff" size="2" face="Arial"></font><font color="#0000ff" size="2" face="Arial"></font><font color="#0000ff" size="2" face="Arial"></font><font color="#0000ff" size="2" face="Arial"></font><br>
David,<br><br> Eval is really bad for perf, but still, sometimes it
is the only way to do things like call methods. So, in your case, it all depends
on what "containsKeywordString()" method is doing?<br> <br>
Also, is RulesUtil just a utility class? I mean with no data you reason over? if
so, I strongly advise you to make it a global, instead of matching it in the
rule like a fact.<br><br> Regarding evals, inline evals are just a
bit lighter than top level evals, but there is an important difference:<br><br>*
inline evals MUST be time consistent, i.e., they must evaluate to the same value
everytime they are called.<br>* top level evals can deal with changes
appropriately <br><br> []s<br> Edson<br><br>
<div class="gmail_quote">2008/9/15 Warren, David [USA] <span dir="ltr"><<a href="mailto:warren_david@bah.com" target="_blank">warren_david@bah.com</a>></span><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div>
<div dir="ltr" align="left"><font color="#0000ff" size="2" face="Arial">Folks -
</font></div>
<div dir="ltr" align="left"><font color="#0000ff" size="2" face="Arial"></font> </div>
<div dir="ltr" align="left"><font face="Arial"><font color="#0000ff"><font size="2">After <span>seeing the </span>thread
on <span>e</span>vals <span>hurting performance </span>a couple of
weeks ago<span>, I tried to remove them from a rule set we are
using (running Drools 4.0.4), and have had limited
success.</span></font></font></font><font color="#0000ff" size="2" face="Arial"></font></div>
<div dir="ltr" align="left"><font color="#0000ff" size="2" face="Arial"></font> </div>
<div dir="ltr" align="left"><font color="#0000ff" size="2" face="Arial"><span>An example
is shown below. We're using evals every time we make a call to
"rulesUtil", a helper class we have for checking strings for keywords.
Two questions:</span></font></div>
<div dir="ltr" align="left"><font color="#0000ff" size="2" face="Arial"><span></span></font> </div>
<div dir="ltr" align="left"><font color="#0000ff" size="2" face="Arial"><span>1. Does using inline evals (like below) hurt performance as
much as using non-inline evals?</span></font></div>
<div dir="ltr" align="left"><font color="#0000ff" size="2" face="Arial"><span>2. If
so, any thoughts for how to rewrite this rule to avoid using the
eval?</span></font></div>
<div dir="ltr" align="left"><font color="#0000ff" size="2" face="Arial"></font> </div>
<div dir="ltr" align="left"><font color="#0000ff" size="2" face="Arial"></font> </div><font color="#0000ff" size="2"><font color="#960000" size="1">
<div dir="ltr" align="left"><font color="#0000ff" size="2" face="Arial">rule</font></div></font><font face="Arial">'my rule'</font></font></div>
<div dir="ltr" align="left"><b><font color="#960000"><font face="Arial">salience</font></font></b><font face="Arial"> 790</font></div>
<div dir="ltr" align="left"><b><font color="#960000"><font face="Arial">activation-group</font></font></b><font face="Arial"> <font color="#008000">"priorityRule"</font></font></div>
<div dir="ltr" align="left"><b><font color="#960000"><font face="Arial">when</font></font></b></div>
<div dir="ltr" align="left"><font face="Arial">ruleUtil : RulesUtil( )</font></div>
<div dir="ltr" align="left"><font face="Arial">s1 : Sensor( source == <font color="#008000">"X</font>, $rfp : RFP , <b><font color="#960000">eval</font></b></font><font face="Arial">(
ruleUtil.containsKeywordString($rfp, <font color="#008000">"Y"</font>
)<span>)</span> , $tcn : TCN)</font></div>
<div dir="ltr" align="left"><font face="Arial">s2 : Sensor( TCN != $tcn, source ==
<font color="#008000">"Z"</font></font></div>
<div dir="ltr" align="left"><b><font color="#960000"><font face="Arial">then</font></font></b></div>
<div dir="ltr" align="left"><font face="Arial">System.out.println(<font color="#008000">"my rule");</font></font></div>
<div dir="ltr" align="left"><font face="Arial">priority.setPriorityName(<span>"A"</span></font><font face="Arial">);</font></div>
<div dir="ltr" align="left"><font face="Arial"></font> </div><font face="Arial">
<div dir="ltr" align="left">end</div></font>
<div dir="ltr" align="left"><font face="Arial"><font size="2"><font color="#0000ff"><font color="#0000ff" size="2" face="Arial"></font></font></font></font> </div>
<div dir="ltr" align="left"><font color="#0000ff" size="2" face="Arial"><span>Thanks,</span></font></div>
<div dir="ltr" align="left"><font color="#0000ff" size="2" face="Arial"><span>David
Warren</span></font></div><font color="#0000ff" size="2" face="Arial"></font><font color="#0000ff" size="2" face="Arial"></font><br>
<div dir="ltr" align="left" lang="en-us">
<hr>
<font size="2" face="Tahoma"><b>From:</b> <a href="mailto:rules-users-bounces@lists.jboss.org" target="_blank">rules-users-bounces@lists.jboss.org</a> [mailto:<a href="mailto:rules-users-bounces@lists.jboss.org" target="_blank">rules-users-bounces@lists.jboss.org</a>] <b>On Behalf Of
</b>Edson Tirelli<br><b>Sent:</b> Friday, September 05, 2008 2:59
PM<br><b>To:</b> Rules Users List<br><b>Subject:</b> Re: [rules-users] Drools,
Performance issues on 4.0.7 Vs 2.5<br></font><br></div>
<div></div>
<div dir="ltr"><br> Start by eliminating the evals and writing your
constraints properly inside the patterns. Drools 3+ is orders of magnitude
faster than Drools 2.x, but you need to leverage its power in your rules.
Please read the manual as the version 3 was a completely rewrite of version 2.
Version 4 is an improvement over 3.<br><br> As an example, look at
this: <a href="http://blog.athico.com/2006/11/rush-hour-and-content-based-routing.html" target="_blank">http://blog.athico.com/2006/11/rush-hour-and-content-based-routing.html</a><br><br>
[]s<br> Edson<br><br>
<div class="gmail_quote">2008/9/5 Rout, Sushanta (ThoughtMill) <span dir="ltr"><<a href="mailto:Sushanta.Rout@ihg.com" target="_blank">Sushanta.Rout@ihg.com</a>></span><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">We
were using Drools 2.5 version earlier. Now we have switched to drools<br><a href="http://4.0.7." target="_blank">4.0.7.</a> But we see significant issues
with performance like drools 4.0.7<br>is three times slower than 2.5 . Has
anybody encountered the issue?<br><br>Here is a sample of the rule, we have
some more similar to this.<br>rule "test"<br>
dialect "java"<br> activation-group
"group1"<br> when<br>
$croNumberDetailsRequest :
CRONumberDetailsRequest()<br>
$resdirectPhoneNumber : ResdirectPhoneNumber()<br>
eval($resdirectPhoneNumber.getType().getId() == 5
&&<br><br>$resdirectPhoneNumber.isValidForBrand($croNumberDetailsRequest.getBrand(<br>))
&&<br>
$croNumberDetailsRequest.getRegion() != null
&&<br><br>$resdirectPhoneNumber.isValidRegion($croNumberDetailsRequest.getRegion()<br>)
&&<br>
$croNumberDetailsRequest.getLocale() != null
&&<br><br><br>$resdirectPhoneNumber.isValidForLocaleId($croNumberDetailsRequest.getLoc<br>ale())
&&<br><br>$resdirectPhoneNumber.isValidSlot($croNumberDetailsRequest.getSlot()));<br><br>
then<br>
ResultList.add($resdirectPhoneNumber);<br>end<br><br>_______________________________________________<br>rules-users
mailing list<br><a href="mailto:rules-users@lists.jboss.org" target="_blank">rules-users@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/rules-users" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-users</a><br>
</blockquote></div><br><br clear="all"><br>-- <br>Edson Tirelli<br>JBoss Drools Core Development<br>JBoss,
a division of Red Hat @ <a href="http://www.jboss.com" target="_blank">www.jboss.com</a><br></div><br>_______________________________________________<br>rules-users
mailing list<br><a href="mailto:rules-users@lists.jboss.org" target="_blank">rules-users@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/rules-users" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-users</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>Edson Tirelli<br>JBoss Drools Core Development<br>JBoss, a
division of Red Hat @ <a href="http://www.jboss.com" target="_blank">www.jboss.com</a><br></div></div></div></div>
<br>_______________________________________________<br>
rules-users mailing list<br>
<a href="mailto:rules-users@lists.jboss.org">rules-users@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-users" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-users</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br> Edson Tirelli<br> JBoss Drools Core Development<br> JBoss, a division of Red Hat @ <a href="http://www.jboss.com">www.jboss.com</a><br>
</div>