I think I follow you now. If I was a little smarter with my conditional statements to NOT keep assigning YES to something that is already set to YES then it would probably eliminate the loop. In other words if I added more checks like the ==null that you pointed out, I could (although I am not sure that they are bad) remove the no-loop settings. Right?<br>
<br>Thanks,<br><br>Bryan<br><br><div class="gmail_quote">On Mon, Nov 3, 2008 at 9:17 AM, Joe White <span dir="ltr"><<a href="mailto:Joe.White@recondotech.com">Joe.White@recondotech.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div link="blue" vlink="purple" lang="EN-US">
<div>
<p><span style="font-size: 11pt;">You
need no-loop on the rules because of the call to "modify(s)" . Modify changes
the fact in working memory and </span><span><span style="font-size: 11pt;">the engine is
automatically notified of the changes at the end of the modify block</span></span><span style="font-size: 11pt;">. After modify the
same rule could hit again as the conditions are still true.</span></p>
<p><span style="font-size: 11pt;"> </span></p>
<p><span style="font-size: 11pt;">The
first rule doesn't need the no-loop it because of the check "</span>recommendPurchase
== null"</p>
<p> </p>
<p>Joe<span style="font-size: 11pt;"></span></p>
<p><span style="font-size: 11pt; color: rgb(31, 73, 125);"> </span></p>
<div style="border-style: solid none none; border-color: rgb(181, 196, 223) -moz-use-text-color -moz-use-text-color; border-width: 1pt medium medium; padding: 3pt 0in 0in;">
<p><b><span style="font-size: 10pt;">From:</span></b><span style="font-size: 10pt;">
<a href="mailto:rules-users-bounces@lists.jboss.org" target="_blank">rules-users-bounces@lists.jboss.org</a>
[mailto:<a href="mailto:rules-users-bounces@lists.jboss.org" target="_blank">rules-users-bounces@lists.jboss.org</a>] <b>On Behalf Of </b>Bryan Hansen<br>
<b>Sent:</b> Sunday, November 02, 2008 8:21 PM<br>
<b>To:</b> <a href="mailto:rules-users@lists.jboss.org" target="_blank">rules-users@lists.jboss.org</a><br>
<b>Subject:</b> [rules-users] no-loop usage question</span></p>
</div><div><div></div><div class="Wj3C7c">
<p> </p>
<p>I have been reading through the documentation and trying
some of the tutorials and have a question about the no-loop attribute. <br>
<br>
Not really relevant to the post, but I figured I would mention it, I have been
following this post and updating it to use the current version of Drools. <a href="http://www.onjava.com/pub/a/onjava/2005/08/03/drools.html?page=7" target="_blank">http://www.onjava.com/pub/a/onjava/2005/08/03/drools.html?page=7</a>
<br>
<br>
I have written my rules as such:<br>
<br>
package org.drools.examples<br>
<br>
import org.drools.examples.StockOffer;<br>
<br>
rule PriceBelow100<br>
dialect "java" <br>
when<br>
s: StockOffer( stockPrice < 100
&& recommendPurchase == null )<br>
then<br>
modify( s ) {<br>
setRecommendPurchase(StockOffer.YES)<br>
}<br>
end<br>
<br>
rule NegativeStockPrice<br>
dialect "java" <br>
no-loop true<br>
when<br>
s: StockOffer( stockPrice < 0 )<br>
then<br>
modify( s ) {<br>
setRecommendPurchase(StockOffer.NO)<br>
}<br>
end <br>
<br>
rule DontBuyXYZStock<br>
dialect "java" <br>
no-loop true<br>
when<br>
s: StockOffer(stockName ==
"XYZ" && stockPrice < 10 )<br>
then<br>
modify( s ) {<br>
setRecommendPurchase(StockOffer.YES)<br>
}<br>
end <br>
<br>
rule BuyXYZStock<br>
dialect "java" <br>
no-loop true<br>
when<br>
s: StockOffer(stockName ==
"XYZ" && stockPrice > 10 )<br>
then<br>
modify( s ) {<br>
setRecommendPurchase(StockOffer.NO)<br>
}<br>
end <br>
<br>
<br>
<br>
My question is, why do I have to put no-loop on every rule (except for the
first). After the first time through the rules, it shouldn't be modifying to
where the rules would fire it again. Am I doing something wrong with how my
rules are written? My sample data is this:<br>
<br>
package org.drools.examples;<br>
<br>
import org.drools.examples.BusinessLayer;<br>
import org.drools.examples.StockOffer;<br>
<br>
import junit.framework.TestCase;<br>
<br>
/*<br>
* JUnit test for the business rules in the <br>
* application.<br>
* <br>
* This also acts a 'simulator' for the business <br>
* rules - allowing us to specify the inputs,<br>
* examine the outputs and see if they match our <br>
* expectations before letting the code loose in <br>
* the real world.<br>
*/<br>
public class BusinessRuleTest extends TestCase {<br>
/**<br>
* Tests the purchase of a stock<br>
*/<br>
public void testStockBuy() throws Exception {<br>
<br>
// Create a Stock with simulated values<br>
StockOffer testOffer = new StockOffer();<br>
testOffer.setStockName("MEGACORP");<br>
testOffer.setStockPrice(22);<br>
testOffer.setStockQuantity(1000);<br>
<br>
// Run the rules on it<br>
BusinessLayer.evaluateStockPurchase(testOffer);<br>
<br>
// Is it what we expected?<br>
assertTrue(testOffer.getRecommendPurchase() != null);<br>
<br>
assertTrue("YES".equals(testOffer.getRecommendPurchase()));<br>
}<br>
<br>
/**<br>
* Tests the purchase of a stock makes sure the system
will not accept<br>
* negative numbers.<br>
*/<br>
public void testNegativeStockBuy() throws Exception {<br>
<br>
// Create a Stock with our simulated
values<br>
StockOffer testOffer = new StockOffer();<br>
testOffer.setStockName("MEGACORP");<br>
testOffer.setStockPrice(-22);<br>
testOffer.setStockQuantity(1000);<br>
<br>
// Run the rules on it<br>
BusinessLayer.evaluateStockPurchase(testOffer);<br>
<br>
// Is it what we expected?<br>
assertTrue("NO".equals(testOffer.getRecommendPurchase()));<br>
}<br>
<br>
/**<br>
* Makes sure the system will buy stocks of XYZ corp
only if it really cheap<br>
*/<br>
public void testXYZStockBuy() throws Exception {<br>
<br>
// Create a Stock with our simulated
values<br>
StockOffer testOfferLow = new
StockOffer();<br>
StockOffer testOfferHigh = new
StockOffer();<br>
<br>
testOfferLow.setStockName("XYZ");<br>
testOfferLow.setStockPrice(9);<br>
testOfferLow.setStockQuantity(1000);<br>
<br>
testOfferHigh.setStockName("XYZ");<br>
testOfferHigh.setStockPrice(11);<br>
testOfferHigh.setStockQuantity(1000);<br>
<br>
// Run the rules on it and test<br>
BusinessLayer.evaluateStockPurchase(testOfferLow);<br>
assertTrue("YES".equals(testOfferLow.getRecommendPurchase()));<br>
<br>
BusinessLayer.evaluateStockPurchase(testOfferHigh);<br>
assertTrue("NO".equals(testOfferHigh.getRecommendPurchase()));<br>
}<br>
}<br>
<br>
<br>
I can post up all the code if this isn't enough to answer the question.<br>
<br>
Thanks!</p>
</div></div></div>
</div>
<br>_______________________________________________<br>
rules-users mailing list<br>
<a href="mailto:rules-users@lists.jboss.org">rules-users@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-users" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-users</a><br>
<br></blockquote></div><br>