<br> Don't tell anyone, but I was a naughty boy yesterday... I was in the middle of a huge change and could not commit stuff because I was waiting for a fix from someone else, and then I decided to use the time and sneaked in the fix for this problem with the code I was committing. I will still create the JIRA for documentation purposes, but the fix is in there... in case you want to give a try.<br>
<br> Regarding agenda-groups, you should not do that. I know the legacy API does not prevent you from doing it, but the results are unpredictable. The compiled model is supposed to be immutable. As we move away from the legacy API, this will not be allowed anymore.<br>
<br> []s<br> Edson<br><br><div class="gmail_quote">2009/2/25 Guy <span dir="ltr"><<a href="mailto:guyt1122@aim.com">guyt1122@aim.com</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">Edson Tirelli <tirelli <at> <a href="http://post.com" target="_blank">post.com</a>> writes:<br>
<br>
><br>
><br>
> Well found! Thanks for reporting. I will fix and let you know. <br>
</div>Edson2009/2/23 <guyt1122 <at> <a href="http://aim.com" target="_blank">aim.com</a>><br>
<div><div></div><div class="Wj3C7c">> Hi,<br>
><br>
><br>
> I'm using Drools 5.0M5 and Web Guided decision tables. What I want to be able<br>
to do is to create several decision tables under one package and then using an<br>
Agenda filter and firelimit option to fire one rule from a single decision table<br>
that I'm filtering.<br>
> What I did to try and accomplish this is the following. I notice that each<br>
row in the decision table has a rule name that matches the following format:<br>
"Row 1 DecisionTableName", "Row 2 DecisionTableName" ... "Row N<br>
DecisionTableName", so I create a RuleNameEndsWithAgendaFilter agenda filter to<br>
only accept rules that ends with "DecisionTableName". Then I call on the<br>
StatefulSession.fireAllRules(AgendaFilter, fireLimit) with my agenda filter and<br>
a firelimit of 1.<br>
> What I'm noticing is some inconsistent behavior were the logic would work<br>
sometimes and not other times. It seems to always works if there is a single<br>
decision table under the package. After debuging the<br>
StatefuleSession.fireAllRules(AgendaFilter, firelimit), I tracked down the issue<br>
to the way the firelimit count updated in the<br>
"DefaultAgenda.fireAllRules(AgendaFilter, fireLimit)" and with the<br>
"DefaultAgenda.fireNextItem(AgendaFilter)".<br>
> I may have misunderstood what the firelimit meant but it seems like the while<br>
loop in the fireAllRules always decrements the firelimit count regardless if the<br>
DefaultAgenda.fireNextItem(AgendaFilter) calls the fireActivation method or the<br>
fireActivationCancelled method. I would perfer the firelimit count to only get<br>
decremented if the fireNextItem results in a fireActivation method call and I<br>
think the logic will work for my scenario. Looking at the documenation, it look<br>
like the logic is geared towards focusing agenda groups, but I do not want to<br>
have maintain a agenda group column on my decision tables. I want each decision<br>
table to be an agenda group automagically.<br>
> I have included the following code showing the firelimit is always updated in<br>
the while loop below:<br>
> public int fireAllRules(AgendaFilter agendaFilter,<br>
> int fireLimit) {<br>
> this.halt.set( false );<br>
> int fireCount = 0;<br>
> while ( continueFiring( fireLimit ) && fireNextItem( agendaFilter ) ) {<br>
> fireCount++;<br>
> fireLimit = updateFireLimit( fireLimit );<br>
> this.workingMemory.executeQueuedActions();<br>
> }<br>
> if ( this.focusStack.size() == 1 && getMainAgendaGroup().isEmpty() ) {<br>
> // the root MAIN agenda group is empty, reset active to false, so<br>
it can receive more activations.<br>
> getMainAgendaGroup().setActive( false );<br>
> }<br>
> return fireCount;<br>
> }<br>
><br>
><br>
> Thanks,<br>
><br>
><br>
> Guy<br>
><br>
</div></div>> _______________________________________________<br>
> rules-users mailing listrules-users <at><br>
lists.jboss.orghttps://<a href="http://lists.jboss.org/mailman/listinfo/rules-users" target="_blank">lists.jboss.org/mailman/listinfo/rules-users</a><br>
<div class="Ih2E3d">><br>
><br>
> -- Edson Tirelli JBoss Drools Core Development JBoss, a division of Red<br>
</div>Hat <at> <a href="http://www.jboss.com" target="_blank">www.jboss.com</a><br>
><br>
><br>
> _______________________________________________<br>
> rules-users mailing list<br>
> rules-users <at> <a href="http://lists.jboss.org" target="_blank">lists.jboss.org</a><br>
<div class="Ih2E3d">> <a href="https://lists.jboss.org/mailman/listinfo/rules-users" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-users</a><br>
><br>
<br>
</div>Hi Edson,<br>
<br>
Thanks for your reply. Will you create a Jira ticket for this issue?<br>
<br>
Also, I found a work around for my scenario let me know if it is advisable to<br>
update Rule at runtime. I'm iterating overall of the rules in the packages and<br>
setting the agenda group name to the rule name, sans the "Row N". Then before<br>
firingAllRules, focus the agenda group that matches the decision table I want to<br>
evaluate.<br>
<br>
Code:<br>
<br>
// Get the rulebase<br>
RuleBase ruleBase = ruleAgent.getRuleBase();<br>
<br>
// Iterate over package and rules to update the agenda group name<br>
for(Package package : ruleBase.getPackages()) {<br>
int total = package.getRules().length();<br>
for (Rule rule : package.getRules()) {<br>
rule.setAgendaGroup(parseRuleName(rule.getName()));<br>
rule.setSalience(new SalienceInteger((int) ((total - rule.getLoadOrder())<br>
+ 1));<br>
}<br>
}<br>
<br>
// Create the new stateful session<br>
StatefulSession statefulSession = ruleBase.newStatefulSession();<br>
try {<br>
// Insert the facts.<br>
statefulSession.insert(fact);<br>
// Focus the appropriate agenda group...<br>
statefulSession.focus(theDecisionTableName);<br>
// Fire the rules with agenda filter and firelimit.<br>
statefulSession.fireAllRules(new<br>
RuleNameEndsWithAgendaFilter(theDecisionTableName, true), 1);<br>
} finally {<br>
// Dispose of the session when done.<br>
statefulSession.dispose();<br>
}<br>
<br>
Thanks,<br>
Guy<br>
<div><div></div><div class="Wj3C7c"><br>
<br>
<br>
_______________________________________________<br>
rules-users mailing list<br>
<a href="mailto:rules-users@lists.jboss.org">rules-users@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-users" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-users</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br> Edson Tirelli<br> JBoss Drools Core Development<br> JBoss, a division of Red Hat @ <a href="http://www.jboss.com">www.jboss.com</a><br>