<br><br> In this case, I think Paul's initial analysis is pertinent. Unless I am missing something obvious, the order of the facts may change the order in which the activations are executed, but not the number of executions. The end result should be the same with the same number of Win facts in the working memory.<br>
<br> We need to investigate if that is still happening in latest trunk.<br><br> []s<br> Edson<br><br><div class="gmail_quote">2009/4/16 Paul Fodor <span dir="ltr"><<a href="mailto:paul.i.fodor@gmail.com">paul.i.fodor@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="gmail_quote"><div class="im">On Thu, Apr 16, 2009 at 1:18 PM, Greg Barton <span dir="ltr"><<a href="mailto:greg_barton@yahoo.com" target="_blank">greg_barton@yahoo.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0px 0px 0px 0.8ex; padding-left: 1ex;"><br>This is not a problem with negation. I don't think you understand rule conflict resolution.<br>
<br>
Here's your rule:<br>
<div><br>rule "direct"<br>when<br> m : Move(x : first, y : second)<br> not Win(first == y)<br>then<br> insert(new Win(m.getFirst()));<br>end<br><br></div>This rule, regardles of whether it uses negation, will be affected by fact insertion order. This is because the first condition will match on any Move in working memory. When all of the potential firings of this rule are put on the agenda, which will initially be one for each Move in working memory, one must be selected to fire. The order of fact insertion (recency) is one of the ways Drools resolves this by default.</blockquote>
<div> </div>
</div><div>Thank you. I see. </div><div class="im">
<div> </div>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0px 0px 0px 0.8ex; padding-left: 1ex;">If you don't want that behavior you can change it by using a different conflict resolver instance. See classes in the package org.drools.conflict:<br>
<br><a href="https://hudson.jboss.org/hudson/job/drools/lastSuccessfulBuild/artifact/trunk/target/javadocs/unstable/drools-core/org/drools/conflict/package-summary.html" target="_blank">https://hudson.jboss.org/hudson/job/drools/lastSuccessfulBuild/artifact/trunk/target/javadocs/unstable/drools-core/org/drools/conflict/package-summary.html</a></blockquote>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0px 0px 0px 0.8ex; padding-left: 1ex;">Or define your own.</blockquote>
<div> </div>
</div><div>That is very dificult task. The win-nowin test was just an example of use of the default negation. My requirement covers stratified or non-stratified logic programs, and not one example in particular. </div>
<div>I don't really think that it is possible to implement a general "rule conflict resolution" resolver for default negation. This is hard in production rule systems.</div>
<div> </div><font color="#888888">
<div>Paul.</div></font><div><div></div><div class="h5">
<div> </div>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0px 0px 0px 0.8ex; padding-left: 1ex;">You can install a new one by calling either of these methods on your RuleBaseConfiguration:<br>
<br>setProperty("drools.conflictResolver", <resolver class name>)<br>
<br>or<br><br>setConflictResolver(<an instance of ConflictResolver>)<br><br>--- On Thu, 4/16/09, Paul Fodor <<a href="mailto:paul.i.fodor@gmail.com" target="_blank">paul.i.fodor@gmail.com</a>> wrote:<br><br>> From: Paul Fodor <<a href="mailto:paul.i.fodor@gmail.com" target="_blank">paul.i.fodor@gmail.com</a>><br>
> Subject: [rules-users] Negation semantics in Drools<br>> To: "Rules Users List" <<a href="mailto:rules-users@lists.jboss.org" target="_blank">rules-users@lists.jboss.org</a>><br>> Date: Thursday, April 16, 2009, 10:43 AM<br>
<div>
<div></div>
<div>> Dear Sir,<br>><br>> I found a problem with negation in Drools when changing the<br>> order of the<br>> facts in the database also changes the final model.<br>> Consider the classic win-nowin problem encoded in Drools as<br>
> follows:<br>><br>> win.drl:<br>><br>> package tests;<br>> import tests.Test.Win;<br>> import tests.Test.Move;<br>> rule "direct"<br>> when<br>> m : Move(x : first, y : second)<br>
> not Win(first == y)<br>> then<br>> insert(new Win(m.getFirst()));<br>> end<br>><br>> With two moves in the database: move(1,2) and move(2,3),<br>> for one order of the facts in the input file we get one<br>
> result: win(2),<br>> while for the other order (i.e., move(2,3) and move(1,2))<br>> we get 2 results:<br>> win(1) and win(2).<br>><br>> For win_upper1_drools.drools:<br>> > java tests.Test win_upper1_drools.drools win.drl<br>
> result<br>> reading rulefile: win.drl ...<br>> reading datafile: win_upper1_drools.drools ...<br>> computing cputime: 0.0<br>> computing walltime: 0.0030<br>> Derived facts in memory:move(1, 2).<br>> win(2).<br>
> move(2, 3).<br>> 3<br>><br>> For win_upper2_drools.drools:<br>> > java tests.Test win_upper2_drools.drools win.drl<br>> result<br>> reading rulefile: win.drl ...<br>> reading datafile: win_upper2_drools.drools ...<br>
> computing cputime: 0.0<br>> computing walltime: 0.0040<br>> Derived facts in memory:win(1).<br>> win(2).<br>> move(1, 2).<br>> move(2, 3).<br>> 4<br>><br>> I attached all the sources used in these tests in the<br>
> email. This example is<br>> locally stratified. I am using the latest released version<br>> of Drools.<br>><br>> Regards,<br>> Paul Fodor<br>><br>> win.drl:<br>><br>> package tests;<br>> import tests.Test.Win;<br>
> import tests.Test.Move;<br>> rule "direct"<br>> when<br>> m : Move(x : first, y : second)<br>> not Win(first == y)<br>> then<br>> insert(new Win(m.getFirst()));<br>> end<br>
><br>><br>> win_upper1_drools.drools:<br>><br>> move<br>> 1<br>> 2<br>> move<br>> 2<br>> 3<br>><br>> win_upper2_drools.drools:<br>><br>> move<br>> 2<br>> 3<br>> move<br>
> 1<br>
> 2<br>><br>> Test.java:<br>><br>> package tests;<br>> import java.io.*;<br>> import java.io.InputStreamReader;<br>> import org.drools.RuleBase;<br>> import org.drools.RuleBaseFactory;<br>> import org.drools.StatefulSession;<br>
> import org.drools.compiler.PackageBuilder;<br>> import org.drools.FactHandle;<br>> import java.util.Iterator;<br>> import java.lang.management.ManagementFactory;<br>> import java.lang.management.ThreadMXBean;<br>
> public class Test {<br>> public static void main (String args[]) {<br>> if (args.length < 3) {<br>> usage();<br>> }<br>> long starttime_cpu, endtime_cpu, starttime_sys,<br>> endtime_sys;<br>
> double cputime, walltime;<br>> ThreadMXBean tb_cpu = ManagementFactory.getThreadMXBean();<br>> // create rulebase<br>> try {<br>> FileWriter output = new FileWriter(args[2]);<br>> BufferedWriter bufWrite = new BufferedWriter(output);<br>
> bufWrite.write(args[0] + "\n");<br>> bufWrite.flush();<br>> System.out.println("reading rulefile: " +<br>> args[1] + " ...");<br>> Reader source = new<br>
> InputStreamReader(Test.class.getResourceAsStream(args[1]));<br>> final PackageBuilder builder = new PackageBuilder();<br>> builder.addPackageFromDrl(source);<br>> if (builder.hasErrors()) {<br>
> System.out.println(builder.getErrors().toString());<br>> System.exit(0);<br>> }<br>> final RuleBase ruleBase =<br>> RuleBaseFactory.newRuleBase();<br>> ruleBase.addPackage(builder.getPackage());<br>
> final StatefulSession session =<br>> ruleBase.newStatefulSession();<br>> // loading datafile<br>> System.out.println("reading datafile: " +<br>> args[0] + " ...");<br>> FileReader input = new FileReader(args[0]);<br>
> starttime_sys = System.nanoTime();<br>> starttime_cpu = tb_cpu.getCurrentThreadCpuTime();<br>> BufferedReader bufRead = new BufferedReader(input);<br>> String first, second, line = bufRead.readLine();<br>
> while (line != null) {<br>> if (line.compareTo("move") == 0) {<br>> first = bufRead.readLine();<br>> second = bufRead.readLine();<br>> session.insert(new Move(first, second));<br>
> }<br>> else if (line.compareTo("par") == 0) {<br>> first = bufRead.readLine();<br>> second = bufRead.readLine();<br>> session.insert(new ClassPar(first, second));<br>> }<br>
> else if (line.compareTo("sib") == 0) {<br>> first = bufRead.readLine();<br>> second = bufRead.readLine();<br>> session.insert(new ClassSib(first, second));<br>> }<br>> line = bufRead.readLine();<br>
> }<br>> endtime_cpu = tb_cpu.getCurrentThreadCpuTime();<br>> endtime_sys = System.nanoTime();<br>> cputime = (endtime_cpu - starttime_cpu) * 1e-9;<br>> cputime = Math.round(cputime * 1000) * 1e-3;<br>
> walltime = (endtime_sys - starttime_sys) * 1e-9;<br>> walltime = Math.round(walltime * 1000) * 1e-3;<br>> bufWrite.write("loading cputime: " + cputime<br>> + "\n");<br>> bufWrite.write("loading walltime: " +<br>
> walltime + "\n");<br>> bufWrite.flush();<br>> System.out.println("loading cputime: " +<br>> cputime);<br>> System.out.println("loading walltime: " +<br>> walltime);<br>
> /*<br>> System.out.print("Facts in memory:");<br>> long count = 0;<br>> for (Iterator it = session.iterateFactHandles();<br>> it.hasNext(); ) {<br>> FactHandle factHandle = (FactHandle) it.next();<br>
> count ++;<br>> //System.out.println(session.getObject(factHandle));<br>> }<br>> System.out.println(count);<br>> */<br>> // computing<br>> System.out.println("calculating ...");<br>
> starttime_sys = System.nanoTime();<br>> starttime_cpu = tb_cpu.getCurrentThreadCpuTime();<br>> session.fireAllRules();<br>> endtime_cpu = tb_cpu.getCurrentThreadCpuTime();<br>> endtime_sys = System.nanoTime();<br>
> cputime = (endtime_cpu - starttime_cpu) * 1e-9;<br>> cputime = Math.round(cputime * 1000) * 1e-3;<br>> walltime = (endtime_sys - starttime_sys) * 1e-9;<br>> walltime = Math.round(walltime * 1000) * 1e-3;<br>
> bufWrite.write("computing cputime: " +<br>> cputime + "\n");<br>> bufWrite.write("computing walltime: " +<br>> walltime + "\n");<br>> bufWrite.flush();<br>
> System.out.println("computing cputime: " +<br>> cputime);<br>> System.out.println("computing walltime: " +<br>> walltime);<br>> System.out.print("Derived facts in<br>
> memory:");<br>> long count1 = 0;<br>> for (Iterator it = session.iterateFactHandles();<br>> it.hasNext(); ) {<br>> FactHandle factHandle = (FactHandle) it.next();<br>> count1 ++;<br>
> System.out.println(session.getObject(factHandle));<br>> }<br>> System.out.println(count1);<br>> bufWrite.close();<br>> session.dispose();<br>> } catch (Exception e) {<br>> System.out.println("Exception encountered when<br>
> computing:");<br>> System.out.println(e);<br>> System.exit(0);<br>> }<br>> }<br>> static void usage() {<br>> System.out.println("usage:");<br>> System.out.println("java Test <data_file><br>
> <rule_file> <result_file>");<br>> System.exit(0);<br>> }<br>> public static class General {<br>> private String first;<br>> private String second;<br>> public General() {}<br>
> public General(String firstIn, String secondIn) {<br>> this.first = firstIn;<br>> this.second = secondIn;<br>> }<br>> public String getFirst() {<br>> return this.first;<br>> }<br>
> public String getSecond() {<br>> return this.second;<br>> }<br>> }<br>> public static class Move extends General {<br>> public Move() {<br>> super();<br>> }<br>> public Move(String firstIn, String secondIn) {<br>
> super(firstIn, secondIn);<br>> }<br>> public String toString() {<br>> return "move(" + this.getFirst() + ",<br>> " + this.getSecond() + ").";<br>> }<br>> }<br>
> public static class Win {<br>> private String first;<br>> public Win() {}<br>> public Win(String firstIn) {<br>> this.first = firstIn;<br>> }<br>> public String getFirst() {<br>> return this.first;<br>
> }<br>> public String toString() {<br>> return "win(" + this.getFirst() +<br>> ").";<br>> }<br>> }<br>> }<br></div></div>> _______________________________________________<br>
> rules-users mailing list<br>> <a href="mailto:rules-users@lists.jboss.org" target="_blank">rules-users@lists.jboss.org</a><br>> <a href="https://lists.jboss.org/mailman/listinfo/rules-users" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-users</a><br>
<br><br><br>_______________________________________________<br>rules-users mailing list<br><a href="mailto:rules-users@lists.jboss.org" target="_blank">rules-users@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/rules-users" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-users</a><br>
</blockquote></div></div></div><br>
<br>_______________________________________________<br>
rules-users mailing list<br>
<a href="mailto:rules-users@lists.jboss.org">rules-users@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-users" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-users</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br> Edson Tirelli<br> JBoss Drools Core Development<br> JBoss, a division of Red Hat @ <a href="http://www.jboss.com">www.jboss.com</a><br>