<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#ffffff" text="#000000">
    This was fixed as part of <a class="moz-txt-link-freetext" href="https://jira.jboss.org/browse/GUVNOR-606">https://jira.jboss.org/browse/GUVNOR-606</a>
    couple of weeks ago.<br>
    <br>
    Thanks.<br>
    Tihomir<br>
    <br>
    On 9/23/10 12:13 PM, Scott Mayne wrote:
    <blockquote cite="mid:486255.91333.qm@web802.biz.mail.mud.yahoo.com"
      type="cite">
      <table border="0" cellpadding="0" cellspacing="0">
        <tbody>
          <tr>
            <td style="font: inherit;" valign="top">OK after jumping
              through some hoops to get development mode working, I
              found the problem. Class
              org.drools.guvnor.client.modeldriven.ui.ActionValueEditor
              has a method showTypeChoice(Widget w) which has a variable
              (FactPattern factPattern) used in an if-clause without a
              null check. The variable was coming back null and blowing
              up with a NPE, hence the icon didn't work.<br>
              <br>
              I noticed things are uneven in the code regarding
              null-checks by callers of the function
              org.drools.ide.common.client.modeldriven.brl.RuleModel.getBoundFact(final
              String var) - might be something to look at.<br>
              <br>
              --- On <b>Fri, 9/17/10, Scott Mayne <i><a class="moz-txt-link-rfc2396E" href="mailto:smayne@webfinancialsolutions.com">&lt;smayne@webfinancialsolutions.com&gt;</a></i></b>
              wrote:<br>
              <blockquote style="border-left: 2px solid rgb(16, 16,
                255); margin-left: 5px; padding-left: 5px;"><br>
                From: Scott Mayne
                <a class="moz-txt-link-rfc2396E" href="mailto:smayne@webfinancialsolutions.com">&lt;smayne@webfinancialsolutions.com&gt;</a><br>
                Subject: [rules-users] Guvnor 5.1: Pencil icon not
                clickable in BRL editor‏<br>
                To: <a class="moz-txt-link-abbreviated" href="mailto:rules-users@lists.jboss.org">rules-users@lists.jboss.org</a><br>
                Date: Friday, September 17, 2010, 1:47 PM<br>
                <br>
                <div id="yiv2012538971">
                  <table border="0" cellpadding="0" cellspacing="0">
                    <tbody>
                      <tr>
                        <td style="font: inherit;" valign="top">
                          <div id="yiv2012538971ecxyiv1469138571">
                            <table class="yiv2012538971ecxyiv1469138571"
id="yiv2012538971ecxyiv1469138571bodyDrftID" border="0" cellpadding="0"
                              cellspacing="0">
                              <tbody>
                                <tr>
                                  <td
                                    id="yiv2012538971ecxyiv1469138571drftMsgContent"
                                    style="font-size: 10pt; font-family:
                                    arial;">
                                    <div
                                      id="yiv2012538971ecxyiv1469138571yiv1280050447">
                                      <table
                                        class="yiv2012538971ecxyiv1469138571yiv1280050447"
id="yiv2012538971ecxyiv1469138571yiv1280050447bodyDrftID" border="0"
                                        cellpadding="0" cellspacing="0">
                                        <tbody>
                                          <tr>
                                            <td
                                              id="yiv2012538971ecxyiv1469138571yiv1280050447drftMsgContent"
                                              style="font-size: 10pt;
                                              font-family: arial;">
                                              <div
                                                id="yiv2012538971ecxyiv1469138571yiv1280050447yiv738922534">
                                                <table
                                                  class="yiv2012538971ecxyiv1469138571yiv1280050447yiv738922534"
id="yiv2012538971ecxyiv1469138571yiv1280050447yiv738922534bodyDrftID"
                                                  style="width: 509px;
                                                  height: 592px;"
                                                  border="0"
                                                  cellpadding="0"
                                                  cellspacing="0">
                                                  <tbody>
                                                    <tr>
                                                      <td
id="yiv2012538971ecxyiv1469138571yiv1280050447yiv738922534drftMsgContent"
                                                        style="font-size:
                                                        10pt;
                                                        font-family:
                                                        arial;">Hi all,<br>
                                                        <br>
                                                        I'm reading Paul
                                                        Browne's "JBoss
                                                        Drools Business
                                                        Rules" and in
                                                        Ch. 5 we make a
                                                        BRL in the
                                                        guided editor.
                                                        We're using a
                                                        simple fact
                                                        model with a
                                                        single class
                                                        (Sales) which
                                                        has (among
                                                        others) a field
                                                        "sales", type
                                                        long. The book
                                                        uses an earlier
                                                        version of
                                                        Guvnor so things
                                                        look a little
                                                        different but
                                                        everything's
                                                        worked so far,
                                                        until I use the
                                                        editor to make a
                                                        rule that looks
                                                        like this in
                                                        "view source":<br>
                                                        <br>
                                                        rule
                                                        "SalesDiscount"<br>
                                                          dialect "mvel"<br>
                                                          when<br>
                                                            mySales :
                                                        Sales(
                                                        salesValue :
                                                        sales &gt;=
                                                        "100" )<br>
                                                          then<br>
                                                           
                                                        mySales.setSales(
                                                        salesValue-10 );<br>
                                                            update(
                                                        mySales );<br>
                                                        end<br>
                                                        <br>
                                                        When I try it
                                                        out, I get this
                                                        line in the THEN
                                                        section<br>
                                                        <br>
                                                        "1.  Modify
                                                        value of Sales
                                                        [mySales]            
                                                        sales [pencil
                                                        icon] [remove
                                                        icon]<br>
                                                        <br>
                                                        but neither
                                                        "sales" nor the
                                                        pencil icon is
                                                        clickable, so I
                                                        can't enter what
                                                        it should change
                                                        to. When click
                                                        view source
                                                        using what I
                                                        could do I get:<br>
                                                        <br>
                                                        rule
                                                        "SalesDiscount"<br>
                                                          dialect "mvel"<br>
                                                          when<br>
                                                            mySales :
                                                        Sales(
                                                        salesValue :
                                                        sales &gt;=
                                                        "100" )<br>
                                                          then<br>
                                                           
                                                        mySales.setSales(
                                                        );<br>
                                                           
                                                        mySales.setWait(
                                                        );<br>
                                                            update(
                                                        mySales );<br>
                                                        end<br>
                                                        <br>
                                                        [I added the
                                                        "wait" because
                                                        the modify field
                                                        dropdown has
                                                        this as an
                                                        option but it's
                                                        not in the Java
                                                        class and I'm
                                                        not sure where
                                                        it came from.]<br>
                                                        <br>
                                                        Can anyone shed
                                                        light on this
                                                        behavior? I'm
                                                        using the latest
                                                        version of
                                                        Firefox,
                                                        compiling with
                                                        GWT/building my
                                                        own EAR (though
                                                        I haven't done
                                                        any code
                                                        changes) using
                                                        RAD 7.5.5.1
                                                        (based on
                                                        Eclipse 3.4),
                                                        and am running
                                                        Guvnor on
                                                        WebSphere.<br>
                                                      </td>
                                                    </tr>
                                                  </tbody>
                                                </table>
                                              </div>
                                            </td>
                                          </tr>
                                        </tbody>
                                      </table>
                                    </div>
                                  </td>
                                </tr>
                              </tbody>
                            </table>
                          </div>
                        </td>
                      </tr>
                    </tbody>
                  </table>
                </div>
                <br>
                -----Inline Attachment Follows-----<br>
                <br>
                <div class="plainMail">_______________________________________________<br>
                  rules-users mailing list<br>
                  <a moz-do-not-send="true"
                    ymailto="mailto:rules-users@lists.jboss.org"
                    href="/mc/compose?to=rules-users@lists.jboss.org">rules-users@lists.jboss.org</a><br>
                  <a moz-do-not-send="true"
                    href="https://lists.jboss.org/mailman/listinfo/rules-users"
                    target="_blank">https://lists.jboss.org/mailman/listinfo/rules-users</a><br>
                </div>
              </blockquote>
            </td>
          </tr>
        </tbody>
      </table>
      <pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
rules-users mailing list
<a class="moz-txt-link-abbreviated" href="mailto:rules-users@lists.jboss.org">rules-users@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/rules-users">https://lists.jboss.org/mailman/listinfo/rules-users</a>
</pre>
    </blockquote>
    <br>
  </body>
</html>