Ooh, it seems Eclipse outwitted me once again. But I think I made it on the 2nd try...<br>Sorry<br>W<br><br>PS: <br>(1) A decision on the matter of DSL variables would be appreciated. I'm currently<br>developing a non-trivial DSL, and learning a lot about what's needed for a<br>
<i>real world </i>application. Most importantly, some means of structuring the<br>DSL definition, so that they can be applied distinctively to specific groups of<br>rules. This reduces the risk of "ricochets" if you know what I mean. <br>
<br>I've thought about proposing an entirely new approach, based on DRL syntactic<br>entities, i.e., the expansion of a DSL phrase must be a "medium level" non-terminal<br>of the DRL language. But this certainly restricts phrase parameters to terminals.<br>
If it's too sophisticated, you end up with a parser/compiler almost as nasty as ANTLR3.<br><br>(2) I haven't forgotten the spreadsheet fixes. There's another relic I found: some of<br>the column keywords have single letter alternatives (e.g. "U" for "no-loop", "X" for<br>
"activation-group"). Should I retain them - they are NOT documented in Expert.<br><br>Should I add timer(int:)? Duration is deprecated, I'll leave this in but it ought to<br>be marked clearly as such in the documentation, at least.<br>
<br>Please advise - I can live with everything - non of this is important for my company,<br>but I want to get the fixes and additions out of my thinning hair ;-)<br><br> <br><br><br><br><div class="gmail_quote">On 11 December 2010 00:00, Mark Proctor <span dir="ltr"><<a href="mailto:mproctor@codehaus.org">mproctor@codehaus.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="im">On 10/12/2010 08:44, Wolfgang Laun wrote:<br>
> Done. There are two FIXME-tests at the end, one for timer() + not; the other one<br>
> demonstrating that drools.halt() from a rule with a timer() doesn't<br>
> terminate the<br>
> session - it also keeps firing. Notice that even with no timer() on<br>
> the "halt" rule<br>
> but with another rule having a periodic timer "overrules" the drools.halt().<br>
</div>Did you commit? as I'm not seeing anything in trunk.<br>
<a href="http://fisheye.jboss.org/changelog/JBossRules/trunk/drools-compiler/src/test/java/org/drools/integrationtests/TimerAndCalendarTest.java?max=30&view=all" target="_blank">http://fisheye.jboss.org/changelog/JBossRules/trunk/drools-compiler/src/test/java/org/drools/integrationtests/TimerAndCalendarTest.java?max=30&view=all</a><br>
<font color="#888888"><br>
Mark<br>
</font><div><div></div><div class="h5">> -W<br>
><br>
><br>
> 2010/12/10 Mark Proctor<<a href="mailto:mproctor@codehaus.org">mproctor@codehaus.org</a>>:<br>
>> On 09/12/2010 14:50, Wolfgang Laun wrote:<br>
>><br>
>> I can confirm that the timer rule continues to fire<br>
>> - if the condition contains a not CE<br>
>> - even after the not CE should return false<br>
>><br>
>> Repeating timer firing stops for "positive" CEs turning to false.<br>
>><br>
>> sounds like a bug :(<br>
>><br>
>> Wolfgang, could you commit your test to TimerAndCalendarTest. Take a look at<br>
>> the tests there and follow a similar format, generally when there is only<br>
>> one or two small rules we prefer to inline the text rather than externalise<br>
>> it in a file, see testIntervalTimer<br>
>><br>
>> So that it doesn't break hudson add FIXME to the start of the rule name,<br>
>> such as<br>
>> FIXME_testTimerWithNot<br>
>><br>
>> Ideally open a jira and when you commit the code put the jira id in the<br>
>> commit messgae along with the jira title and a message something like<br>
>> "adding failing unit test"<br>
>><br>
>> Thanks<br>
>><br>
>> Mark<br>
>><br>
>> -W<br>
>><br>
>><br>
>> On 9 December 2010 15:06, OlliSee<<a href="mailto:o.roess@seeburger.de">o.roess@seeburger.de</a>> wrote:<br>
>>> Thanks,<br>
>>> unfortunately not working, either.<br>
>>><br>
>>> Maybe it will help, if I describe the scenario more detailed.<br>
>>><br>
>>> I have three A facts inserted at the beginning.<br>
>>> Then the rule fires the first time after 5 seconds for every A fact and<br>
>>> inserts the B events.<br>
>>> Then I retract ONE of the B events, but the rule keeps firing for EVERY A<br>
>>> fact, despite the B events remaining in the WorkingMemory.<br>
>>> --<br>
>>> View this message in context:<br>
>>> <a href="http://drools-java-rules-engine.46999.n3.nabble.com/timer-and-duration-tp2057403p2057831.html" target="_blank">http://drools-java-rules-engine.46999.n3.nabble.com/timer-and-duration-tp2057403p2057831.html</a><br>
>>> Sent from the Drools - User mailing list archive at Nabble.com.<br>
>>> _______________________________________________<br>
>>> rules-users mailing list<br>
>>> <a href="mailto:rules-users@lists.jboss.org">rules-users@lists.jboss.org</a><br>
>>> <a href="https://lists.jboss.org/mailman/listinfo/rules-users" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-users</a><br>
>><br>
>> _______________________________________________<br>
>> rules-users mailing list<br>
>> <a href="mailto:rules-users@lists.jboss.org">rules-users@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/rules-users" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-users</a><br>
>><br>
>><br>
>> _______________________________________________<br>
>> rules-users mailing list<br>
>> <a href="mailto:rules-users@lists.jboss.org">rules-users@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/rules-users" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-users</a><br>
>><br>
>><br>
> _______________________________________________<br>
> rules-users mailing list<br>
> <a href="mailto:rules-users@lists.jboss.org">rules-users@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/rules-users" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-users</a><br>
><br>
><br>
<br>
<br>
_______________________________________________<br>
rules-users mailing list<br>
<a href="mailto:rules-users@lists.jboss.org">rules-users@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-users" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-users</a><br>
</div></div></blockquote></div><br>