<div><br></div> Yes, but just to clarify: as it is now, we parse semantic blocks of code like RHS as a black box (chunk if you will) and then re-parse that with the appropriate dialect parser (like java). Same for expressions in the rule, that we chunk and delegate to MVEL. That is why, for instance, to write an expression in a pattern in need the ugly ( ):<div>
<br></div><div>Person( age == ( $someAge + 1 ) )</div><div><br></div><div> That also screws with our error handling capabilities. Example: as of today, in the eclipse editor, if you have a parsing error in the consequence, we show the error in the rule header instead of the proper line in the consequence.</div>
<div><br></div><div> The changes we are doing in the parser now means that we will be able to parse 100% of the content of the DRL file (no black boxes/chunking anymore) and with that improve error handling, code completion, improve syntax and allow us to do smarter static code analysis. Example of the results as of this morning:</div>
<div><br></div><div><meta http-equiv="content-type" content="text/html; charset=utf-8"><meta http-equiv="content-type" content="text/html; charset=utf-8"><span class="Apple-style-span" style="font-family: 'Bitstream Vera Sans Mono', Courier, monospace; font-size: 12px; line-height: 17px; white-space: pre; ">@name4( k1 = "a", </span></div>
<div><span class="Apple-style-span" style="font-family: 'Bitstream Vera Sans Mono', Courier, monospace; font-size: 12px; line-height: 17px; white-space: pre; "> formula = Math.max( 10 + 25, 22 ) % 2 + someVariable, </span></div>
<div><span class="Apple-style-span" style="font-family: 'Bitstream Vera Sans Mono', Courier, monospace; font-size: 12px; line-height: 17px; white-space: pre; "> array = { a, b, c } )</span><br><br></div><div>
Above example is for annotations, but the same will happen everywhere, including the LHS. See how "formula" uses a free form expression without any kind of clutter/delimiters/etc?</div><div><br></div><div><div class="gmail_quote">
Edson</div><div class="gmail_quote"><br></div><div class="gmail_quote"><br></div><div class="gmail_quote">2011/1/20 Greg Barton <span dir="ltr"><<a href="mailto:greg_barton@yahoo.com">greg_barton@yahoo.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">When you say "owning 100% of the language syntax" does that include the RHS? Just curious.<br>
<font color="#888888"><br>
GreG<br>
</font><div><div></div><div class="h5"><br>
On Jan 19, 2011, at 22:04, Edson Tirelli <<a href="mailto:ed.tirelli@gmail.com">ed.tirelli@gmail.com</a>> wrote:<br>
<br>
> As of Drools 5.1.1, drools looks at the expression in "from" as a<br>
> black box. Every time it is executed, drools creates a new fact handle<br>
> to wrap the result(s). Since the lock and no-loop features are based<br>
> on the fact handles, the sometimes undesired interaction occurs. We<br>
> may be able to improve this in drools 6, when we will have the engine<br>
> owning 100% of the language syntax, that will enable us to run better<br>
> expression analisys than we can do today.<br>
><br>
> Edson<br>
><br>
> Em quarta-feira, 19 de janeiro de 2011,<br>
> hyjshanghai<<a href="mailto:hyjshanghai@gmail.com">hyjshanghai@gmail.com</a>> escreveu:<br>
>><br>
>> You explanation is very reasonable:<br>
>> the engine assumes anything within $p may be changed by modify($p), although<br>
>> $p.address is not changed actually.<br>
>><br>
>> However, I tried these rules myself and both rules were fired. Why?<br>
>> According to the document, only one of the rules should fire; the other's<br>
>> activation should be cancelled because the engine assumes $p has changed,<br>
>> which may mismatch the other rule, right?.<br>
>><br>
>> The following are the output and my rules. The only difference between my<br>
>> rules and the document's is that my rules don't belong to any<br>
>> ruleflow-group.<br>
>><br>
>> ==== Program Output of Inserting a "new Person()" and Firing All Rules.<br>
>> BEGIN====<br>
>> Rule 'Apply discount' fired. Person: Person{name[Tom],<br>
>> address[Address{state[NC], city[Raleigh]}], region[null], discount[0.9]}<br>
>> Rule 'Assign to sales region 1' fired. Person: Person{name[Tom],<br>
>> address[Address{state[NC], city[Raleigh]}], region[sales region 1],<br>
>> discount[0.9]}<br>
>> ==== Program Output of Inserting a "new Person()" and Firing All Rules.<br>
>> END====<br>
>><br>
>> ==== The Rules I Tested. BEGIN ====<br>
>> package hello.rules<br>
>> import java.util.*<br>
>> import java.math.*<br>
>> import hello.model.Address;<br>
>> import hello.model.Person;<br>
>><br>
>> rule "Assign to sales region 1"<br>
>> lock-on-active true<br>
>> when<br>
>> $p : Person()<br>
>> $a : Address( state=="NC") from $p.address<br>
>> then<br>
>> modify ($p) { setRegion("sales region 1") }<br>
>> System.out.println("Rule 'Assign to sales region 1' fired. Person:<br>
>> "+$p);<br>
>> end<br>
>><br>
>> rule "Apply discount"<br>
>> lock-on-active true<br>
>> when<br>
>> $p : Person()<br>
>> $a : Address( city=="Raleigh") from $p.address<br>
>> then<br>
>> modify ($p) { setDiscount((float)0.9) }<br>
>> System.out.println("Rule 'Apply discount' fired. Person: "+$p);<br>
>> end<br>
>> ==== The Rules I Tested. END ====<br>
>><br>
>> ==== The Person and Address. BEGIN ====<br>
>> public class Person<br>
>> {<br>
>> private String name;<br>
>> private Address address;<br>
>> private String region;<br>
>> private float discount;<br>
>> public String getRegion() {<br>
>> return region;<br>
>> }<br>
>> public void setRegion(String region) {<br>
>> this.region = region;<br>
>> }<br>
>> public float getDiscount() {<br>
>> return discount;<br>
>> }<br>
>> public void setDiscount(float discount) {<br>
>> this.discount = discount;<br>
>> }<br>
>><br>
>> public String getName() {<br>
>> return name;<br>
>> }<br>
>> public void setName(String name) {<br>
>> <a href="http://this.name" target="_blank">this.name</a> = name;<br>
>> }<br>
>> public Address getAddress() {<br>
>> return address;<br>
>> }<br>
>> public void setAddress(Address address) {<br>
>> this.address = address;<br>
>> }<br>
>> @Override<br>
>> public String toString()<br>
>> {<br>
>> return String.format("Person{name[%s], address[%s], region[%s],<br>
>> discount[%s]}",<br>
>> name, address.toString(), region, discount);<br>
>> }<br>
>> }<br>
>><br>
>> public class Address<br>
>> {<br>
>> private String state;<br>
>> private String city;<br>
>> public String getState() {<br>
>> return state;<br>
>> }<br>
>> public void setState(String state) {<br>
>> this.state = state;<br>
>> }<br>
>> public String getCity() {<br>
>> return city;<br>
>> }<br>
>> public void setCity(String city) {<br>
>> this.city = city;<br>
>> }<br>
>><br>
>> @Override<br>
>> public String toString()<br>
>> {<br>
>> return String.format("Address{state[%s], city[%s]}", state, city);<br>
>> }<br>
>> }<br>
>> ==== The Person and Address END ====<br>
>> --<br>
>> View this message in context: <a href="http://drools-java-rules-engine.46999.n3.nabble.com/Why-Using-from-Always-Return-A-New-Fact-tp2286393p2292029.html" target="_blank">http://drools-java-rules-engine.46999.n3.nabble.com/Why-Using-from-Always-Return-A-New-Fact-tp2286393p2292029.html</a><br>
>> Sent from the Drools - User mailing list archive at Nabble.com.<br>
>> _______________________________________________<br>
>> rules-users mailing list<br>
>> <a href="mailto:rules-users@lists.jboss.org">rules-users@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/rules-users" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-users</a><br>
>><br>
><br>
> --<br>
> Edson Tirelli<br>
> JBoss Drools Core Development<br>
> JBoss by Red Hat @ <a href="http://www.jboss.com" target="_blank">www.jboss.com</a><br>
><br>
> _______________________________________________<br>
> rules-users mailing list<br>
> <a href="mailto:rules-users@lists.jboss.org">rules-users@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/rules-users" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-users</a><br>
<br>
_______________________________________________<br>
rules-users mailing list<br>
<a href="mailto:rules-users@lists.jboss.org">rules-users@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/rules-users" target="_blank">https://lists.jboss.org/mailman/listinfo/rules-users</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br> Edson Tirelli<br> JBoss Drools Core Development<br> JBoss by Red Hat @ <a href="http://www.jboss.com">www.jboss.com</a><br>
</div>