<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">I’ve just tried upgrading from Drools 5.3.0-CR1 from the beta and I’ve hit a regression.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">JBoss seems to have been down for most of today so I haven’t been able to raise a Jira for it.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">In our model we have Facts which contain fields of java.lang.class, we then have a rule which checks that they aren’t null.<o:p></o:p></p>
<p class="MsoNormal">Eg<o:p></o:p></p>
<p class="MsoNormal">Fact { Class<Object> classField}<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Rule “xyz”<o:p></o:p></p>
<p class="MsoNormal">When<o:p></o:p></p>
<p class="MsoNormal"> Fact(classField != null)<o:p></o:p></p>
<p class="MsoNormal">Then<o:p></o:p></p>
<p class="MsoNormal">…<o:p></o:p></p>
<p class="MsoNormal">End<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">This is giving the following exception<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Caused by: java.lang.ClassCastException: org.drools.base.field.ObjectFieldImpl cannot be cast to org.drools.base.field.ClassFieldImpl<o:p></o:p></p>
<p class="MsoNormal"> at org.drools.base.evaluators.EqualityEvaluatorsDefinition$ClassEqualEvaluator.evaluate(EqualityEvaluatorsDefinition.java:1772)<o:p></o:p></p>
<p class="MsoNormal"> at org.drools.rule.LiteralRestriction.isAllowed(LiteralRestriction.java:87)<o:p></o:p></p>
<p class="MsoNormal"> at org.drools.rule.LiteralConstraint.isAllowed(LiteralConstraint.java:109)<o:p></o:p></p>
<p class="MsoNormal"> at org.drools.reteoo.AlphaNode.assertObject(AlphaNode.java:130)<o:p></o:p></p>
<p class="MsoNormal"> at org.drools.reteoo.CompositeObjectSinkAdapter.doPropagateAssertObject(CompositeObjectSinkAdapter.java:451)<o:p></o:p></p>
<p class="MsoNormal"> at org.drools.reteoo.CompositeObjectSinkAdapter.propagateAssertObject(CompositeObjectSinkAdapter.java:369)<o:p></o:p></p>
<p class="MsoNormal"> at org.drools.reteoo.AlphaNode.assertObject(AlphaNode.java:134)<o:p></o:p></p>
<p class="MsoNormal"> at org.drools.reteoo.CompositeObjectSinkAdapter.doPropagateAssertObject(CompositeObjectSinkAdapter.java:451)<o:p></o:p></p>
<p class="MsoNormal"> at org.drools.reteoo.CompositeObjectSinkAdapter.propagateAssertObject(CompositeObjectSinkAdapter.java:379)<o:p></o:p></p>
<p class="MsoNormal"> at org.drools.reteoo.ObjectTypeNode.assertObject(ObjectTypeNode.java:204)<o:p></o:p></p>
<p class="MsoNormal"> at org.drools.reteoo.EntryPointNode.assertObject(EntryPointNode.java:244)<o:p></o:p></p>
<p class="MsoNormal"> at org.drools.common.NamedEntryPoint.insert(NamedEntryPoint.java:330)<o:p></o:p></p>
<p class="MsoNormal"> at org.drools.common.NamedEntryPoint.insert(NamedEntryPoint.java:291)<o:p></o:p></p>
<p class="MsoNormal"> at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:882)<o:p></o:p></p>
<p class="MsoNormal"> at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:180)<o:p></o:p></p>
<p class="MsoNormal"> ... 149 more<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Wrapping the classField != null within an eval appears to be a work around.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">This is in the suspect method:<o:p></o:p></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:10.0pt;font-family:Consolas;color:black">
</span><b><span style="font-size:10.0pt;font-family:Consolas;color:#7F0055">public</span></b><span style="font-size:10.0pt;font-family:Consolas;color:black">
</span><b><span style="font-size:10.0pt;font-family:Consolas;color:#7F0055">boolean</span></b><span style="font-size:10.0pt;font-family:Consolas;color:black"> evaluate(InternalWorkingMemory workingMemory,</span><span style="font-size:10.0pt;font-family:Consolas"><o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:10.0pt;font-family:Consolas;color:black">
</span><b><span style="font-size:10.0pt;font-family:Consolas;color:#7F0055">final</span></b><span style="font-size:10.0pt;font-family:Consolas;color:black"> InternalReadAccessor extractor,</span><span style="font-size:10.0pt;font-family:Consolas"><o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:10.0pt;font-family:Consolas;color:black">
</span><b><span style="font-size:10.0pt;font-family:Consolas;color:#7F0055">final</span></b><span style="font-size:10.0pt;font-family:Consolas;color:black"> Object object1,
</span><b><span style="font-size:10.0pt;font-family:Consolas;color:#7F0055">final</span></b><span style="font-size:10.0pt;font-family:Consolas;color:black"> FieldValue object2) {</span><span style="font-size:10.0pt;font-family:Consolas"><o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:10.0pt;font-family:Consolas;color:black"> Object value1 = extractor.getValue( workingMemory, object1 );</span><span style="font-size:10.0pt;font-family:Consolas"><o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:10.0pt;font-family:Consolas;color:black"> Object value2 = object2.getValue();</span><span style="font-size:10.0pt;font-family:Consolas"><o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:10.0pt;font-family:Consolas;color:black">
</span><b><span style="font-size:10.0pt;font-family:Consolas;color:#7F0055">if</span></b><span style="font-size:10.0pt;font-family:Consolas;color:black"> ( value2 ==
</span><b><span style="font-size:10.0pt;font-family:Consolas;color:#7F0055">null</span></b><span style="font-size:10.0pt;font-family:Consolas;color:black"> ) {</span><span style="font-size:10.0pt;font-family:Consolas"><o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:10.0pt;font-family:Consolas;color:black"> ClassFieldImpl classField = (ClassFieldImpl) object2;</span><span style="font-size:10.0pt;font-family:Consolas"><o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:10.0pt;font-family:Consolas;color:black"> value2 = classField.resolve( workingMemory );</span><span style="font-size:10.0pt;font-family:Consolas"><o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:10.0pt;font-family:Consolas;color:black"> }</span><span style="font-size:10.0pt;font-family:Consolas"><o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:10.0pt;font-family:Consolas;color:black">
</span><b><span style="font-size:10.0pt;font-family:Consolas;color:#7F0055">return</span></b><span style="font-size:10.0pt;font-family:Consolas;color:black">
</span><i><span style="font-size:10.0pt;font-family:Consolas;color:#0000C0">comparator</span></i><span style="font-size:10.0pt;font-family:Consolas;color:black">.equals( value1, value2 );</span><span style="font-size:10.0pt;font-family:Consolas"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:Consolas;color:black"> }<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:Consolas;color:black"><o:p> </o:p></span></p>
<p class="MsoNormal">I think the if statement just needs an instanceof check as well or some other way to track the fact that null may be a valid value to be comparing with!<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thomas<o:p></o:p></p>
</div>
<br>
<hr>
<font face="Arial" color="Gray" size="1"><br>
**************************************************************************************<br>
This message is confidential and intended only for the addressee. If you have received this message in error, please immediately notify the postmaster@nds.com and delete it from your system as well as any copies. The content of e-mails as well as traffic data
may be monitored by NDS for employment and security purposes. To protect the environment please do not print this e-mail unless necessary.<br>
<br>
NDS Limited. Registered Office: One London Road, Staines, Middlesex, TW18 4EX, United Kingdom. A company registered in England and Wales. Registered no. 3080780. VAT no. GB 603 8808 40-00<br>
**************************************************************************************<br>
</font>
</body>
</html>