[seam-dev] Please review 2 classes

[Jason Porter]

I left comments, not sure if it helps much though :)

On Tue, May 31, 2011 at 22:42, Peter Royle <howardmoon at screamingcoder.com>wrote:

> No worries thanks for taking a look Jason. Here's the specific commits for
> those interested in commenting:
>
>
> https://github.com/seam/cron/commit/61a516dffee906b68e111770f0f26d4f2814d027
>
> Pete
>
>
> On 01/06/2011, at 2:37 PM, Jason Porter wrote:
>
> Either it's too late to review this right now, or I'm not the best to
> review it. Could be both, also, could you list the commits to look at so
> those that do review it can add comments via GitHub?
>
> On Thu, May 26, 2011 at 00:36, Pete Royle <howardmoon at screamingcoder.com>wrote:
>
>> Hi,
>>
>> Speaking of code reviews. I've just made @Asynchronous portable using an
>> adaptation of Stuart Douglas' ThreadLocal idea, plus some
>> InvocationContext fiddling. I tried to understand the Interceptor Spec
>> and how it related to what I was trying to do, but I still wasn't sure
>> exactly what was expected of me to keep the spec happy. In the end I
>> managed to get it working by watching the behavior of the threads in the
>> debugger and pandering to that. It seemed consistent between OWB and
>> Weld at least, and the resulting solution works in both containers.
>>
>> Anyway, I'm clearly not 100% trustworthy of this code, particularly wrt
>> being within the spec, so would appreciate some experts giving it the
>> once-over.
>>
>>
>> https://github.com/seam/cron/tree/master/spi/src/main/java/org/jboss/seam/cron/spi/asynchronous
>>
>> Cheers,
>>
>> Pete R.
>> _______________________________________________
>> seam-dev mailing list
>> seam-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/seam-dev
>>
>
>
>
> --
> Jason Porter
> http://lightguard-jp.blogspot.com
> http://twitter.com/lightguardjp
>
> Software Engineer
> Open Source Advocate
> Author of Seam Catch - Next Generation Java Exception Handling
>
> PGP key id: 926CCFF5
> PGP key available at: keyserver.net, pgp.mit.edu
>
>
>


-- 
Jason Porter
http://lightguard-jp.blogspot.com
http://twitter.com/lightguardjp

Software Engineer
Open Source Advocate
Author of Seam Catch - Next Generation Java Exception Handling

PGP key id: 926CCFF5
PGP key available at: keyserver.net, pgp.mit.edu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/seam-dev/attachments/20110531/27d5c066/attachment.html