<br><br><div class="gmail_quote">On Tue, May 5, 2009 at 10:31 AM, Clint Popetz <span dir="ltr"><<a href="mailto:cpopetz@gmail.com">cpopetz@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div></div><div class="h5">On Tue, May 5, 2009 at 9:21 AM, Dan Allen <<a href="mailto:dan.j.allen@gmail.com">dan.j.allen@gmail.com</a>> wrote:<br>
><br>
><br>
> On Tue, May 5, 2009 at 7:59 AM, Clint Popetz <<a href="mailto:cpopetz@gmail.com">cpopetz@gmail.com</a>> wrote:<br>
>><br>
>> On Tue, May 5, 2009 at 6:26 AM, Pete Muir <<a href="mailto:pmuir@redhat.com">pmuir@redhat.com</a>> wrote:<br>
>> ><br>
>> > On 29 Apr 2009, at 07:10, Dan Allen wrote:<br>
>> >> Instead of thinking of replacing the class 1-for-1, think if perhaps<br>
>> >> there<br>
>> >> is base functionality that would be relevant for any environment and<br>
>> >> specific functionality for a framework like JSF. Then, you can create a<br>
>> >> generic class and then specialize it using a deployment type and<br>
>> >> @Specializes. Two examples of this so far are<br>
>> >> StatusMessages/FacesStatusMessages and Expressions/FacesExpressions. I<br>
>> >> believe that Selector is another candidate for this. There is nothing<br>
>> >> specific to JSF about a selector, but it just happens to be in the JSF<br>
>> >> package in Seam 2.1.<br>
>><br>
>> I'm glad to see that this type of consideration is being given to<br>
>> making Seam3 independent of view layer choice. However, I want to<br>
>> point out that using a deployment type and @Specializes would seem to<br>
>> place us in the same situation as Seam 2.x with respect to the view<br>
>> layers co-existing in the same deployment, which<br>
>> <a href="https://jira.jboss.org/jira/browse/JBSEAM-3645" target="_blank">https://jira.jboss.org/jira/browse/JBSEAM-3645</a> was meant to address.<br>
>><br>
>> In other words, I'd rather that the choice of the StatusMessages bean<br>
>> that will be activated isn't based on deployment type, but rather is<br>
>> chosen at runtime based on the type of request, using the pattern in<br>
>> the patch for the above jira issue. Deployment types would of course<br>
>> still be used to choose which implementations of things like<br>
>> StatusMessages are available.<br>
>><br>
>> I'd be willing to do the work to make that happen, if it can be<br>
>> coordinated in such a way that I'm not getting in your way.<br>
><br>
> Ah, good thinking. I was thinking too narrowly. I'm always open to<br>
> collaboration, and I work well with diff and patch...so if there is a patch<br>
> you would like to share with me (pre-commit) I would be glad to test it out<br>
> and discuss with you possible next steps.<br>
<br>
</div></div>I haven't yet seen the work you're doing, so can't patch it easily :P<br>
<br>
I'd say that you could go ahead and commit it and I can look<br>
immediately at patching and committing changes to add the runtime<br>
flexibility. Alternatively the above jira has a patch to the previous<br>
seam trunk (pre-cleanup) that is well documented. Or you can send me<br>
your source in patch form pre-commit. The first option is probably<br>
the easiest for both of us.</blockquote><div><br>Everything I have so far is checked in to seam/modules/trunk. But yes, I will review what was proposed for Seam 2 and see if I can work out a solution. I think one way is to change the deployment type to a binding type. That way you do:<br>
<br>@Faces StatusMessages statusMessages;<br><br>I was think I had to completely disable the generic messages, but you have clued me into the fact that they can exist simultaneously. That is the purpose of a binding type. In fact, I know this is the right solution. When the messages are transferred before render, only the @Faces StatusMessages will be transfer to the JSF context whereas the @Wicket StatusMessages will be transferred to the wicket context (since you can only render one or the other for any given request).<br>
<br>-Dan</div></div><br>-- <br>Dan Allen<br>Senior Software Engineer, Red Hat | Author of Seam in Action<br><br><a href="http://mojavelinux.com">http://mojavelinux.com</a><br><a href="http://mojavelinux.com/seaminaction">http://mojavelinux.com/seaminaction</a><br>
<a href="http://in.relation.to/Bloggers/Dan">http://in.relation.to/Bloggers/Dan</a><br><br>NOTE: While I make a strong effort to keep up with my email on a daily<br>basis, personal or other work matters can sometimes keep me away<br>
from my email. If you contact me, but don't hear back for more than a week,<br>it is very likely that I am excessively backlogged or the message was<br>caught in the spam filters. Please don't hesitate to resend a message if<br>
you feel that it did not reach my attention.<br>