I have commited files to build the sample on WebSphere v7 in the jee5/booking sample app, and also a rework of the WebSphere v7/Seam integration chapter in the doc<br>(I didn't touched the WebSphere/seam-gen chapter in the doc as there is another JIRA opened about seam-gen that should address that IMHO...<br>
Please let me know if that's ok.<br>Denis<br><br><br><div class="gmail_quote">2009/8/3 Pete Muir <span dir="ltr"><<a href="mailto:pmuir@redhat.com">pmuir@redhat.com</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
On 28 Jul 2009, at 18:47, Denis Forveille wrote:<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
2009/7/28 Dan Allen <<a href="mailto:dan.j.allen@gmail.com" target="_blank">dan.j.allen@gmail.com</a>><br>
<br>
> On your advice, I could describe what to do to get the<br>
> booking/"agnostic-like" app to build and run on WAS, but IMHO as an<br>
> end user discovering seam, it is much easier and faster to run a<br>
> script that builds the ear file ready-to-be deployed and then<br>
> inspect what's in the ear to mimic/adapt their own projects.<br>
<br>
Yes, I personally prefer this approach.<br>
<br>
What do others think?<br>
<br>
While I think the instructions are important, because they emphasize the changes that have to be made, I wish there was a build that would automate the modifications so that we lower the barrier to getting hands on.<br>
<br>
And yes, now that JBoss AS 5 is out, the jee5 app should be the first example any newcomer to Seam tries. Is there a place where we asterisk the default example? If so, we should asterisk the jee5 one.<br>
<br>
OK..<br>
<br>
What I could do as an example for the jee5/booking sample:<br>
- commit the build-websphere7.xml file and resource-websphere7 directory like for the jpa sample (with tailored web.xml, persistence.xml, ejb-jar.xml file etc...)<br>
AND<br>
explain in the doc what to do if you want to do it by hand, starting from the "vanilla" resource/build files to get to the WAS v7 tailored files<br>
<br>
This could be done also for JBoss5, GFv2 and OC4J as this sample is mainly target for those AS and the bookingsample could then be deprecated...<br>
</blockquote>
<br>
We should address this for Seam 3, as I stated on the other mail. I think there are a number of issues with the way the examples are structured and I would like to address in a coherant manner, not piecemeal.<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
WDYT?<br>
<br>
Two other ideas:<br>
1) I would like that the general sample build proc look first for files in the resource-<as specific> dir THEN in the resource genral dir (ie copy the general resource dir in a temp place then override with specific files from theresource-<as specific> dir) . With that, we could only put in the resource-<as specific> dir, files that are really different from the base and not all the files as for now. The end user would directly see whant files have been changes (eg pages.xml, faces-config.xml,application.xml etc....never change )<br>
</blockquote>
<br>
Or you could even use the unified diff format in the resource specific directory, perhaps as a patch file which is applied during build - this would make it super easy to see the changes needed.<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
2) I also would like to get 3 sub dirs in the "resource" folder: "META-IINF" for files that goes in the ear (ie application.xml), WEB-INF for the web module and JPA for file that go into the jpa-ejb jar<br>
</blockquote>
<br>
This is a big change, but again, we need to address the entire way we structure examples in Seam 3, and align with JBoss Tools so that our examples work ootb there. This means adopting the JBT structure for projects I think.<br>
<br>
Again, we need to start a wiki page for this :-)<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="im">
<br>
<br>
I've added this statement to the examples/readme.txt file<br>
<br>
"If you are just getting started with Seam, it's highly recommended that you<br>
study the jee5/booking example first. This example is designed to run<br>
unmodified on a Java EE 5-compliant application server. Of course, the real<br>
world is never so ideal. Therefore, you'll find modifications that you need to<br>
make for various application servers in the example's readme.txt file. These<br>
instructions can also be found in the Seam reference documentation."<br>
<br></div>
-Dan<br>
<br>
-- <br>
Dan Allen<br>
Senior Software Engineer, Red Hat | Author of Seam in Action<br>
Registered Linux User #231597<br>
<br>
<a href="http://mojavelinux.com" target="_blank">http://mojavelinux.com</a><br>
<a href="http://mojavelinux.com/seaminaction" target="_blank">http://mojavelinux.com/seaminaction</a><br>
<a href="http://in.relation.to/Bloggers/Dan" target="_blank">http://in.relation.to/Bloggers/Dan</a><br>
<br>
</blockquote>
<br>
</blockquote></div><br>