<html><body bgcolor="#FFFFFF"><div><br></div><div>On 4 Apr 2010, at 20:26, Jason Porter <<a href="mailto:lightguard.jp@gmail.com">lightguard.jp@gmail.com</a>> wrote:<br><br></div><div></div><blockquote type="cite"><div><br><div class="gmail_quote">On Sun, Apr 4, 2010 at 09:23, Dan Allen <span dir="ltr"><<a href="mailto:dan.j.allen@gmail.com"><a href="mailto:dan.j.allen@gmail.com">dan.j.allen@gmail.com</a></a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="gmail_quote"><div>Yes, I agree we should avoid duplicate class names in the public API as a general rule, because we've seen the confusion that has caused in the Java EE API (@ManagedBean, @*Scoped, etc). But still, too much package sharing can also be confusing for the developer because it becomes somewhat unclear which modules are providing which classes. So we are agreeing that modules use the base name space of org.jboss.seam.[module], correct? (With the special case of interceptors/decorators, see next).</div>
</div></blockquote><div><br></div><div>Originally I was thinking differently, but I'm good with this. It's still easy to understand, and to a degree still follows the Seam2 package structure so it shouldn't be that difficult to understand how to migrate. It also helps by knowing exactly which modules you're using just by looking at the imports. Hopefully the overlap and dependencies between modules is kept to a minimum.</div></div></div></blockquote><div><br></div>Module name in package makes sense to me.<div><br><blockquote type="cite"><div><div class="gmail_quote"><div> </div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="gmail_quote"><div>That said, Shane had brought up that interceptors and decorators should at least be under the module's base package (the second proposed convention for interceptors/decorators above). We need a vote on that convention:</div>
<div><div><br></div><div>a) org.jboss.seam.intercept / org.jboss.seam.decorate</div></div></div></blockquote><div><br></div><div>If there's a need to have common intercepters / decorators I'd say put them here, otherwise go with option b. Option B is consistent with what is being done above, so there's no ambiguity.</div></div></div></blockquote><div><br></div>Just thinking, with the current modularisatipn of Seam, would there ever be "common" interceptors / decorators? If there are then i am fine with option a but I would think most, if not all, would fall into option b.</div><div><br><blockquote type="cite"><div><div class="gmail_quote">
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="gmail_quote"><div>b) org.jboss.seam.[module].intercept / org.jboss.seam.[module].decorate</div>
<div><br></div><div>Let's find a common ground quickly on this...it's not worth dragging out.</div></div></blockquote><div><br></div><div>I agree, I dislike long conversations of this nature :) I say we're good with this, time to move on.</div></div></div></blockquote><br></div><div>Ken Finnigan</div></body></html>