I've completed #2. It's now possible to run the tests using the remote GlassFish 3.1 adapter without any modifications to the Solder test suite.<div><br></div><div>mvn clean install -Dincontainer-glassfish-rest -Dtest=CoreTest<br>
<div><br></div><div>The reorgnization resulted in a significantly reduced API. There are no longer any beans in the API. What's left are mostly just annotations, abstract classes and interfaces. That actually makes more sense, as I see the API as the programming model enhancements, useful to application developers. Extension writers, on the other hand, will require much deeper access into Solder and should use the impl. (There's probably value in having an SPI in that case, but we'll look into that later).</div>
<div><br></div><div>If you are working on a test, just ping the list or IRC so that we don't waste cycles.</div><div><br></div><div>If you can push more stuff into the API and not break the tests on GlassFish, feel free to do so. For instance, some core features like default and generic beans are only in the impl right now. Those annotations, at least, are appropriate for the API. The property query could probably also be returned. Let's take it case-by-case.</div>
<div><br></div><div>-Dan</div><div><br><div class="gmail_quote">On Sat, Jan 22, 2011 at 11:44, Dan Allen <span dir="ltr"><<a href="mailto:dan.j.allen@gmail.com">dan.j.allen@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
I'm working on this (#2), should be done shortly. Stay tuned.<div><br></div><div><font color="#888888">-Dan</font><div><div></div><div class="h5"><br><br><div class="gmail_quote">On Sat, Jan 22, 2011 at 04:38, Shane Bryzak <span dir="ltr"><<a href="mailto:sbryzak@redhat.com" target="_blank">sbryzak@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#ffffff" text="#000000">
Would it be helpful if I worked on moving the api classes to impl?<div><div></div><div><br>
<br>
On 22/01/11 08:08, Dan Allen wrote:
<blockquote type="cite">
<div class="gmail_quote">On Fri, Jan 21, 2011 at 17:07, Dan Allen
<span dir="ltr"><<a href="mailto:dan.j.allen@gmail.com" target="_blank">dan.j.allen@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">
I've done #1.
<div><br>
</div>
<div>In order to pass any test successfully on GlassFish atm,
you need to use the seam-solder combined JAR. That's
necessary until I complete #2.</div>
<div><br>
</div>
<div>Here's a list of the test failures to give you an idea of
where we are:</div>
<div><br>
</div>
<div>
<div>Tests in error: </div>
<div> testDefaultBean(org.jboss.seam.solder.test.defaultbean.DefaultBeanTest)</div>
<div> testDefaultProducerMethod(org.jboss.seam.solder.test.defaultbean.DefaultBeanTest)</div>
<div> testDefaultProducerUsesCorrectDelegate(org.jboss.seam.solder.test.defaultbean.DefaultBeanTest)</div>
<div> testDefaultProducerFields(org.jboss.seam.solder.test.defaultbean.DefaultBeanTest)</div>
<div> testDefaultBeanObserverMethods(org.jboss.seam.solder.test.defaultbean.DefaultBeanTest)</div>
<div> testGeneric(org.jboss.seam.solder.test.bean.generic.method.GenericBeanTest)</div>
<div> testGeneric(org.jboss.seam.solder.test.bean.generic.method.ProducersOnGenericBeanTest)</div>
<div> testProducerSuperclass(org.jboss.seam.solder.test.bean.generic.method.ProducersOnGenericBeanTest)</div>
<div> testGeneric(org.jboss.seam.solder.test.bean.generic.method.GenericProductTest)</div>
<div> testDisposerCalled(org.jboss.seam.solder.test.bean.generic.method.GenericProductTest)</div>
<div> testGeneric(org.jboss.seam.solder.test.bean.generic.method.QualifierOnlyGenericBeanTest)</div>
<div> testGeneric(org.jboss.seam.solder.test.bean.generic.field.GenericBeanTest)</div>
<div> testScope(org.jboss.seam.solder.test.bean.generic.field.GenericBeanTest)</div>
<div> testGenericUnwrap(org.jboss.seam.solder.test.bean.generic.field.GenericBeanUnwrapTest)</div>
<div> testGeneric(org.jboss.seam.solder.test.bean.generic.field.ObserversOnGenericBeanTest)</div>
<div> testGeneric(org.jboss.seam.solder.test.bean.generic.field.ProducersOnGenericBeanTest)</div>
<div> testGeneric(org.jboss.seam.solder.test.bean.generic.field.GenericProductTest)</div>
<div> testElResolver(org.jboss.seam.solder.test.el.ElTest)</div>
<div> testCustomElResolver(org.jboss.seam.solder.test.el.ElTest)</div>
<div> testUnwrapsInjectionPoint(org.jboss.seam.solder.test.unwraps.UnwrapsTest)</div>
<div> testUnwraps(org.jboss.seam.solder.test.unwraps.UnwrapsTest)</div>
<div> org.jboss.seam.solder.test.serviceHandler.ServiceHandlerTest</div>
<div> org.jboss.seam.solder.test.serviceHandler.ServiceHandlerTest</div>
<div>
org.jboss.seam.solder.test.bean.generic.alternative.GenericBeanAlternativeTest</div>
<div> org.jboss.seam.solder.test.bean.generic.alternative.GenericBeanAlternativeTest</div>
<div><br>
</div>
<div>Tests run: 94, Failures: 0, Errors: 25, Skipped: 0</div>
</div>
<div><br>
</div>
<div>If you want to start testing, you need to change
Deployments.java as follows until #2 is done.</div>
<div><br>
</div>
<div>
<div>public class Deployments</div>
<div>{</div>
<div> private static final String LOCAL_MAVEN_REPO =</div>
<div> System.getProperty("maven.repo.local") != null
? System.getProperty("maven.repo.local") :</div>
<div> (System.getProperty("user.home") +
File.separatorChar +</div>
<div>
".m2" + File.separatorChar + "repository");</div>
<div><br>
</div>
<div> public static WebArchive baseDeployment()</div>
<div> {</div>
<div> return ShrinkWrap.create(WebArchive.class,
"test.war")</div>
<div> .addLibraries(</div>
<div> new File(LOCAL_MAVEN_REPO +
File.separator + "org.jboss.seam.solder".replace(".",
File.separator) +</div>
<div> File.separator + "seam-solder" +
File.separator + "3.0.0-SNAPSHOT" + File.separator +
"seam-solder-3.0.0-SNAPSHOT.jar"),</div>
<div>
MavenArtifactResolver.resolve("org.jboss.logging",
"jboss-logging"))</div>
<div> .addWebResource(EmptyAsset.INSTANCE,
"beans.xml");</div>
<div> }</div>
<div>}</div>
</div>
</blockquote>
<div><br>
</div>
<div>Of course, you have to install the combined jar first ;)</div>
<div><br>
</div>
<div>-Dan</div>
<div><br>
</div>
</div>
-- <br>
<div>Dan Allen</div>
Principal Software Engineer, Red Hat | Author of Seam in Action<br>
Registered Linux User #231597<br>
<br>
<a href="http://mojavelinux.com" target="_blank">http://mojavelinux.com</a><br>
<a href="http://mojavelinux.com/seaminaction" target="_blank">http://mojavelinux.com/seaminaction</a><br>
<a href="http://www.google.com/profiles/dan.j.allen" target="_blank">http://www.google.com/profiles/dan.j.allen</a><br>
</blockquote>
<br>
</div></div></div>
</blockquote></div><br><br clear="all"><br>-- <br><div>Dan Allen</div>Principal Software Engineer, Red Hat | Author of Seam in Action<br>Registered Linux User #231597<br><br><a href="http://mojavelinux.com" target="_blank">http://mojavelinux.com</a><br>
<a href="http://mojavelinux.com/seaminaction" target="_blank">http://mojavelinux.com/seaminaction</a><br><a href="http://www.google.com/profiles/dan.j.allen" target="_blank">http://www.google.com/profiles/dan.j.allen</a><br>
</div></div></div>
</blockquote></div><br><br clear="all"><br>-- <br><div>Dan Allen</div>Principal Software Engineer, Red Hat | Author of Seam in Action<br>Registered Linux User #231597<br><br><a href="http://mojavelinux.com" target="_blank">http://mojavelinux.com</a><br>
<a href="http://mojavelinux.com/seaminaction" target="_blank">http://mojavelinux.com/seaminaction</a><br><a href="http://www.google.com/profiles/dan.j.allen" target="_blank">http://www.google.com/profiles/dan.j.allen</a><br>
</div></div>