<html><body bgcolor="#FFFFFF"><div>Yeah, I forgot I also need to create submodules on impl so that each implementation is isolated from each other before merging.</div><div><br></div><div>Lets see what comes next :)<br><br>
Em 26/05/2011, às 02:09, Dan Allen <<a href="mailto:dan.j.allen@gmail.com">dan.j.allen@gmail.com</a>> escreveu:<br><br></div><div></div><blockquote type="cite"><div>Don't forget that Jordan has a Pentaho implementation in prototype to look through as well. Be gentle, it's still on a branch :)<div>
<br></div><div><a href="https://github.com/jganoff/reports/tree/SEAMREPORTS-5"><a href="https://github.com/jganoff/reports/tree/SEAMREPORTS-5">https://github.com/jganoff/reports/tree/SEAMREPORTS-5</a></a></div>
<div><br></div><div>-Dan</div><div><br><div class="gmail_quote">On Thu, May 26, 2011 at 01:05, Dan Allen <span dir="ltr"><<a href="mailto:dan.j.allen@gmail.com"><a href="mailto:dan.j.allen@gmail.com">dan.j.allen@gmail.com</a></a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div>Thanks for raising this George.</div><div><br></div><div>Both of these modules are really on fire right now (come to think of it, that's true of a lot of modules). But anyway, definitely look through them. That's what really matters early on. And it's really easy to browse the code on github [1] [2]. Hint, focus on the APIs. (Type 't' to see all files and navigate them) </div>
<div><br></div><div>Unfortunately, at this point you can only comment on commits, so simply post to the mailinglist or chat in IRC if you want to provide general feedback.</div><div class="im">
<div><br></div><div>On Thu, May 26, 2011 at 00:47, George Gastaldi <span dir="ltr"><<a href="mailto:gegastaldi@gmail.com" target="_blank"><a href="mailto:gegastaldi@gmail.com">gegastaldi@gmail.com</a></a>></span> wrote:</div>
</div><div class="gmail_quote">
<div class="im"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I encourage to extend that good practice whenever is possible to other<br>
modules as well.<br>
Could be a topic to discuss on the meeting next week.<br></blockquote><div><br></div></div><div>George and Antoine got me thinking that perhaps we should have a "request for review" section on the project site (or some other feed mechanism) so that you can see what's currently "up for review". This should help passer-byes know when and where to jump in.</div>
<div><br></div><div>I recommend using this template for requesting a review:</div><div><br></div><div>Module: (e.g., Social)</div><div>Type: (e.g., code | documentation | example)</div><div>Focus: (e.g., APIs, type names, implementation strategy, etc)</div>
<div>Other notes: </div><div><br></div><div>The clearer the focus, the more feedback you are likely going to get (since people know what to look for).</div><div><br></div><div>-Dan</div><div><br></div></div>[1] <a href="https://github.com/seam/social" target="_blank"><a href="https://github.com/seam/social">https://github.com/seam/social</a></a><div>
[2] <a href="https://github.com/seam/reports" target="_blank"><a href="https://github.com/seam/reports">https://github.com/seam/reports</a></a></div><div><br><font color="#888888">-- <br><div>Dan Allen</div>Principal Software Engineer, Red Hat | Author of Seam in Action<br>
Registered Linux User #231597<br>
<br><div><a href="http://www.google.com/profiles/dan.j.allen#about" target="_blank"><a href="http://www.google.com/profiles/dan.j.allen#about">http://www.google.com/profiles/dan.j.allen#about</a></a><br><a href="http://mojavelinux.com" target="_blank"><a href="http://mojavelinux.com">http://mojavelinux.com</a></a><br>
<a href="http://mojavelinux.com/seaminaction" target="_blank"><a href="http://mojavelinux.com/seaminaction">http://mojavelinux.com/seaminaction</a></a></div>
</font></div>
</blockquote></div><br><br clear="all"><br>-- <br><div>Dan Allen</div>Principal Software Engineer, Red Hat | Author of Seam in Action<br>Registered Linux User #231597<br><br><div><a href="http://www.google.com/profiles/dan.j.allen#about" target="_blank"><a href="http://www.google.com/profiles/dan.j.allen#about">http://www.google.com/profiles/dan.j.allen#about</a></a><br>
<a href="http://mojavelinux.com" target="_blank"><a href="http://mojavelinux.com">http://mojavelinux.com</a></a><br><a href="http://mojavelinux.com/seaminaction" target="_blank"><a href="http://mojavelinux.com/seaminaction">http://mojavelinux.com/seaminaction</a></a><br>
</div><br>
</div>
</div></blockquote></body></html>